Chrome Version: 54.0.2802.0 Revision fc6aaca4ed6ff4f050e6f5c7fb19af85da8db574-refs/heads/master@{#406441}(32/64 bit)
OS: Windows(7,8,10), Linux (Ubuntu 14.04 LTS),Mac(10.10.5,10.11.4)
Steps:
1. Launch Chrome and navigate to chrome://history.
2. Click on menu button to open overlay drawer, press tab key and observe.
Actual: Unnecessary focus moves outside overlay drawer on pressing tab key.
Expected: Focus should move within overlay drawer on pressing tab key.
This is a regression issue broken in M-54, below is bisect info.
Good build: 54.0.2799.0
Bad build: 54.0.2800.0
Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/0db21f9f2bc7bee9c40c64c5ad192297d32a567c..009cf62ee240d54d1f840d3075697ea8c8974164?pretty=fuller&n=100
Suspecting: r406055 ?
Please help to re-assign if your change is not the cause for this issue.
Just to update still seeing this issue on MAC 10.11.5, Ubuntu 14.04 for chrome version 54.0.2808.0.
@msramek: Issue is marked with a blocker label. Request you to please take a look into it.
Thanks.!
Can confirm that this was caused by my CL.
When the footer about other forms of history is displayed, the link in it is a tabstop and Tab correctly cycles between the four tabstops in the sidebar.
When the footer is not displayed, it somehow causes Tab to reach outside of the sidebar. Removing the link from the footer does fix this. But of course, we need the link there and we need it to be a tabstop for accessibility reasons.
This actually looks to me like a bug in renderer, but I'll see if there's some CSS to get around it.
tsergeant@ : The recent canary 54.0.2820.0 does not produce any overlay upon clicking on History on the left pane of Chrome://history page.Could you please update the expected behavior in this page.
Yup, I'm looking into this for M57. MD Settings is working on a solution for their drawer (https://codereview.chromium.org/2465433002/) which I'll try to adapt for History.
Tested this issue on Win-10, Ubuntu 14.04 and Mac 10.12.2 using chrome version #57.0.2984.0 as per comment #0.
Observed that issue still exist as unnecessary focus moved outside overlay drawer on pressing tab key.
Attaching screen cast for reference.
tsergeant@ - Could you please have a look into this issue.
Thanks...!!
Comment 1 by ranjitkan@chromium.org
, Jul 20 2016