Issue metadata
Sign in to add a comment
|
Regression: [MD Settings] "About Chrome" in side nav not highlighted
Reported by
dchau...@etouch.net,
Jul 20 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: 52.0.2743.82 (Official Build)49721773c8dd62828e471ca69e2c89767f98c690-refs/branch-heads/2743@{#670} 32/64-bit. OS: Windows (7,8,8.1,10), Mac(10.10.5, 10.11.4), Linux(14.04 LTS). What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://md-settings page. 2. Click on iron-icon on toolbar to open side nav menu list. 3. Now, click on 'About chrome' option and observe. Color or font of 'About Chrome' text doesn't change after clicking on it. Color or font of 'About Chrome' text should change to blue or bold after clicking on it. This is a regression issue, broken in M-52 series, below is bisect info. Good build: 52.0.2725.0 Bad build: 52.0.2728.0 Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/75c6ee446bfee7026eddea82481bace58c529ea1..05b772d9beb759082cbe467ad466962dd669cc3e?pretty=fuller&n=50 Suspecting: r391961 Kindly review the attached screen-cast for reference.
,
Jul 20 2016
I am not sure if the font color is expected to change. I don't see the "Advanced" text changing color either. @tbuckley: Could you please triage this?
,
Jul 22 2016
The "About" page should change color like the section links (but "Advanced" should not -- the other pages are all destinations).
,
Jul 22 2016
,
Jul 22 2016
,
Jul 22 2016
,
Jul 22 2016
,
Aug 22 2016
,
Aug 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/774641b646fbb2b61818ba6637e356a06815932f commit 774641b646fbb2b61818ba6637e356a06815932f Author: dschuyler <dschuyler@chromium.org> Date: Tue Aug 23 02:40:55 2016 [MD settings] make About menu item blue when selected This CL corrects a regression on the blue highlighting in the side nav menu. BUG= 593989 , 629783 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2267133002 Cr-Commit-Position: refs/heads/master@{#413645} [modify] https://crrev.com/774641b646fbb2b61818ba6637e356a06815932f/chrome/browser/resources/settings/settings_menu/settings_menu.html [modify] https://crrev.com/774641b646fbb2b61818ba6637e356a06815932f/chrome/browser/resources/settings/settings_menu/settings_menu.js
,
Aug 23 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sheriffbot@chromium.org
, Jul 20 2016