New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 629777 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 630236



Sign in to add a comment

Non-Regression: Weird overlapping is seen in files app when zoom is restored to default

Project Member Reported by sc00335...@techmahindra.com, Jul 20 2016

Issue description

Version: 54.0.2800.2/8609.0.0 (Official Build) dev-channel Daisy, Peppy, Blaze
OS: Chrome

What steps will reproduce the problem?
(1) Open Files app >> Make sure you have some files in it 
(2) Resize files app window from right to left >> Zoom in window to extreme >> Use ctrl+0 to bring back to original zoom value >> Now resize files app window[Please refer video] and observe 

Expected: No such overlapping should be seen when restored to original zoom.
Actual: Instead weird overlapping is seen.

This is a Non-regression issue as same behavior is seen 38.0.2125.101/6158.49.0 (Official Build) beta-channel daisy.

@fukino: Please confirm the issue.
 
Actual_overlapping.webm
1.3 MB View Download

Comment 1 by fukino@chromium.org, Jul 20 2016

Cc: fukino@chromium.org
Owner: yamaguchi@chromium.org
yamaguchi@, could you take a look?
I think the thumbnail icon (in circle shape) should be inside the cell for file names.
Able to reproduce the issue on Chrome (Daisy) Version: 54.0.2800.2/8609.0.0 (Official Build) dev-channel.
Status: Started (was: Assigned)
There are 2 bugs behind this issue.
1. When zoomed out, the columns should be restored in a better manner rather than cramming to the left side of the window.
2. The image thumbnail icons should not get out of the file name column. (Filed  Issue 630236  )

Blockedon: 630236
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c8878378f0f17a33b853a081e2d0f34f4c43cac

commit 2c8878378f0f17a33b853a081e2d0f34f4c43cac
Author: yamaguchi <yamaguchi@chromium.org>
Date: Mon Jul 25 02:56:50 2016

Avoid generating negative width of columns when the view is too small.
This change will make the table columns to expand evenly when the window is resized back to the normal size from a very narrow size, like seen in the linked bug.

BUG= 629777 

Review-Url: https://codereview.chromium.org/2172173002
Cr-Commit-Position: refs/heads/master@{#407400}

[modify] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/ui/file_manager/file_manager/foreground/js/ui/file_table.js
[modify] https://crrev.com/2c8878378f0f17a33b853a081e2d0f34f4c43cac/ui/file_manager/file_manager/foreground/js/ui/file_table_unittest.js

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Chrome OS 8697.0.0, 54.0.2826.0

Sign in to add a comment