New issue
Advanced search Search tips

Issue 629764 link

Starred by 2 users
Status: Fixed
Owner:
ricea@chromium.org
Closed: Jul 2016
Cc:
panicker@chromium.org
yoavweiss@chromium.org
npm@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 467945


Sign in to add a comment

PerformanceResourceTiming transferSize field is not set for sync XHR

Project Member Reported by ricea@chromium.org, Jul 20 2016 
What steps will reproduce the problem?
(1) Perform a synchronous XMLHttpRequest for a resource not in cache
(2) Access the PerformanceResourceTiming object for the request
(3) Look at the transferSize field

What is the expected output?

Non-zero

What do you see instead?

Zero

Comment 1 by ricea@chromium.org, Jul 27 2016 

Background: the transferSize field was added as part of the fix for  Issue 467945 ,
"Add the size related fields to Performance Resource Timing API", last week. This
issue was discovered before the implementation was loaded, but fixing it was
postponed to prioritise getting the basic implementation working.

Support for this field is required for compliance with the spec and
conformity with other implementations (currently only Firefox).
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c572809b49cae15c0697aa056990c9bf660a068f

commit c572809b49cae15c0697aa056990c9bf660a068f
Author: ricea <ricea@chromium.org>
Date: Wed Jul 27 10:08:30 2016

Fix PerformanceResourceTiming transferSize field for sync XHR

Previously the transferSize field for synchronous XHR was only being set
when devtools was open. Set it always.

This CL also adds a layout test specifically for this case.

BUG= 629764 
TBR=esprehn,hubbe

Review-Url: https://codereview.chromium.org/2163183002
Cr-Commit-Position: refs/heads/master@{#408085}

[modify] https://crrev.com/c572809b49cae15c0697aa056990c9bf660a068f/content/child/resource_dispatcher.cc
[modify] https://crrev.com/c572809b49cae15c0697aa056990c9bf660a068f/content/child/web_url_loader_impl.cc
[modify] https://crrev.com/c572809b49cae15c0697aa056990c9bf660a068f/content/child/web_url_loader_impl.h
[modify] https://crrev.com/c572809b49cae15c0697aa056990c9bf660a068f/content/child/web_url_loader_impl_unittest.cc
[modify] https://crrev.com/c572809b49cae15c0697aa056990c9bf660a068f/content/test/mock_weburlloader.h
[modify] https://crrev.com/c572809b49cae15c0697aa056990c9bf660a068f/media/blink/mock_weburlloader.h
[add] https://crrev.com/c572809b49cae15c0697aa056990c9bf660a068f/third_party/WebKit/LayoutTests/http/tests/misc/resource-timing-sizes-sync-xhr-transfer-size-worker.html
[add] https://crrev.com/c572809b49cae15c0697aa056990c9bf660a068f/third_party/WebKit/LayoutTests/http/tests/misc/resource-timing-sizes-sync-xhr-transfer-size.html
[add] https://crrev.com/c572809b49cae15c0697aa056990c9bf660a068f/third_party/WebKit/LayoutTests/http/tests/misc/resources/resource-timing-sizes-sync-xhr-transfer-size.js
[modify] https://crrev.com/c572809b49cae15c0697aa056990c9bf660a068f/third_party/WebKit/Source/core/fetch/ResourceLoader.cpp
[modify] https://crrev.com/c572809b49cae15c0697aa056990c9bf660a068f/third_party/WebKit/Source/platform/testing/weburl_loader_mock.cc
[modify] https://crrev.com/c572809b49cae15c0697aa056990c9bf660a068f/third_party/WebKit/Source/platform/testing/weburl_loader_mock.h
[modify] https://crrev.com/c572809b49cae15c0697aa056990c9bf660a068f/third_party/WebKit/Source/platform/testing/weburl_loader_mock_factory_impl.cc
[modify] https://crrev.com/c572809b49cae15c0697aa056990c9bf660a068f/third_party/WebKit/Source/platform/testing/weburl_loader_mock_factory_impl.h
[modify] https://crrev.com/c572809b49cae15c0697aa056990c9bf660a068f/third_party/WebKit/Source/web/AssociatedURLLoader.cpp
[modify] https://crrev.com/c572809b49cae15c0697aa056990c9bf660a068f/third_party/WebKit/Source/web/AssociatedURLLoader.h
[modify] https://crrev.com/c572809b49cae15c0697aa056990c9bf660a068f/third_party/WebKit/public/platform/WebURLLoader.h

Comment 3 by ricea@chromium.org, Jul 29 2016

Status: Fixed (was: Started)
►

Sign in to add a comment