New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 629737 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Not on Chrome
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Overlapping of footer message is seen after resizing the browser window.

Reported by yfulgaon...@etouch.net, Jul 20 2016

Issue description

Chrome version : 54.0.2802.0 (Official Build) fc6aaca4ed6ff4f050e6f5c7fb19af85da8db574-refs/heads/master@{#406441} (32/64 bit)
OS : Windows (7,8,8.1,10), Mac(10.10.5, 10.11.4), Linux(14.04 LTS)

Precondition: Enable the 'Material Design history' flag from chrome://flags.

What steps will reproduce the problem?
1. Launch chrome and sign in to chrome using valid credentials.
2. Go to chrome://history and click on History side bar.
3. Click on Restore down button and resize the browser upwards, observe.

Actual : Overlapping of footer message is seen after resizing the browser window.
Expected : No such overlapping should be seen after resizing the browser window.

This is a non-regression issue, seen from M-54 (Build - 54.0.2800.0) as this footer message has introduced in this build.
 
Actual_footer_msg.mp4
1.6 MB View Download
Labels: -Pri-2 Pri-3
Untriaging it so that it gets addressed.
Status: Untriaged (was: Unconfirmed)
Cc: lshang@chromium.org
Labels: -M-54 M-56
Owner: tsergeant@chromium.org
Status: Started (was: Untriaged)
I've changed the layout so that the sidebar will be scrollable in short windows. 
Footer1.png
40.7 KB View Download
Footer2.png
27.6 KB View Download
Footer3.png
20.5 KB View Download
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd29d296277d9115186c6f76e1cebce4eaefc2fc

commit bd29d296277d9115186c6f76e1cebce4eaefc2fc
Author: tsergeant <tsergeant@chromium.org>
Date: Wed Oct 12 07:17:38 2016

MD History: Fix overlapping of sidebar footer in very short windows

The footer was previously absolutely positioned at the bottom of the
sidebar, which caused it to overlap with the sidebar content in very
short windows. This changes the layout of the sidebar so that items
cannot overlap, instead using a scrollbar when necessary.

BUG= 629737 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2412003002
Cr-Commit-Position: refs/heads/master@{#424686}

[modify] https://crrev.com/bd29d296277d9115186c6f76e1cebce4eaefc2fc/chrome/browser/resources/md_history/app.html
[modify] https://crrev.com/bd29d296277d9115186c6f76e1cebce4eaefc2fc/chrome/browser/resources/md_history/app.vulcanized.html
[modify] https://crrev.com/bd29d296277d9115186c6f76e1cebce4eaefc2fc/chrome/browser/resources/md_history/side_bar.html

Status: Fixed (was: Started)

Sign in to add a comment