New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 629735 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 429053



Sign in to add a comment

comformance2/renderbuffers/framebuffer-object-attachment.html test fails on Linux Mesa 11.2 and 12.0 Core

Project Member Reported by jiawei.s...@intel.com, Jul 20 2016

Issue description

OS: Linux

What steps will reproduce the problem?
(1) open chrome with command line: --enable-unsafe-es3-apis
(2) open url: https://www.khronos.org/registry/webgl/sdk/tests/conformance2/renderbuffers/framebuffer-object-attachment.html?webglVersion=2&quiet=0

What is the expected output?
All tests pass.

What do you see instead?
A test fail:
checkFramebufferStatus expects [FRAMEBUFFER_UNSUPPORTED], was FRAMEBUFFER_COMPLETE

CL https://codereview.chromium.org/2161383002/ is trying to solve this issue.

 
Do you know why other platform doesn't have such problem?
In GLES3.0 and WebGL2 spec, depth and stencil attachments should be the same image if both attachmets are present, or the status of the framebuffer is GL_FRAMEBFUFER_UNSUPPORTED, but in OpenGL 4.3 spec there is no such restriction.

In current code, there is no validation about this restriction, so function DoCheckFramebufferStatus will finally call function glCheckFramebufferStatusEXT in Framebuffer::GetStatus, and the return value of this function is driver-specified since it is GL_FRAMEBUFFER_UNSUPPORTED on Linux NVidia and Windows Intel and GL_FRAMEBUFFER_COMPLETE on Linux Mesa.
Summary: comformance2/renderbuffers/framebuffer-object-attachment.html test fails on Linux Mesa 11.2 and 12.0 Core (was: comformance2/renderbuffers/framebuffer-object-attachment.html test fails on Linux Mesa)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4b0966ca74a50608dc4e206f220dfff38783c88

commit b4b0966ca74a50608dc4e206f220dfff38783c88
Author: jiawei.shao <jiawei.shao@intel.com>
Date: Sat Jul 23 00:05:47 2016

Add check if depth and stencil attachments are same image

In GLES3.0 and WebGL2 spec, depth and stencil attachments should be the same image if both
attachmets are present, or the status of the framebuffer is GL_FRAMEBFUFER_UNSUPPORTED, but
in OpenGL 4.3 spec there is no such restriction.

This patch adds the validation in command_buffer and updates the related unittests to meet
this restriction.

BUG= 629735 

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2161383002
Cr-Commit-Position: refs/heads/master@{#407309}

[modify] https://crrev.com/b4b0966ca74a50608dc4e206f220dfff38783c88/gpu/command_buffer/service/framebuffer_manager.cc
[modify] https://crrev.com/b4b0966ca74a50608dc4e206f220dfff38783c88/gpu/command_buffer/service/framebuffer_manager_unittest.cc

Status: Verified (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b8fd9ea8b619122a0daea7fe53a70c585bad2ca

commit 4b8fd9ea8b619122a0daea7fe53a70c585bad2ca
Author: qiankun.miao <qiankun.miao@intel.com>
Date: Tue Jul 26 07:05:54 2016

Update fbo completeness test expectations

BUG= 598902 ,  629735 ,  628496 
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2174353003
Cr-Commit-Position: refs/heads/master@{#407727}

[modify] https://crrev.com/4b8fd9ea8b619122a0daea7fe53a70c585bad2ca/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Sign in to add a comment