New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 629726 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug

Blocking:
issue 729924



Sign in to add a comment

Bookmark app icons disappear sometimes

Project Member Reported by benwells@chromium.org, Jul 20 2016

Issue description

Sometimes the nice bookmark app icon disappears and is replaced with the generated icon.


 
Labels: -M-54
Blocking: 729924
Labels: OS-Chrome OS-Linux OS-Windows
Cc: ortuno@chromium.org mgiuca@chromium.org
Labels: -Pri-3 Pri-2
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe639a3d71066331d8a20bfb3505ec500e78c2ac

commit fe639a3d71066331d8a20bfb3505ec500e78c2ac
Author: Ben Wells <benwells@chromium.org>
Date: Thu Aug 10 06:50:09 2017

Add logging to help understand bookmark apps icon bug.

This bug is hard to reproduce on local builds. Adding logging to help
get insight into the bug happening in the wild.

Bug:  629726 
Change-Id: I53da4035fd5800aa10cbd777dde9e66467b201a3
Reviewed-on: https://chromium-review.googlesource.com/607742
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#493311}
[modify] https://crrev.com/fe639a3d71066331d8a20bfb3505ec500e78c2ac/chrome/browser/extensions/bookmark_app_helper.cc
[modify] https://crrev.com/fe639a3d71066331d8a20bfb3505ec500e78c2ac/chrome/browser/extensions/convert_web_app.cc
[modify] https://crrev.com/fe639a3d71066331d8a20bfb3505ec500e78c2ac/chrome/browser/extensions/extension_sync_service.cc

Components: UI>Browser>WebAppInstalls
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3011ee3972d2b8568df02cf0797e100fb832392

commit c3011ee3972d2b8568df02cf0797e100fb832392
Author: Ben Wells <benwells@chromium.org>
Date: Fri Sep 08 07:12:10 2017

Fix syncing bookmark app icons to stable channel.

Without this fix, the icons would sync to stable channel but then be
lost of all computers synced to afterwards.

Bug:  601646 ,  629726 
Change-Id: Iff1bda32960e22c5004f517355785aa1fb5a1517
Reviewed-on: https://chromium-review.googlesource.com/656867
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500532}
[modify] https://crrev.com/c3011ee3972d2b8568df02cf0797e100fb832392/chrome/common/extensions/api/_manifest_features.json

Labels: Merge-Request-62 M-62
Labels: -Merge-Request-62 Merge-Approved-62
Approving merge to M62. Branch: 3202
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 12 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92831e6dc997672c90aaf2b51d80dfbcbef67f94

commit 92831e6dc997672c90aaf2b51d80dfbcbef67f94
Author: Ben Wells <benwells@chromium.org>
Date: Tue Sep 12 07:49:51 2017

Fix syncing bookmark app icons to stable channel.

Without this fix, the icons would sync to stable channel but then be
lost of all computers synced to afterwards.

TBR=benwells@chromium.org

(cherry picked from commit c3011ee3972d2b8568df02cf0797e100fb832392)

Bug:  601646 ,  629726 
Change-Id: Iff1bda32960e22c5004f517355785aa1fb5a1517
Reviewed-on: https://chromium-review.googlesource.com/656867
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Ben Wells <benwells@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500532}
Reviewed-on: https://chromium-review.googlesource.com/662007
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#161}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/92831e6dc997672c90aaf2b51d80dfbcbef67f94/chrome/common/extensions/api/_manifest_features.json

Status: Fixed (was: Started)
Labels: Needs-Feedback
benwells@ Could you please help us with repro steps to verify the Fix the from TE-End.

Thank You...
Unfortunately this can't really be tested unless you rebuild chrome so that it thinks it is stable channel or run beta channel such that it thinks it is stable. I don't know how to do that.

Sign in to add a comment