New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 629725 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Move Add to Shelf/Desktop item to the top level hotdog menu

Project Member Reported by benwells@chromium.org, Jul 20 2016

Issue description

This is currently very undiscoverable. As well as other things being investigated (e.g. badging) we should just move it up a level on ChromeOS.

Alex / Jenn - do we need any launch / UI review for this? 

 
Components: UI>Browser>AppShortcuts
Labels: M-54

Comment 2 by rolfe@chromium.org, Jul 21 2016

Do more people Add to Shelf on CrOS than any other device (or is the expectation they would if only it were more visible?)

FYI related deck on edwardjung@ and ainslie@'s simplifying of the desktop wrench menu:
https://docs.google.com/presentation/d/1JmoEYiFnQeh4gT2wVw1p0UuuC4n-eyOTF57TG_7lklw/edit#slide=id.p
Would be interesting to check stats on how add to shelf changed around that time (did more people find it with fewer options in the menu?)

From owencm@ and my research with top contributors last fall it fewer than half said they would use it. Presumably top contributors would be more likely than a typical user.
https://docs.google.com/presentation/d/1vPv17lNJWJU6v2TvMP0fZxN1i0fl7EjfHbooODU6SSw/edit#slide=id.gd02f590d6_1_72

Curious about what led to wanting to move this item out of the nested menu. Was there any specific impetus?
Sorry I should have put in some context.

This came up in a meeting about hosted app deprecation on ChromeOS, and replacing hosted apps with bookmark apps. kuscher@ mentioned that add to shelf was very hidden and wanted to make it more discoverable. jennschen@ was also in the meeting and was supportive of moving it up in the menu.

It would be interesting to track how usage changes if we move it, but this will always have a low number of clicks, as even people who use the feature heavily would only ever add a small number of sites to their shelf.

Comment 4 by rolfe@chromium.org, Jul 27 2016

Ah got it. Missed that conversation but if it's cool with them then great! Let me know if you need UX work while jennschen@ is out for the next little while.
Labels: -Pri-3 Pri-2
kuscher - does this need launch review?
Status: Archived (was: Assigned)
As I never heard back from kuscher I'm going to archive this. Can un-archive if it becomes a thing again.
Cc: -rolfe@chromium.org mguan@chromium.org
Labels: -M-54 OS-Chrome OS-Linux OS-Mac OS-Windows
Status: Assigned (was: Archived)
Reopening. Owen - we should see if we can do this on all platforms.
Summary: Move Add to Shelf/Desktop item to the top level hotdog menu (was: Move ChromeOS Add to Shelf item to the top level hotdog menu)
Since this is currently in the same place on Chrome OS and desktop, I'd like to move it at the same time (not further fragmenting our Add to X story across CrOS and other desktop platforms).
Cc: -mguan@chromium.org mgiuca@chromium.org
Cc: benwells@chromium.org
Owner: owe...@chromium.org
Labels: -Pri-2 Pri-3
I suggest we sit on this for now and bring it up with Alex A when we are preparing to take the new install flows to UI review, does that make sense?
Sounds good.
Please cc & include chromeos-ui-review@ as well
Components: UI>Browser>WebAppInstalls
Owner: ortuno@chromium.org
Gio - wanna just look at this quickly? We can do it behind the one of the new flags.
Sure!
Project Member

Comment 16 by bugdroid1@chromium.org, Sep 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72a04d3d2176bd351d1c9ba0d3f8c1c13c258a53

commit 72a04d3d2176bd351d1c9ba0d3f8c1c13c258a53
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Tue Sep 12 05:48:41 2017

desktop-pwas: Move 'Add to Shelf/Desktop/Applications' to the top level

This is done only if the ExperimentalAppBanners feature is enabled.

Also re-arranges the strings and guards in them the grd file instead of
in c++.

Bug:  629725 
Change-Id: Iec496f5ee9c4729fdecc272223e66c5abd93a494
Reviewed-on: https://chromium-review.googlesource.com/658580
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501197}
[modify] https://crrev.com/72a04d3d2176bd351d1c9ba0d3f8c1c13c258a53/chrome/app/generated_resources.grd
[modify] https://crrev.com/72a04d3d2176bd351d1c9ba0d3f8c1c13c258a53/chrome/browser/ui/toolbar/app_menu_model.cc
[modify] https://crrev.com/72a04d3d2176bd351d1c9ba0d3f8c1c13c258a53/chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.cc

Cc: ortuno@chromium.org
Owner: bklmn@chromium.org
This is done but we are waiting on feedback from UX regarding the position of the item in top level menu.
Project Member

Comment 18 by sheriffbot@chromium.org, Oct 18 2017

Labels: Hotlist-Recharge-BouncingOwner
Owner: ----
Status: Untriaged (was: Assigned)
The assigned owner "bklmn@chromium.org" is not able to receive e-mails, please re-triage.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: ortuno@chromium.org
Status: Fixed (was: Untriaged)
Marking this as fixed. Let's assume it's in the correct place and move it if UX requests it.

Sign in to add a comment