New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 629706 link

Starred by 1 user
Status: Fixed
Owner:
erikc...@chromium.org
Closed: Jul 2016
Cc:
rsesek@chromium.org
pkotw...@chromium.org
█ noyau@chromium.org
rohitrao@chromium.org
mac-bugs-priority@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug

Blocking:
issue 629348



Sign in to add a comment

gfx_unittests failures on macOS Sierra

Project Member Reported by erikc...@chromium.org, Jul 20 2016 
2 tests crashed:
    ImageTest.SkBitmapConversionPreservesOrientation (../../ui/gfx/image/image_unittest.cc:513)
    ImageTest.SkBitmapConversionPreservesTransparency (../../ui/gfx/image/image_unittest.cc:555)

Comment 1 by karandeepb@chromium.org, Jul 20 2016

Cc: rsesek@chromium.org noyau@chromium.org pkotw...@chromium.org
Owner: rohitrao@chromium.org
Status: Assigned (was: Untriaged)
Assigning to rohitrao@ who wrote ImageTest.SkBitmapConversionPreservesOrientation.

Comment 2 by ligim...@chromium.org, Jul 20 2016 

This issue is marked as Beta blocker, M53 is scheduled to be promoted to Beta next week (07/27) please resolve asap.

Comment 3 by erikc...@chromium.org, Jul 21 2016

Cc: rohitrao@chromium.org
Owner: erikc...@chromium.org
rohitrao doesn't work on mac stuff.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1b5537dde1744629675522db737175ffcf978a4

commit e1b5537dde1744629675522db737175ffcf978a4
Author: erikchen <erikchen@chromium.org>
Date: Thu Jul 21 18:49:51 2016

Fix GetPlatformImageColor on macOS Sierra.

This test method was assuming that the output from NSReadPixel was in
deviceRGBColorSpace, which is not necessarily true in macOS Sierra.

BUG= 629706 

Review-Url: https://codereview.chromium.org/2169633004
Cr-Commit-Position: refs/heads/master@{#406921}

[modify] https://crrev.com/e1b5537dde1744629675522db737175ffcf978a4/ui/gfx/image/image_unittest_util_mac.mm

Comment 5 by erikc...@chromium.org, Jul 21 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment