MD Settings: routing to/from Advanced page broken, has extra state |
|||||
Issue descriptionas of 39c8887a5d0201f6ac08ad9902f1b5219d8fea22 1. chrome://md-settings 2. click Advanced toggly button thingy 3. navigate Back Expected: URL changes to chrome://md-settings. Advanced closes maybe? Actual: nothing happens, but we do go back a state (the Forward button becomes available) 4. navigate Back Expected: URL changes to chrome://md-settings. Advanced closes maybe? Actual: URL changes to chrome://md-settings but Advanced doesn't close, nor do we don't scroll up. What steps will reproduce the problem? (1) (2) (3) What is the expected output? What do you see instead? Please use labels and text to provide additional information.
,
Jul 22 2016
,
Jul 25 2016
so wait, if we're dropping /advanced, there should be no navigations and therefore going back wouldn't have this issue (because we're not really considering toggling more sections a "navigation"). right?
,
Jul 25 2016
I would be in favor of dropping /advanced. It would require introducing a helper method called something like isRouteInAdvanced to be used by both settings-menu and settings-page. In some ways however, that's basically a "virtual route" which we were trying to avoid. I dropped the topic after Dave advised just not spending any more time on it.
,
Jul 25 2016
I'm down to drop /advanced as a part of the route.
,
Aug 2 2016
,
Sep 20 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by michae...@chromium.org
, Jul 22 2016Labels: OS-All
this happens because currentRoute is set twice to {page: 'advanced', section: '', subpage: []} once in settings_menu.js: openPage_() then again in settings_main.js: toggle-advanced-page handler in attached() I suspect deciding on how to handle Advanced and making the necessary changes will fix this bug so I wouldn't recommend picking it up tomorrow.