New issue
Advanced search Search tips

Issue 629696 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 608535



Sign in to add a comment

MD Settings: weird Advanced toggle behavior during and after search

Project Member Reported by michae...@chromium.org, Jul 20 2016

Issue description

1. Open chrome://md-settings
2. Search for something
3. Clear the search

Expected: Advanced closes
Actual: Advanced is open

4. Click the Advanced up-arrow toggly button thingy

Expected: Advanced closes, I guess??
Actual: Advanced stays open and the page scrolls down to Advanced
 
Summary: MD Settings: weird Advanced toggle behavior during and after search (was: MD Settings: clearing search doesn't reset Advanced)
Relatedly, the Advanced up-arrow toggly button thingy doesn't work while a search query is set -- clicking it once scrolls down a little, clicking it again closes Advanced.

Maybe we should just hide it during search?

Comment 2 by dpa...@chromium.org, Jul 20 2016

I think this issue is more generic. What should happen when "search" is cleared? Do we restore the previous context?

Imagine that search can be triggered by any subpage, for example go to chrome://md-settings/searchEngines (or chrome://settings/advanced), trigger search, then clear search. What do you expect.

Agreed that at the very least, even if we do nothing (leave advanced expanded), we should ensure that any "adnavced" related toggle buttons work.
Blocking: 608535
Cc: tbuck...@chromium.org bettes@chromium.org
These are good questions (that old Options bypasses by using modal dialogs instead of sub-pages). +tbuckley, bettes
Components: UI>Settings
Labels: Proj-MaterialDesign-WebUI
Labels: Hotlist-MD-Settings-SearchBox
Owner: dpa...@chromium.org
Status: Assigned (was: Untriaged)
We should keep the same behavior from Options:
1) When the user clears a search, "Advanced" should return to its previous state before the search began
2) The "Advanced" toggle should be hidden while searching

Since Options didn't let you search from dialogs, while MD Settings lets you search from sub-pages, we need to define new behavior. My preference is that when the user begins searching, we exit the sub-page and scroll to the top of Settings. We can forget the sub-page and scroll position.

Comment 8 by dpa...@chromium.org, Aug 10 2016

Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c72fd9a779aaf29554c3ba4e08ff58602eff54d8

commit c72fd9a779aaf29554c3ba4e08ff58602eff54d8
Author: dpapad <dpapad@chromium.org>
Date: Thu Aug 11 22:09:28 2016

MD Settings: Hide the advanced page toggle control during searching.

Also ensure that after the user clears the search results, the advanced page
returns to the expanded/collapsed state it had before searching.

BUG= 629696 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2236723002
Cr-Commit-Position: refs/heads/master@{#411429}

[modify] https://crrev.com/c72fd9a779aaf29554c3ba4e08ff58602eff54d8/chrome/browser/resources/settings/settings_main/settings_main.html
[modify] https://crrev.com/c72fd9a779aaf29554c3ba4e08ff58602eff54d8/chrome/browser/resources/settings/settings_main/settings_main.js
[modify] https://crrev.com/c72fd9a779aaf29554c3ba4e08ff58602eff54d8/chrome/test/data/webui/settings/settings_main_test.js

Status: Fixed (was: Started)

Sign in to add a comment