New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 629688 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Feature



Sign in to add a comment

Pass --buildbucket-id to cbuildbot

Project Member Reported by nxia@chromium.org, Jul 19 2016

Issue description

Retrieve buildbucket id in and pass it in cbuildbot with --buildbucket-id flag.
 

Comment 1 by nxia@chromium.org, Jul 19 2016

Labels: -Type-Bug Type-Feature
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 20 2016

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/7e34eda57456e7e73ceb48f116d5992e55aa914d

commit 7e34eda57456e7e73ceb48f116d5992e55aa914d
Author: Ningning Xia <nxia@chromium.org>
Date: Mon Jul 18 21:20:30 2016

Add column buildbucket_id in buildTable.

Alter buildTable to add buildbucket_id.

BUG= chromium:629688 
TEST=lib/cidb_integration_test

Change-Id: I0fa210e816a2c231d7cef591802769c5db7a9d69
Reviewed-on: https://chromium-review.googlesource.com/361500
Commit-Ready: Dan Shi <dshi@google.com>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/7e34eda57456e7e73ceb48f116d5992e55aa914d/cidb/schema.dump
[add] https://crrev.com/7e34eda57456e7e73ceb48f116d5992e55aa914d/cidb/migrations/00047_alter_build_table_add_buildbucket_id.sql
[modify] https://crrev.com/7e34eda57456e7e73ceb48f116d5992e55aa914d/cidb/developer.readme

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/9e01baf39d7a67a09f02e05d4144e176f394a1ee

commit 9e01baf39d7a67a09f02e05d4144e176f394a1ee
Author: Ningning Xia <nxia@chromium.org>
Date: Wed Jul 20 20:08:06 2016

Insert 'buildbucket_id' into cidb when it's provided.

Remove --buildbucket-bucket option as the bucket name can be returned
by sending buildbucket GET requests.
Insert 'buildbucket_id' into buildTable.
Add cidb_integration_test.

BUG= chromium:629688 
TEST=cidb_integration_test;run_tests
CQ-DEPEND=CL:361500

Change-Id: Ia3422d8e4793fa3238e33fb4fa6c513db4573708
Reviewed-on: https://chromium-review.googlesource.com/362003
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/9e01baf39d7a67a09f02e05d4144e176f394a1ee/scripts/cbuildbot.py
[modify] https://crrev.com/9e01baf39d7a67a09f02e05d4144e176f394a1ee/lib/fake_cidb.py
[modify] https://crrev.com/9e01baf39d7a67a09f02e05d4144e176f394a1ee/lib/cidb_integration_test.py
[modify] https://crrev.com/9e01baf39d7a67a09f02e05d4144e176f394a1ee/lib/cidb.py
[modify] https://crrev.com/9e01baf39d7a67a09f02e05d4144e176f394a1ee/cbuildbot/stages/report_stages.py

Comment 6 by nxia@chromium.org, Jul 26 2016

Status: Fixed (was: Untriaged)

Sign in to add a comment