New issue
Advanced search Search tips

Issue 629686 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

[Remoting Android] Define feedback animation size in DP

Project Member Reported by yuweih@chromium.org, Jul 19 2016

Issue description

Currently the size of the animation feedback is defined in pixel, which make is very small in a device with higher DPI. We should define the size in DP and convert it back to pixel when using it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2a0c8eb47e750fadd12b2bc885474bf0aac4855

commit b2a0c8eb47e750fadd12b2bc885474bf0aac4855
Author: yuweih <yuweih@chromium.org>
Date: Tue Jul 26 19:46:11 2016

[Remoting Android] Define feedback animation size in dp

Currently the radius of the feedback animation circle is defined in pixels,
which is DPI dependent and the size will vary on different devices. This CL
solves this problem by defining the size in dp (approximately matches the
current size on Nexus 6P) instead of pixel.

BUG= 629686 

Review-Url: https://codereview.chromium.org/2175353003
Cr-Commit-Position: refs/heads/master@{#407883}

[modify] https://crrev.com/b2a0c8eb47e750fadd12b2bc885474bf0aac4855/remoting/android/java/res/values/dimens.xml
[modify] https://crrev.com/b2a0c8eb47e750fadd12b2bc885474bf0aac4855/remoting/android/java/src/org/chromium/chromoting/AbstractDesktopView.java
[modify] https://crrev.com/b2a0c8eb47e750fadd12b2bc885474bf0aac4855/remoting/android/java/src/org/chromium/chromoting/DesktopView.java
[modify] https://crrev.com/b2a0c8eb47e750fadd12b2bc885474bf0aac4855/remoting/android/java/src/org/chromium/chromoting/FeedbackAnimator.java
[modify] https://crrev.com/b2a0c8eb47e750fadd12b2bc885474bf0aac4855/remoting/android/java/src/org/chromium/chromoting/GlDesktopView.java

Comment 2 by yuweih@chromium.org, Jul 26 2016

Status: Fixed (was: Assigned)

Comment 3 by yuweih@chromium.org, Jul 27 2016

Owner: ajnolley@chromium.org

Comment 4 by yuweih@chromium.org, Jul 27 2016

Owner: yuweih@chromium.org

Sign in to add a comment