New issue
Advanced search Search tips

Issue 629680 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

PPAPI Audio tests are flaky

Project Member Reported by m...@chromium.org, Jul 19 2016

Issue description

Detected while trying to land a change, and then having the tests succeed 90% of the time on a local desktop build. The following tests are flaky:

OutOfProcessPPAPITest.Audio (Mac only, but this was already disabled for Linux)
PPAPINaClNewlibTest.Audio (Mac and Linux)
PPAPINaClNewlibTest.AudioThreadCreator (Mac and Linux)
PPAPINaClPNaClTest.Audio (Mac and Linux)

The logs from the build bots indicate that the tests always run to completion, but then hang, and the watchdog kills the browser test.

When I ran locally, I saw green "PASS" for all tests running within the web page; however, after that point (about 10% of the time) the run would then halt and the watchdog would kill the browser and report the overall C++ browser test as failed.

 

Comment 1 by m...@chromium.org, Jul 19 2016

Also relevant, is the change that exposed the flakiness: https://codereview.chromium.org/2125143003/

What might be happening is that, when DCHECKs are on, the start-up of audio may be slightly delayed (due to the extra hop to the browser thread to validate the existence of a render frame). This seems to have exposed some kind of timing issue (or race condition) in the PPAPI audio tests. It did not manifest on the Win trybots.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/244a1a1a56409dd6083908bdfefa73e8a2b62116

commit 244a1a1a56409dd6083908bdfefa73e8a2b62116
Author: miu <miu@chromium.org>
Date: Wed Jul 20 00:13:23 2016

Disable flaky *PPAPI*.Audio browser tests.

The following tests were found susceptible to timing issues while trying
to land a change that slightly delays the creation of an audio output
stream:

OutOfProcessPPAPITest.Audio
PPAPINaClNewlibTest.Audio
PPAPINaClNewlibTest.AudioThreadCreator
PPAPINaClPNaClTest.Audio

BUG=629680
TBR=bbudge@chromium.org

Review-Url: https://codereview.chromium.org/2168463003
Cr-Commit-Position: refs/heads/master@{#406423}

[modify] https://crrev.com/244a1a1a56409dd6083908bdfefa73e8a2b62116/chrome/test/ppapi/ppapi_browsertest.cc

Sign in to add a comment