MD Settings Force rendering site-setting subpages throws assertion error. |
|||
Issue descriptionCurrently the search algorithm is explicitly preventing (see [1]) site-settings subpages from being forced-rendered since it throws an error. The error is thrown because the switch statement at [2] seems to be missing an entry for settings.ContentSettingsTypes.FULLSCREEN. It is unclear whether the same assertion can be thrown by navigating the UI. [1] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/search_settings.js?l=112-114 [2] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/site_settings/site_settings_behavior.js?l=210
,
Jul 20 2016
Latest finding is that I can trigger the same assertion by navigating to chrome://md-settings/siteSettings/fullscreen. The section that causes the error is [1]. Trying to figure out if that part has been left intentionally in the code, or should have been removed as part of https://codereview.chromium.org/1895113002. [1] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/privacy_page/privacy_page.html?l=178-185,
,
Jul 20 2016
,
Jul 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/474d850f3c46faa21c3de38fb068734dc52247b2 commit 474d850f3c46faa21c3de38fb068734dc52247b2 Author: dpapad <dpapad@chromium.org> Date: Wed Jul 20 19:40:24 2016 MD Settings: Remove remnants of obsolete Full Screen top-level category. Those bits should have been removed by https://codereview.chromium.org/1895113002. An assertion error was thrown by either of the following 1) Navigating to chrome://md-settings/siteSettings/fullscreen, or 2) Triggering a force-rendering of the subpage in question (via search). BUG= 629665 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2163123002 Cr-Commit-Position: refs/heads/master@{#406640} [modify] https://crrev.com/474d850f3c46faa21c3de38fb068734dc52247b2/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/474d850f3c46faa21c3de38fb068734dc52247b2/chrome/browser/resources/settings/route.js [modify] https://crrev.com/474d850f3c46faa21c3de38fb068734dc52247b2/chrome/browser/resources/settings/search_settings.js [modify] https://crrev.com/474d850f3c46faa21c3de38fb068734dc52247b2/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Jul 21 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dpa...@chromium.org
, Jul 19 2016