There's a large risk that the new material-design settings (chrome://md-settings) is going to slip for CrOS past m54. We need to support the quick unlock configuration UI in the existing options UI (chrome://settings). You can view the existing settings at chrome://md-settings/quickUnlock/authenticate. The quick unlock settings code are all of the quick_unlock_* files in [1]. There's also the pin_keyboard, [2], which is stored in a different directory since it's loaded inside of the lock screen as well. The settings UI is written in a framework called Polymer[3]. I believe that easy unlock is opening up a window in options already. I think this is a good place to start investigating [5]. The design doc for quick unlock is at go/cros-quick-unlock-design. The mocks are at [4]. There are some updated settings mocks at [6]. I don't expect that you'll need to make any changes to the private API, but just in case, the chrome.quickUnlockPrivate is implemented at [7] and [8]. 1: https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/people_page/ 2: https://cs.chromium.org/chromium/src/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html 3: polymer-project.org 4: go/cros-quick-unlock-ux 5: https://cs.chromium.org/chromium/src/chrome/browser/resources/options/easy_unlock_turn_off_overlay.html 6: https://folio.googleplex.com/tbuckley/chromeos/pin#%2FPIN%20v2.png%3Fz=half 7: https://cs.chromium.org/chromium/src/chrome/common/extensions/api/quick_unlock_private.idl 8: https://cs.chromium.org/chromium/src/chrome/browser/chromeos/extensions/quick_unlock_private/
In code review right now: https://codereview.chromium.org/2236213002
Seems odd that the dialog doesn't have a Close button other than that little X.
Yeah, this has been approved by UI review but we can probably add the button and resubmit the proposal if it's an issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36a1cc2dac63adf7cf223a158ce9826c3f2fa98b commit 36a1cc2dac63adf7cf223a158ce9826c3f2fa98b Author: xiaoyinh <xiaoyinh@chromium.org> Date: Fri Aug 19 22:35:56 2016 Add quick unlock Settings in options page BUG= 629662 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2236213002 Cr-Commit-Position: refs/heads/master@{#413268} [modify] https://crrev.com/36a1cc2dac63adf7cf223a158ce9826c3f2fa98b/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/36a1cc2dac63adf7cf223a158ce9826c3f2fa98b/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api.cc [modify] https://crrev.com/36a1cc2dac63adf7cf223a158ce9826c3f2fa98b/chrome/browser/resources/options/browser_options.js [add] https://crrev.com/36a1cc2dac63adf7cf223a158ce9826c3f2fa98b/chrome/browser/resources/options/chromeos/quick_unlock_configure_overlay.css [add] https://crrev.com/36a1cc2dac63adf7cf223a158ce9826c3f2fa98b/chrome/browser/resources/options/chromeos/quick_unlock_configure_overlay.html [add] https://crrev.com/36a1cc2dac63adf7cf223a158ce9826c3f2fa98b/chrome/browser/resources/options/chromeos/quick_unlock_configure_overlay.js [modify] https://crrev.com/36a1cc2dac63adf7cf223a158ce9826c3f2fa98b/chrome/browser/resources/options/compiled_resources.gyp [modify] https://crrev.com/36a1cc2dac63adf7cf223a158ce9826c3f2fa98b/chrome/browser/resources/options/options.html [modify] https://crrev.com/36a1cc2dac63adf7cf223a158ce9826c3f2fa98b/chrome/browser/resources/options/options.js [modify] https://crrev.com/36a1cc2dac63adf7cf223a158ce9826c3f2fa98b/chrome/browser/resources/options/options_bundle.js [add] https://crrev.com/36a1cc2dac63adf7cf223a158ce9826c3f2fa98b/chrome/browser/resources/options/options_polymer.html [modify] https://crrev.com/36a1cc2dac63adf7cf223a158ce9826c3f2fa98b/chrome/browser/resources/options/sync_section.html [modify] https://crrev.com/36a1cc2dac63adf7cf223a158ce9826c3f2fa98b/chrome/browser/resources/options_resources.grd [modify] https://crrev.com/36a1cc2dac63adf7cf223a158ce9826c3f2fa98b/chrome/browser/ui/webui/options/browser_options_handler.cc [modify] https://crrev.com/36a1cc2dac63adf7cf223a158ce9826c3f2fa98b/chrome/browser/ui/webui/options/options_browsertest_base.js [modify] https://crrev.com/36a1cc2dac63adf7cf223a158ce9826c3f2fa98b/chrome/browser/ui/webui/options/options_ui.cc [modify] https://crrev.com/36a1cc2dac63adf7cf223a158ce9826c3f2fa98b/chrome/common/extensions/api/_api_features.json
Issue 631180 has been merged into this issue.
Chrome:54.0.2840.25/ChromeOS:8743.26.0
Comment 1 by xiaoyinh@chromium.org
, Aug 11 2016