New issue
Advanced search Search tips

Issue 629658 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

[md] non-CTA buttons on yellow infobars are yellow, should be white

Project Member Reported by est...@chromium.org, Jul 19 2016

Issue description

see screenshot
 
yella.png
25.4 KB View Download

Comment 1 by est...@chromium.org, Jul 26 2016

Summary: [md] non-CTA buttons on yellow infobars are yellow, should be white (was: [md] non-CTA buttons on yellow infobars are yellow, should be grey)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/886005cc219d728016d264cc3c97ceffcf1bf5a2

commit 886005cc219d728016d264cc3c97ceffcf1bf5a2
Author: estade <estade@chromium.org>
Date: Tue Jul 26 19:57:59 2016

Make normal MD text buttons white.

BUG= 629658 

Review-Url: https://codereview.chromium.org/2180033002
Cr-Commit-Position: refs/heads/master@{#407887}

[modify] https://crrev.com/886005cc219d728016d264cc3c97ceffcf1bf5a2/ui/views/controls/button/md_text_button.cc

Comment 3 by est...@chromium.org, Jul 26 2016

Labels: -M-54 Merge-Request-53 M-53
one line change, so might as well merge.

Comment 4 by est...@chromium.org, Jul 26 2016

Labels: -M-53 -Merge-Request-53 M-54
actually, this broke the dl shelf :\
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/032442dec365358e954842c326bc7b1f37397805

commit 032442dec365358e954842c326bc7b1f37397805
Author: estade <estade@chromium.org>
Date: Wed Jul 27 00:24:39 2016

Make normal MD text buttons *on infobars* white.

This is a second attempt to fix the infobar button color. The first
attempt was 886005cc219 but that broke the download shelf (particularly
noticeable in incognito).

This fix is a bandaid in that we should rely on the native theme. However
that is difficult right now because we can't use ButtonBackgroundColor
until all buttons are MD.

Being able to set a custom bg color will also be useful for
crbug.com/617478

BUG= 629658 

Review-Url: https://codereview.chromium.org/2187473004
Cr-Commit-Position: refs/heads/master@{#407986}

[modify] https://crrev.com/032442dec365358e954842c326bc7b1f37397805/chrome/browser/ui/views/infobars/confirm_infobar.cc
[modify] https://crrev.com/032442dec365358e954842c326bc7b1f37397805/chrome/browser/ui/views/infobars/infobar_view.cc
[modify] https://crrev.com/032442dec365358e954842c326bc7b1f37397805/chrome/browser/ui/views/infobars/infobar_view.h
[modify] https://crrev.com/032442dec365358e954842c326bc7b1f37397805/ui/views/controls/button/md_text_button.cc
[modify] https://crrev.com/032442dec365358e954842c326bc7b1f37397805/ui/views/controls/button/md_text_button.h

Comment 6 by est...@chromium.org, Jul 27 2016

Status: Fixed (was: Assigned)

Sign in to add a comment