New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 629657 link

Starred by 4 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Master tracking bug for BioD

Project Member Reported by bleung@chromium.org, Jul 19 2016

Issue description

Biometric daemon. Userspace component of chrome os fingerprint stack.
 

Comment 1 by bleung@chromium.org, Jul 19 2016

Cc: bleung@google.com

Comment 2 by bleung@chromium.org, Jul 19 2016

Components: OS>Kernel
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/eclass-overlay/+/3c64012a0a7078e42156d9ad5b23be3e9f787e6d

commit 3c64012a0a7078e42156d9ad5b23be3e9f787e6d
Author: Zach Reizner <zachr@google.com>
Date: Tue Jul 19 21:37:36 2016

eclass-overlay/profiles: add biod system accounts

BUG=chromium:629657
TEST=None

Change-Id: If5686a7732787567c0b9f855f9044fc68ba3bc03
Reviewed-on: https://chromium-review.googlesource.com/361830
Commit-Ready: Dan Shi <dshi@google.com>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Benson Leung <bleung@chromium.org>

[add] https://crrev.com/3c64012a0a7078e42156d9ad5b23be3e9f787e6d/profiles/base/accounts/user/biod
[add] https://crrev.com/3c64012a0a7078e42156d9ad5b23be3e9f787e6d/profiles/base/accounts/group/biod

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/20d3fe4597baf904bdd6d39234ade6e8de602e8a

commit 20d3fe4597baf904bdd6d39234ade6e8de602e8a
Author: Zach Reizner <zachr@google.com>
Date: Wed Jul 27 00:08:19 2016

biod: initial ebuild

BUG=chromium:629657
TEST=emerge-samus biod
CQ-DEPEND=CL:363495

Change-Id: I9df6b55ef9ed67c52806705c18b0307009887dba
Reviewed-on: https://chromium-review.googlesource.com/363624
Commit-Ready: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[add] https://crrev.com/20d3fe4597baf904bdd6d39234ade6e8de602e8a/chromeos-base/biod/biod-9999.ebuild

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/d8b41e30356e72dfdbcce50330c5563b517c72dc

commit d8b41e30356e72dfdbcce50330c5563b517c72dc
Author: Zach Reizner <zachr@google.com>
Date: Wed Jul 27 00:18:27 2016

biod: initial skeleton daemon

It doesn't do anything other than run under a minijail and print to a
timestamped log. Mostly ripped off from powerd.

BUG=chromium:629657
TEST=emerge-samus biod

Change-Id: I6dfccbc032801865bfb7d4fed3cb880b6e76ff47
Reviewed-on: https://chromium-review.googlesource.com/363495
Commit-Ready: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Benson Leung <bleung@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[add] https://crrev.com/d8b41e30356e72dfdbcce50330c5563b517c72dc/biod/main.cc
[add] https://crrev.com/d8b41e30356e72dfdbcce50330c5563b517c72dc/biod/biod.gyp
[add] https://crrev.com/d8b41e30356e72dfdbcce50330c5563b517c72dc/biod/OWNERS
[add] https://crrev.com/d8b41e30356e72dfdbcce50330c5563b517c72dc/biod/init/biod.conf

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/7d2fb23f3215408938f5a2b62ea4c2652fdc801b

commit 7d2fb23f3215408938f5a2b62ea4c2652fdc801b
Author: Zach Reizner <zachr@google.com>
Date: Fri Aug 19 19:43:36 2016

biod: add Biometric abstract base class

The Biometric is the interface to each biometric device on the system,
and all the enrollment data. The biometric daemon will be the exclusive
consumer of these and will handle dbus interaction with the Biometric
instances.

BUG=chromium:629657
TEST=emerge-samus biod

Change-Id: Iede0bb8d6dbae49f01e14228859be9f25e730479
Reviewed-on: https://chromium-review.googlesource.com/373147
Commit-Ready: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[add] https://crrev.com/7d2fb23f3215408938f5a2b62ea4c2652fdc801b/biod/biometric.h

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/fc033ced744d8b572863da660752c8b088c94273

commit fc033ced744d8b572863da660752c8b088c94273
Author: Zach Reizner <zachr@google.com>
Date: Fri Aug 19 19:52:05 2016

biod: add FakeBiometric for testing until we get a real biometric

FakeBiometric implements Biometric in a very basic fashion. With the
fake_biometric_tool, CLI users can make FakeBiometric run callbacks.

This change also causes fake_biometric_tool to be installed.

BUG=chromium:629657
TEST=`fake_biometric_tool --scan=1 --scan_done` causes info log output

Change-Id: I798d89b18907e22000e5119e15d5cc791d45b382
Reviewed-on: https://chromium-review.googlesource.com/373148
Commit-Ready: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[add] https://crrev.com/fc033ced744d8b572863da660752c8b088c94273/biod/fake_biometric.cc
[add] https://crrev.com/fc033ced744d8b572863da660752c8b088c94273/biod/fake_biometric.h
[modify] https://crrev.com/fc033ced744d8b572863da660752c8b088c94273/biod/biod.gyp
[add] https://crrev.com/fc033ced744d8b572863da660752c8b088c94273/biod/fake_biometric_common.h
[add] https://crrev.com/fc033ced744d8b572863da660752c8b088c94273/biod/tools/fake_biometric_tool.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1beea69ce2ad20ae128c975ea72f8a26fe1498aa

commit 1beea69ce2ad20ae128c975ea72f8a26fe1498aa
Author: Mengqi Guo <mqg@chromium.org>
Date: Fri Sep 09 00:56:28 2016

biod: edit ebuild to add group and user id to passwd and group

BUG=chromium:629657
TEST=NONE

Change-Id: If12a70e6e01c79c58aff03c4a39d1ddebc7285ca
Reviewed-on: https://chromium-review.googlesource.com/383076
Commit-Ready: Mengqi Guo <mqg@chromium.org>
Tested-by: Mengqi Guo <mqg@chromium.org>
Reviewed-by: Mengqi Guo <mqg@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/1beea69ce2ad20ae128c975ea72f8a26fe1498aa/chromeos-base/biod/biod-9999.ebuild

Project Member

Comment 9 by bugdroid1@chromium.org, Sep 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/49355b8c06be4de08f3995681d7f41b48ff022c5

commit 49355b8c06be4de08f3995681d7f41b48ff022c5
Author: Zach Reizner <zachr@google.com>
Date: Fri Aug 19 19:58:00 2016

biod: install fake_biometric_tool

BUG=chromium:629657
TEST=fake_biometric_tool is installed with biod
CQ-DEPEND=CL:373148

Change-Id: I6bcafb3a8c2d901eae21aaa443bfa6ec1499882c
Reviewed-on: https://chromium-review.googlesource.com/373049
Commit-Ready: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/49355b8c06be4de08f3995681d7f41b48ff022c5/chromeos-base/biod/biod-9999.ebuild

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ea8824f45adea851050eb2e51d4b8c77d20d5848

commit ea8824f45adea851050eb2e51d4b8c77d20d5848
Author: Zach Reizner <zachr@google.com>
Date: Fri Aug 19 19:59:58 2016

biod: install DBUS config file

BUG=chromium:629657
TEST=biod can start succesfully
CQ-DEPEND=CL:373149

Change-Id: I149a29787c65117dfd399b6c8bac08f3e7bb7a25
Reviewed-on: https://chromium-review.googlesource.com/373050
Commit-Ready: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/ea8824f45adea851050eb2e51d4b8c77d20d5848/chromeos-base/biod/biod-9999.ebuild

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2e93240973eb9504dcade20bc35bd2da9b2da288

commit 2e93240973eb9504dcade20bc35bd2da9b2da288
Author: Zach Reizner <zachr@google.com>
Date: Fri Aug 19 20:04:06 2016

biod: create BiometricsDaemon class to handle DBUS interface

This change has the DBUS integration for biod and the DBUS configuration
which must be installed in order for the daemon to acquire its service
name.

BUG=chromium:629657
TEST=reply from org.freedesktop.DBus.ListNames has BiometricsDaemon

Change-Id: I7351dc28551fe96ec976cfc3e129cd6c691dfc25
Reviewed-on: https://chromium-review.googlesource.com/373149
Commit-Ready: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[add] https://crrev.com/2e93240973eb9504dcade20bc35bd2da9b2da288/biod/biometrics_daemon.cc
[modify] https://crrev.com/2e93240973eb9504dcade20bc35bd2da9b2da288/biod/main.cc
[add] https://crrev.com/2e93240973eb9504dcade20bc35bd2da9b2da288/biod/dbus/org.chromium.BiometricsDaemon.conf
[modify] https://crrev.com/2e93240973eb9504dcade20bc35bd2da9b2da288/biod/biod.gyp
[add] https://crrev.com/2e93240973eb9504dcade20bc35bd2da9b2da288/biod/biometrics_daemon.h

Project Member

Comment 12 by bugdroid1@chromium.org, Sep 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/80919c366e579e0c119f51718ff26d15e3113815

commit 80919c366e579e0c119f51718ff26d15e3113815
Author: Mengqi Guo <mqg@chromium.org>
Date: Thu Sep 15 19:22:08 2016

biod: clarify key concepts in comment in biometric.h

This change only changed comments in biometric.h and clarified
the key concepts: biometric has multiple enrollments,
enroll and authentication are session objects.

BUG=chromium:629657
TEST=NONE

Change-Id: I41a47ba730b52eaa359561bb9e403fd01e277b00
Reviewed-on: https://chromium-review.googlesource.com/386138
Commit-Ready: Mengqi Guo <mqg@chromium.org>
Tested-by: Mengqi Guo <mqg@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[modify] https://crrev.com/80919c366e579e0c119f51718ff26d15e3113815/biod/biometric.h

Project Member

Comment 13 by bugdroid1@chromium.org, Sep 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/62d1bbdbf45bae758c6c7f599bb7c660abb7fdea

commit 62d1bbdbf45bae758c6c7f599bb7c660abb7fdea
Author: Dmitry Torokhov <dtor@chromium.org>
Date: Thu Aug 25 00:40:17 2016

biod: define biometric algorithm API

Add an API for biometric algorithm library implementations.

BUG=chromium:629657
TEST=None

Change-Id: I7e83c4b7a3da6c3b1917bfbe746f519ee9d28562
Reviewed-on: https://chromium-review.googlesource.com/375361
Commit-Ready: Dmitry Torokhov <dtor@chromium.org>
Tested-by: Dmitry Torokhov <dtor@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[add] https://crrev.com/62d1bbdbf45bae758c6c7f599bb7c660abb7fdea/biod/bio_algorithm.h

Project Member

Comment 14 by bugdroid1@chromium.org, Oct 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/7350f85b31eee33e6eda8dcc1a8c9802b57fd021

commit 7350f85b31eee33e6eda8dcc1a8c9802b57fd021
Author: Mengqi Guo <mqg@chromium.org>
Date: Fri Sep 23 22:53:14 2016

biod: add mutiple enrollments, with user id and label

When user starts to enroll, initialize the internal enrollment with
user id and label. When user finishes enroll, insert this new
internal enrollment at the end of the list of enrollments.
Invalidate enroll session upon scan done. When refreshing enrollments,
first unregister them and then register again.

BUG=chromium:629657
TEST=NONE

Change-Id: Ic3ef4d333fff7848dede2a51104bcd7ce9bfcd24
Reviewed-on: https://chromium-review.googlesource.com/388902
Commit-Ready: Mengqi Guo <mqg@chromium.org>
Tested-by: Mengqi Guo <mqg@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[modify] https://crrev.com/7350f85b31eee33e6eda8dcc1a8c9802b57fd021/biod/biometrics_daemon.cc
[modify] https://crrev.com/7350f85b31eee33e6eda8dcc1a8c9802b57fd021/biod/fake_biometric.cc
[modify] https://crrev.com/7350f85b31eee33e6eda8dcc1a8c9802b57fd021/biod/fake_biometric.h
[modify] https://crrev.com/7350f85b31eee33e6eda8dcc1a8c9802b57fd021/biod/biometrics_daemon.h

Project Member

Comment 15 by bugdroid1@chromium.org, Oct 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/7350f85b31eee33e6eda8dcc1a8c9802b57fd021

commit 7350f85b31eee33e6eda8dcc1a8c9802b57fd021
Author: Mengqi Guo <mqg@chromium.org>
Date: Fri Sep 23 22:53:14 2016

biod: add mutiple enrollments, with user id and label

When user starts to enroll, initialize the internal enrollment with
user id and label. When user finishes enroll, insert this new
internal enrollment at the end of the list of enrollments.
Invalidate enroll session upon scan done. When refreshing enrollments,
first unregister them and then register again.

BUG=chromium:629657
TEST=NONE

Change-Id: Ic3ef4d333fff7848dede2a51104bcd7ce9bfcd24
Reviewed-on: https://chromium-review.googlesource.com/388902
Commit-Ready: Mengqi Guo <mqg@chromium.org>
Tested-by: Mengqi Guo <mqg@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[modify] https://crrev.com/7350f85b31eee33e6eda8dcc1a8c9802b57fd021/biod/biometrics_daemon.cc
[modify] https://crrev.com/7350f85b31eee33e6eda8dcc1a8c9802b57fd021/biod/fake_biometric.cc
[modify] https://crrev.com/7350f85b31eee33e6eda8dcc1a8c9802b57fd021/biod/fake_biometric.h
[modify] https://crrev.com/7350f85b31eee33e6eda8dcc1a8c9802b57fd021/biod/biometrics_daemon.h

Project Member

Comment 16 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/6dc5dc9cfe08aefcafe78d41001e31af51e03007

commit 6dc5dc9cfe08aefcafe78d41001e31af51e03007
Author: Zach Reizner <zachr@google.com>
Date: Wed Oct 19 00:23:44 2016

biod: implement dynamic loader for biometric algorithm API

The API will be implemented by multiple shared libraries on the system,
and so this module will load them.

BUG=chromium:629657
TEST=biod compiles

Change-Id: Ia3887c712d1360e9519893f87019fc94886ce2bc
Reviewed-on: https://chromium-review.googlesource.com/378118
Commit-Ready: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[add] https://crrev.com/6dc5dc9cfe08aefcafe78d41001e31af51e03007/biod/bio_library.cc
[add] https://crrev.com/6dc5dc9cfe08aefcafe78d41001e31af51e03007/biod/bio_library.h
[modify] https://crrev.com/6dc5dc9cfe08aefcafe78d41001e31af51e03007/biod/biod.gyp

Project Member

Comment 17 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/998e782331dcc41356b88dd34503cc5e912fd9eb

commit 998e782331dcc41356b88dd34503cc5e912fd9eb
Author: Zach Reizner <zachr@google.com>
Date: Fri Oct 14 00:54:36 2016

biod: add fpc biometric support

To support FPC, their sensor library header is included as well.

Also adds the AtExitManager to the main file because base::Thread needs
that.

TEST=ran enrollments and authentication on gru via dbus interface
BUG=chromium:629657

Change-Id: I74569a588db678d241b6e77b1f4ae5ff9b41c738
Reviewed-on: https://chromium-review.googlesource.com/398463
Commit-Ready: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/998e782331dcc41356b88dd34503cc5e912fd9eb/biod/main.cc
[add] https://crrev.com/998e782331dcc41356b88dd34503cc5e912fd9eb/biod/fpc_biometric.cc
[modify] https://crrev.com/998e782331dcc41356b88dd34503cc5e912fd9eb/biod/biometrics_daemon.cc
[add] https://crrev.com/998e782331dcc41356b88dd34503cc5e912fd9eb/biod/fpc/fp_sensor.h
[add] https://crrev.com/998e782331dcc41356b88dd34503cc5e912fd9eb/biod/fpc_biometric.h
[modify] https://crrev.com/998e782331dcc41356b88dd34503cc5e912fd9eb/biod/biod.gyp

Project Member

Comment 18 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/e1622e7297d3a0ff998ef9bd794f4a67fc559ab2

commit e1622e7297d3a0ff998ef9bd794f4a67fc559ab2
Author: Zach Reizner <zachr@google.com>
Date: Thu Oct 27 18:32:01 2016

biod: add biod client command line tool

The biod_client_tool is used for testing the D-Bus interface of biod, as
well as any biometrics exposed by biod. It implements all the basic
operations a biod client might do, including enrollment, authentication,
and removal of enrollments.

TEST=biod_client_tool
BUG=chromium:629657

Change-Id: I062a55ebe4fd4473098ab9ba7f3dec206d84f0d8
Reviewed-on: https://chromium-review.googlesource.com/404469
Commit-Ready: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[add] https://crrev.com/e1622e7297d3a0ff998ef9bd794f4a67fc559ab2/biod/tools/biod_client_tool.cc
[modify] https://crrev.com/e1622e7297d3a0ff998ef9bd794f4a67fc559ab2/biod/biod.gyp

Project Member

Comment 19 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/b914b1ffa85d49ac713817ee2c444eacb1c55507

commit b914b1ffa85d49ac713817ee2c444eacb1c55507
Author: Mengqi Guo <mqg@chromium.org>
Date: Wed Nov 16 04:07:15 2016

biod: add libuuid to biod ebuild

Add libuuid to biod ebuild so we can generate uuid as enrollment
id for biod enrollments.

Test=None
Bug=chromium:629657

Change-Id: I0e528feddea61dcaa144f04564aeb5c43bfd4b45
Reviewed-on: https://chromium-review.googlesource.com/411337
Commit-Ready: Mengqi Guo <mqg@chromium.org>
Tested-by: Mengqi Guo <mqg@chromium.org>
Reviewed-by: Dmitry Torokhov <dtor@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/b914b1ffa85d49ac713817ee2c444eacb1c55507/chromeos-base/biod/biod-9999.ebuild

Project Member

Comment 20 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/eclass-overlay/+/d1f377231a210b1774d38afc4bc628d50bf01152

commit d1f377231a210b1774d38afc4bc628d50bf01152
Author: Mengqi Guo <mqg@chromium.org>
Date: Wed Nov 16 03:27:54 2016

biod: add biod to daemon-store group

Add biod to daemon-store group so that it can write to /home/root/
<hash of user id>/biod.

TEST=autotest security_AccountsBaseline
BUG=chromium:629657

CQ-DEPEND=CL:413024

Change-Id: I43d1a27eca786afa4b7d40858053a81ba3278caa
Reviewed-on: https://chromium-review.googlesource.com/411914
Commit-Ready: Mengqi Guo <mqg@chromium.org>
Tested-by: Mengqi Guo <mqg@chromium.org>
Reviewed-by: Dmitry Torokhov <dtor@chromium.org>

[modify] https://crrev.com/d1f377231a210b1774d38afc4bc628d50bf01152/profiles/base/accounts/group/daemon-store

Project Member

Comment 21 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/705fd4dcf00b0fe54b49de2c4b9459f8c99ee1de

commit 705fd4dcf00b0fe54b49de2c4b9459f8c99ee1de
Author: Mengqi Guo <mqg@chromium.org>
Date: Sat Nov 19 00:16:41 2016

biod: add biod to autotest security_AccountsBaseline

Add biod group to group baseline and biod user to passwd baseline.
Also add biod user to daemon-store group in group baseline.

BUG=chromium:629657
TEST=autotest

CQ-DEPEND=CL:411914

Change-Id: Ia1cdba1bf04578f98bd56788f6ee51626b6c6893
Reviewed-on: https://chromium-review.googlesource.com/413024
Commit-Ready: Mengqi Guo <mqg@chromium.org>
Tested-by: Mengqi Guo <mqg@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/705fd4dcf00b0fe54b49de2c4b9459f8c99ee1de/client/site_tests/security_AccountsBaseline/baseline.group
[modify] https://crrev.com/705fd4dcf00b0fe54b49de2c4b9459f8c99ee1de/client/site_tests/security_AccountsBaseline/baseline.passwd

Project Member

Comment 22 by bugdroid1@chromium.org, Dec 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b21e123defee9d99cdc31a1f888a9d4f5cc5bf38

commit b21e123defee9d99cdc31a1f888a9d4f5cc5bf38
Author: Mengqi Guo <mqg@chromium.org>
Date: Mon Nov 28 20:44:58 2016

login: give biod access to session_manager RetrieveActiveSessions

Give the biod user permission to call session_manager's
RetrieveActiveSessions D-Bus method. The biod process needs
to do this to get a list of logged-in users when it sees a
SessionStateChanged signal or when biod daemon starts.

BUG=chromium:629657
TEST=biod_client_tool on dut

Change-Id: Ie460c06a7cbe96db1b187a4f1ed7aff637c3ffcf
Reviewed-on: https://chromium-review.googlesource.com/414236
Commit-Ready: Mengqi Guo <mqg@chromium.org>
Tested-by: Mengqi Guo <mqg@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/b21e123defee9d99cdc31a1f888a9d4f5cc5bf38/login_manager/SessionManager.conf

Project Member

Comment 23 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/99644cc47903584b242b115670dd8faa81d54c53

commit 99644cc47903584b242b115670dd8faa81d54c53
Author: Mengqi Guo <mqg@chromium.org>
Date: Fri Nov 04 00:23:14 2016

biod: GetEnrollments() should use enrollments_

GetEnrollments() in biometric wrapper should directly use
enrollments_ instead of calling GetEnrollments() on biometric.
Saves one function call.

BUG=chromium:629657
TEST=NONE

Change-Id: I8f156af6e1d1c885a6fe0a83bef4168dc427a2fe
Reviewed-on: https://chromium-review.googlesource.com/407638
Commit-Ready: Mengqi Guo <mqg@chromium.org>
Tested-by: Mengqi Guo <mqg@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[modify] https://crrev.com/99644cc47903584b242b115670dd8faa81d54c53/biod/biometrics_daemon.cc

Project Member

Comment 24 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/590b3129b7e0c5ae1195853efd71fb5d05521005

commit 590b3129b7e0c5ae1195853efd71fb5d05521005
Author: Zach Reizner <zachr@google.com>
Date: Thu Jan 19 17:52:09 2017

target-chromium-os: add biod USE flag

Boards that want to include the biometrics daemon should specify the
biod USE flag instead of adding the package as an RDEPEND directly. This
change adds the biod package conditioned on the biod USE flag.

BUG=chromium:629657
TEST=builds

Change-Id: I74908c1ecc9fbec8bd8b06c861d2223bcc443e79
Reviewed-on: https://chromium-review.googlesource.com/430257
Commit-Ready: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[rename] https://crrev.com/590b3129b7e0c5ae1195853efd71fb5d05521005/virtual/target-chromium-os/target-chromium-os-1-r62.ebuild
[modify] https://crrev.com/590b3129b7e0c5ae1195853efd71fb5d05521005/virtual/target-chromium-os/target-chromium-os-1.ebuild

Project Member

Comment 25 by bugdroid1@chromium.org, Feb 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/d4742ec71b429b104a7e56d0c7a1f45bb2d1dd85

commit d4742ec71b429b104a7e56d0c7a1f45bb2d1dd85
Author: Mengqi Guo <mqg@chromium.org>
Date: Sat Feb 11 08:35:11 2017

biod: add enrollment storage in user stateful

Storage support for enrollments. Can write, read and delete. Use
uuid as the unique identifier for enrollment storage and replace
- with _ for dbus object path compatibility. Also added scoped
umask to control file permissions. CL:425482 is merged into this
CL.

BUG=chromium:629657
TEST=biod_client_tool on dut

Change-Id: I37741e7112be4e8d299167358663f71274521efc
Reviewed-on: https://chromium-review.googlesource.com/396941
Commit-Ready: Mengqi Guo <mqg@chromium.org>
Tested-by: Mengqi Guo <mqg@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[modify] https://crrev.com/d4742ec71b429b104a7e56d0c7a1f45bb2d1dd85/biod/biometric.h
[add] https://crrev.com/d4742ec71b429b104a7e56d0c7a1f45bb2d1dd85/biod/scoped_umask.h
[modify] https://crrev.com/d4742ec71b429b104a7e56d0c7a1f45bb2d1dd85/biod/fake_biometric.cc
[modify] https://crrev.com/d4742ec71b429b104a7e56d0c7a1f45bb2d1dd85/biod/fake_biometric.h
[add] https://crrev.com/d4742ec71b429b104a7e56d0c7a1f45bb2d1dd85/biod/biod_storage.cc
[add] https://crrev.com/d4742ec71b429b104a7e56d0c7a1f45bb2d1dd85/biod/biod_storage.h
[modify] https://crrev.com/d4742ec71b429b104a7e56d0c7a1f45bb2d1dd85/biod/biometrics_daemon.cc
[add] https://crrev.com/d4742ec71b429b104a7e56d0c7a1f45bb2d1dd85/biod/scoped_umask.cc
[modify] https://crrev.com/d4742ec71b429b104a7e56d0c7a1f45bb2d1dd85/biod/biod.gyp

Project Member

Comment 26 by bugdroid1@chromium.org, Feb 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/055446b78faab19129e7cb3bde200a4acc22d1ef

commit 055446b78faab19129e7cb3bde200a4acc22d1ef
Author: Mengqi Guo <mqg@chromium.org>
Date: Sat Feb 11 08:35:12 2017

biod: Read/Remove enrollments upon user log in/log out

Add dbus support to communicate with session manager to
1)retrieve sanitized usernames. When biod starts up, it will
retrieve the usernames of all currently active sessions and pick
out new usernames to read enrollments from each user's stateful
partition. 2)listen to session state change signal. When a user
logs in, biod reads the enrollment for this user. When all users
log out, biod remove all enrollments from memory but keep them
stored on disk.

BUG=chromium:629657
TEST=biod_client_tool on dut

Change-Id: I933c1d50a8e6d9f0caa9a17de73af3085bb6a6f8
Reviewed-on: https://chromium-review.googlesource.com/414207
Commit-Ready: Mengqi Guo <mqg@chromium.org>
Tested-by: Mengqi Guo <mqg@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[modify] https://crrev.com/055446b78faab19129e7cb3bde200a4acc22d1ef/biod/biometric.h
[modify] https://crrev.com/055446b78faab19129e7cb3bde200a4acc22d1ef/biod/fake_biometric.cc
[modify] https://crrev.com/055446b78faab19129e7cb3bde200a4acc22d1ef/biod/fake_biometric.h
[modify] https://crrev.com/055446b78faab19129e7cb3bde200a4acc22d1ef/biod/biod_storage.cc
[modify] https://crrev.com/055446b78faab19129e7cb3bde200a4acc22d1ef/biod/biod_storage.h
[modify] https://crrev.com/055446b78faab19129e7cb3bde200a4acc22d1ef/biod/biometrics_daemon.cc
[modify] https://crrev.com/055446b78faab19129e7cb3bde200a4acc22d1ef/biod/biometrics_daemon.h

Project Member

Comment 27 by bugdroid1@chromium.org, Feb 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/093522b7a2ccf3b0b9fba4425b6dd8a18d7fd631

commit 093522b7a2ccf3b0b9fba4425b6dd8a18d7fd631
Author: Mengqi Guo <mqg@chromium.org>
Date: Sat Feb 11 08:35:12 2017

biod: add storage to fpc biometric

Make fpc biometric storage work similarly to fake biometric.
Support enroll, authenticate, destroy all, set label and unenroll
single enrollments.

BUG=chromium:629657
TEST=biod_client_tool on dut

Change-Id: I0711c009e98f2e3b9709a023331119eeee31a63c
Reviewed-on: https://chromium-review.googlesource.com/425483
Commit-Ready: Mengqi Guo <mqg@chromium.org>
Tested-by: Mengqi Guo <mqg@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[modify] https://crrev.com/093522b7a2ccf3b0b9fba4425b6dd8a18d7fd631/biod/fpc_biometric.cc
[modify] https://crrev.com/093522b7a2ccf3b0b9fba4425b6dd8a18d7fd631/biod/fpc_biometric.h

Project Member

Comment 28 by bugdroid1@chromium.org, Feb 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b0115c24374681fae5997ed17e5f8bc07b5e4eac

commit b0115c24374681fae5997ed17e5f8bc07b5e4eac
Author: Mengqi Guo <mqg@chromium.org>
Date: Sat Feb 11 08:35:12 2017

biod: add README to biod

README.md will talk about how biod interacts with storage, hardware,
Chrome and login manager, etc.

BUG=chromium:629657
TEST=None

Change-Id: Ibba53e5dbce2d1d32323bc45ff573e5c7720d450
Reviewed-on: https://chromium-review.googlesource.com/430093
Commit-Ready: Mengqi Guo <mqg@chromium.org>
Tested-by: Mengqi Guo <mqg@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[add] https://crrev.com/b0115c24374681fae5997ed17e5f8bc07b5e4eac/biod/README.md

Status: Archived (was: Unconfirmed)
Project Member

Comment 30 by bugdroid1@chromium.org, Mar 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/c4a6f83c587658c42e353e3be5b7cad0ff4b0086

commit c4a6f83c587658c42e353e3be5b7cad0ff4b0086
Author: Zach Reizner <zachr@google.com>
Date: Sat Mar 11 03:52:31 2017

biod: update D-Bus API to send auth labels and get user enrollments

The D-Bus API is changed in two client facing ways:
1) GetEnrollments is now GetEnrollmentsForUser and requires that the
caller limits their query to a specific user ID
2) The Attempt signal replaces the list of user IDs with a map of user IDs
(keys) to lists of user assigned labels (values) for the purposes of
display of those labels back to the user.

The corresponding APIs interal to biod are updated along with the client
tool and fake biometric tool to facilitate testing.

TEST=biod_client_tool and fake_biometric_tool
BUG=chromium:629657

Change-Id: Id6818b90f4302b818f50040d3cdd4e3a6fe9f36f
Reviewed-on: https://chromium-review.googlesource.com/440430
Commit-Ready: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Mengqi Guo <mqg@chromium.org>

[modify] https://crrev.com/c4a6f83c587658c42e353e3be5b7cad0ff4b0086/biod/biometric.h
[modify] https://crrev.com/c4a6f83c587658c42e353e3be5b7cad0ff4b0086/biod/tools/fake_biometric_tool.cc
[modify] https://crrev.com/c4a6f83c587658c42e353e3be5b7cad0ff4b0086/biod/fake_biometric.cc
[modify] https://crrev.com/c4a6f83c587658c42e353e3be5b7cad0ff4b0086/biod/biometrics_daemon.cc
[modify] https://crrev.com/c4a6f83c587658c42e353e3be5b7cad0ff4b0086/biod/fpc_biometric.cc
[modify] https://crrev.com/c4a6f83c587658c42e353e3be5b7cad0ff4b0086/biod/fpc_biometric.h
[modify] https://crrev.com/c4a6f83c587658c42e353e3be5b7cad0ff4b0086/biod/tools/biod_client_tool.cc
[modify] https://crrev.com/c4a6f83c587658c42e353e3be5b7cad0ff4b0086/biod/biometrics_daemon.h

Comment 31 by ketakid@google.com, Mar 18 2017

Status: Available (was: Archived)
Activating. Please assign to the right owner and the appropriate priority.
Project Member

Comment 32 by bugdroid1@chromium.org, Mar 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/4a76c5e528eb60f4972fd417f4a3411504755a36

commit 4a76c5e528eb60f4972fd417f4a3411504755a36
Author: Mengqi Guo <mqg@chromium.org>
Date: Fri Mar 24 13:49:55 2017

biod: add system_api to biod ebuild

Adding system_api to biod ebuild so biod can use service constants
from system_api. Also removing sys-apps/util-linux from biod
ebuild because we no longer use libuuid to generate record id. Now
we use guid.

BUG=chromium:629657
TEST=biod_client_tool and fake_biometric_tool

Change-Id: Ief6fc0118c7acd6105c5f0f40908e28a70423986
Reviewed-on: https://chromium-review.googlesource.com/459218
Commit-Ready: Mengqi Guo <mqg@chromium.org>
Tested-by: Mengqi Guo <mqg@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/4a76c5e528eb60f4972fd417f4a3411504755a36/chromeos-base/biod/biod-9999.ebuild

Project Member

Comment 33 by bugdroid1@chromium.org, Mar 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/297cf76300b99e1383a21a00fcc0df206a338ea9

commit 297cf76300b99e1383a21a00fcc0df206a338ea9
Author: Mengqi Guo <mqg@chromium.org>
Date: Fri Mar 31 00:35:44 2017

biod: add unit tests to biod ebuild

Changing ebuild so we can add unit test to biod.

BUG=chromium:629657
TEST=unittest

Change-Id: I1d73ce50559b85cb82ff411820e12cfdd80cd187
Reviewed-on: https://chromium-review.googlesource.com/461394
Commit-Ready: Mengqi Guo <mqg@chromium.org>
Tested-by: Mengqi Guo <mqg@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/297cf76300b99e1383a21a00fcc0df206a338ea9/chromeos-base/biod/biod-9999.ebuild

Project Member

Comment 34 by bugdroid1@chromium.org, Mar 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/9b55a27f508d97cbb58e5da2dfb5987780d4882f

commit 9b55a27f508d97cbb58e5da2dfb5987780d4882f
Author: Mengqi Guo <mqg@chromium.org>
Date: Fri Mar 31 02:33:11 2017

biod: refactoring code and change the naming of biod terms

For clarity, we are changing the names of terms in biod as below:
Biometric -> BiometricsManager
Enrollment -> Record
Enroll -> EnrollSession
Authentication -> AuthSession
Scan/Scanned->EnrollScanDone
Attempt->AuthScanDone
Failure->SessionFailed

BUG=chromium:629657
TEST=biod_client_tool and fake_biometric_tool

Change-Id: Ibde81087355121a94fd8a841e5d32b5a58c39264
Reviewed-on: https://chromium-review.googlesource.com/456524
Commit-Ready: Mengqi Guo <mqg@chromium.org>
Tested-by: Mengqi Guo <mqg@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[add] https://crrev.com/9b55a27f508d97cbb58e5da2dfb5987780d4882f/biod/fpc_biometrics_manager.cc
[delete] https://crrev.com/12e9388a02e4d57f730cc0239625930f09429587/biod/biometric.h
[modify] https://crrev.com/9b55a27f508d97cbb58e5da2dfb5987780d4882f/biod/tools/biod_client_tool.cc
[add] https://crrev.com/9b55a27f508d97cbb58e5da2dfb5987780d4882f/biod/fake_biometrics_manager.cc
[modify] https://crrev.com/9b55a27f508d97cbb58e5da2dfb5987780d4882f/biod/tools/fake_biometric_tool.cc
[add] https://crrev.com/9b55a27f508d97cbb58e5da2dfb5987780d4882f/biod/fake_biometrics_manager.h
[delete] https://crrev.com/12e9388a02e4d57f730cc0239625930f09429587/biod/fake_biometric.cc
[delete] https://crrev.com/12e9388a02e4d57f730cc0239625930f09429587/biod/fake_biometric.h
[modify] https://crrev.com/9b55a27f508d97cbb58e5da2dfb5987780d4882f/biod/biod_storage.cc
[modify] https://crrev.com/9b55a27f508d97cbb58e5da2dfb5987780d4882f/biod/biod_storage.h
[delete] https://crrev.com/12e9388a02e4d57f730cc0239625930f09429587/biod/fpc_biometric.cc
[add] https://crrev.com/9b55a27f508d97cbb58e5da2dfb5987780d4882f/biod/fpc_biometrics_manager.h
[modify] https://crrev.com/9b55a27f508d97cbb58e5da2dfb5987780d4882f/biod/biometrics_daemon.cc
[modify] https://crrev.com/9b55a27f508d97cbb58e5da2dfb5987780d4882f/biod/README.md
[add] https://crrev.com/9b55a27f508d97cbb58e5da2dfb5987780d4882f/biod/biometrics_manager.h
[modify] https://crrev.com/9b55a27f508d97cbb58e5da2dfb5987780d4882f/biod/biod.gyp
[delete] https://crrev.com/12e9388a02e4d57f730cc0239625930f09429587/biod/fpc_biometric.h
[modify] https://crrev.com/9b55a27f508d97cbb58e5da2dfb5987780d4882f/biod/biometrics_daemon.h
[rename] https://crrev.com/9b55a27f508d97cbb58e5da2dfb5987780d4882f/biod/fake_biometrics_manager_common.h

Project Member

Comment 35 by bugdroid1@chromium.org, Mar 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1319e83ff41c24fa4fb28818eb26faf4eaec1bf8

commit 1319e83ff41c24fa4fb28818eb26faf4eaec1bf8
Author: Todd Broch <tbroch@chromium.org>
Date: Fri Mar 31 19:59:17 2017

Revert "biod: add unit tests to biod ebuild"

This reverts commit 297cf76300b99e1383a21a00fcc0df206a338ea9.

Reason for revert: can't successfully build subsequent biod uprev with unittests here:

https://chromium-review.googlesource.com/c/463826/

Original change's description:
> biod: add unit tests to biod ebuild
>
> Changing ebuild so we can add unit test to biod.
>
> BUG=chromium:629657
> TEST=unittest
>
> Change-Id: I1d73ce50559b85cb82ff411820e12cfdd80cd187
> Reviewed-on: https://chromium-review.googlesource.com/461394
> Commit-Ready: Mengqi Guo <mqg@chromium.org>
> Tested-by: Mengqi Guo <mqg@chromium.org>
> Reviewed-by: Mike Frysinger <vapier@chromium.org>
>

TBR=derat@chromium.org,tbroch@chromium.org,bleung@chromium.org,vapier@chromium.org,chirantan@chromium.org,dtor@chromium.org,zachr@chromium.org,mqg@chromium.org,benchan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:629657

Change-Id: I59aa0305a965154fdfdabfa4a36e3c4651333385
Reviewed-on: https://chromium-review.googlesource.com/465066
Commit-Ready: Todd Broch <tbroch@chromium.org>
Tested-by: Todd Broch <tbroch@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/1319e83ff41c24fa4fb28818eb26faf4eaec1bf8/chromeos-base/biod/biod-9999.ebuild

Project Member

Comment 36 by bugdroid1@chromium.org, Apr 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/729a2991cd923f662dc95d750cf65f5d936e4c12

commit 729a2991cd923f662dc95d750cf65f5d936e4c12
Author: Mengqi Guo <mqg@chromium.org>
Date: Tue Apr 04 21:08:15 2017

biod: authenticate returns record IDs instead of labels

Since we use record IDs as the unique identifier for records
within biod, we return record IDs during AuthSession to indicate
a match between records and new biometric data. Meanwhile,
between biod and Chrome, we use record object path as the unique
identifier, so on authentication, biod sends record object path to
Chrome UI to indicate which records were matched.

BUG=chromium:629657
TEST=biod_client_tool and fake_biometric_tool

Change-Id: Iebb6de7b354e438eaebc083d04d5ffc4b8c2cd42
Reviewed-on: https://chromium-review.googlesource.com/456845
Commit-Ready: Mengqi Guo <mqg@chromium.org>
Tested-by: Mengqi Guo <mqg@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[modify] https://crrev.com/729a2991cd923f662dc95d750cf65f5d936e4c12/biod/biometrics_daemon.cc
[modify] https://crrev.com/729a2991cd923f662dc95d750cf65f5d936e4c12/biod/fpc_biometrics_manager.cc
[modify] https://crrev.com/729a2991cd923f662dc95d750cf65f5d936e4c12/biod/fake_biometrics_manager.cc
[modify] https://crrev.com/729a2991cd923f662dc95d750cf65f5d936e4c12/biod/tools/biod_client_tool.cc
[modify] https://crrev.com/729a2991cd923f662dc95d750cf65f5d936e4c12/biod/tools/fake_biometric_tool.cc

Project Member

Comment 37 by bugdroid1@chromium.org, Apr 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/729a2991cd923f662dc95d750cf65f5d936e4c12

commit 729a2991cd923f662dc95d750cf65f5d936e4c12
Author: Mengqi Guo <mqg@chromium.org>
Date: Tue Apr 04 21:08:15 2017

biod: authenticate returns record IDs instead of labels

Since we use record IDs as the unique identifier for records
within biod, we return record IDs during AuthSession to indicate
a match between records and new biometric data. Meanwhile,
between biod and Chrome, we use record object path as the unique
identifier, so on authentication, biod sends record object path to
Chrome UI to indicate which records were matched.

BUG=chromium:629657
TEST=biod_client_tool and fake_biometric_tool

Change-Id: Iebb6de7b354e438eaebc083d04d5ffc4b8c2cd42
Reviewed-on: https://chromium-review.googlesource.com/456845
Commit-Ready: Mengqi Guo <mqg@chromium.org>
Tested-by: Mengqi Guo <mqg@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[modify] https://crrev.com/729a2991cd923f662dc95d750cf65f5d936e4c12/biod/biometrics_daemon.cc
[modify] https://crrev.com/729a2991cd923f662dc95d750cf65f5d936e4c12/biod/fpc_biometrics_manager.cc
[modify] https://crrev.com/729a2991cd923f662dc95d750cf65f5d936e4c12/biod/fake_biometrics_manager.cc
[modify] https://crrev.com/729a2991cd923f662dc95d750cf65f5d936e4c12/biod/tools/biod_client_tool.cc
[modify] https://crrev.com/729a2991cd923f662dc95d750cf65f5d936e4c12/biod/tools/fake_biometric_tool.cc

Project Member

Comment 38 by bugdroid1@chromium.org, Apr 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/3af80e418460df5696ac689b4ab07d95c7108dad

commit 3af80e418460df5696ac689b4ab07d95c7108dad
Author: Mengqi Guo <mqg@chromium.org>
Date: Tue Apr 04 23:27:22 2017

biod: switch to system_api constants from local constants

We are switching the constants that are shared between biod and
Chrome UI from local constants to system_api constants so that
they are more consistent and easy to track and change.

BUG=chromium:629657
TEST=biod_client_tool and fake_biometric_tool

Change-Id: Ia714bf43893a2c674a348bde738f4b1bd87a2522
Reviewed-on: https://chromium-review.googlesource.com/457857
Commit-Ready: Mengqi Guo <mqg@chromium.org>
Tested-by: Mengqi Guo <mqg@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[modify] https://crrev.com/3af80e418460df5696ac689b4ab07d95c7108dad/biod/fpc_biometrics_manager.cc
[modify] https://crrev.com/3af80e418460df5696ac689b4ab07d95c7108dad/biod/fpc_biometrics_manager.h
[modify] https://crrev.com/3af80e418460df5696ac689b4ab07d95c7108dad/biod/fake_biometrics_manager.h
[modify] https://crrev.com/3af80e418460df5696ac689b4ab07d95c7108dad/biod/fake_biometrics_manager.cc
[modify] https://crrev.com/3af80e418460df5696ac689b4ab07d95c7108dad/biod/biometrics_daemon.cc
[modify] https://crrev.com/3af80e418460df5696ac689b4ab07d95c7108dad/biod/biometrics_manager.h
[modify] https://crrev.com/3af80e418460df5696ac689b4ab07d95c7108dad/biod/tools/biod_client_tool.cc
[modify] https://crrev.com/3af80e418460df5696ac689b4ab07d95c7108dad/biod/biometrics_daemon.h

Project Member

Comment 39 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/59dc63f61ba10dd1d83762bfc2353d16aed99ea3

commit 59dc63f61ba10dd1d83762bfc2353d16aed99ea3
Author: Mengqi Guo <mqg@chromium.org>
Date: Wed Apr 05 03:42:50 2017

biod: not storing user id on disk

There are 2 reasons to not store user id on disk: 1. this ensures
that biod code will be compatible during user id migration; 2.
the directory in which records are stored already contain user id
in the form of cryptohome id, so no need to store it to identify
the records.

BUG=chromium:629657
TEST=unittest biod_client_tool

Change-Id: Ib1ae198f236b7530e85f93b8745fd89b23ffcef2
Reviewed-on: https://chromium-review.googlesource.com/466857
Commit-Ready: Mengqi Guo <mqg@chromium.org>
Tested-by: Mengqi Guo <mqg@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[modify] https://crrev.com/59dc63f61ba10dd1d83762bfc2353d16aed99ea3/biod/README.md
[modify] https://crrev.com/59dc63f61ba10dd1d83762bfc2353d16aed99ea3/biod/biod_storage.cc

Comment 40 by aut...@google.com, Apr 18 2017

Components: -Infra>Client>ChromeOS
Project Member

Comment 41 by bugdroid1@chromium.org, Apr 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/f4baa2e97009504c854b641898d676f0612dd964

commit f4baa2e97009504c854b641898d676f0612dd964
Author: Mengqi Guo <mqg@chromium.org>
Date: Sat Apr 22 04:57:44 2017

biod: adding unit test for biod storage

Adding unit test for biod storage. Also adding unit test structure to
biod.gyp file.

BUG=chromium:629657
TEST=unittest

Change-Id: I807a8a4b413615841cb4ce10cb872196a2633884
Reviewed-on: https://chromium-review.googlesource.com/463826
Commit-Ready: Mengqi Guo <mqg@chromium.org>
Tested-by: Mengqi Guo <mqg@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/f4baa2e97009504c854b641898d676f0612dd964/biod/fpc_biometrics_manager.cc
[modify] https://crrev.com/f4baa2e97009504c854b641898d676f0612dd964/biod/biod_storage.cc
[modify] https://crrev.com/f4baa2e97009504c854b641898d676f0612dd964/biod/fake_biometrics_manager.h
[modify] https://crrev.com/f4baa2e97009504c854b641898d676f0612dd964/biod/fake_biometrics_manager.cc
[modify] https://crrev.com/f4baa2e97009504c854b641898d676f0612dd964/biod/biod_storage.h
[modify] https://crrev.com/f4baa2e97009504c854b641898d676f0612dd964/biod/fpc_biometrics_manager.h
[add] https://crrev.com/f4baa2e97009504c854b641898d676f0612dd964/biod/biod_storage_unittest.cc
[modify] https://crrev.com/f4baa2e97009504c854b641898d676f0612dd964/biod/biod.gyp
[add] https://crrev.com/f4baa2e97009504c854b641898d676f0612dd964/biod/test_runner.cc

Project Member

Comment 42 by bugdroid1@chromium.org, Apr 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/afed98cc946c7cac079b01e3e52b9d8d4a34b144

commit afed98cc946c7cac079b01e3e52b9d8d4a34b144
Author: Mengqi Guo <mqg@chromium.org>
Date: Sat Apr 22 23:41:09 2017

biod: add unit tests to biod ebuild

Changing ebuild so we can add unit test to biod.

BUG=chromium:629657
TEST=unittest
CQ-DEPEND=CL:463826

Change-Id: I14f4229ea3d5a27580b0d2452a60431ea4ba775a
Reviewed-on: https://chromium-review.googlesource.com/466487
Commit-Ready: Mengqi Guo <mqg@chromium.org>
Tested-by: Mengqi Guo <mqg@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/afed98cc946c7cac079b01e3e52b9d8d4a34b144/chromeos-base/biod/biod-9999.ebuild

Project Member

Comment 43 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/d6db48aea7eb5932be3df3065160b4dff8cc2fca

commit d6db48aea7eb5932be3df3065160b4dff8cc2fca
Author: Mengqi Guo <mqg@chromium.org>
Date: Wed Apr 26 20:37:05 2017

biod: biod_client_tool bug fix

Previous biod_client_tool experiences segfault when
fake_biometric_tool sends a scan_done signal. This is fixed by
disabling copy and assign for BiometricsManagerProxy.

BUG=chromium:629657
TEST=biod_client_tool and fake_biometric_tool

Change-Id: Ibf3d40255bead8f23f33fa93d671074ce4ea8b1d
Reviewed-on: https://chromium-review.googlesource.com/469157
Commit-Ready: Mengqi Guo <mqg@chromium.org>
Tested-by: Mengqi Guo <mqg@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[modify] https://crrev.com/d6db48aea7eb5932be3df3065160b4dff8cc2fca/biod/tools/biod_client_tool.cc

Project Member

Comment 44 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/ab036964bdd37d5e041f797a716395cac683d0c4

commit ab036964bdd37d5e041f797a716395cac683d0c4
Author: Mengqi Guo <mqg@chromium.org>
Date: Tue May 02 02:18:09 2017

biod: change EnrollScanDone signal to proto

Change EnrollScanDone signal to proto so that percent_complete
could be an optional field.

BUG=chromium:629657
TEST=biod_client_tool & fake_biometric_tool
CQ-DEPEND=CL:483939, CL:483840

Change-Id: Ie2881d35a859556c2b5fb9114d2ad9ad8ef8bdb7
Reviewed-on: https://chromium-review.googlesource.com/487123
Commit-Ready: Mengqi Guo <mqg@chromium.org>
Tested-by: Mengqi Guo <mqg@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/ab036964bdd37d5e041f797a716395cac683d0c4/biod/fpc_biometrics_manager.cc
[modify] https://crrev.com/ab036964bdd37d5e041f797a716395cac683d0c4/biod/fpc_biometrics_manager.h
[modify] https://crrev.com/ab036964bdd37d5e041f797a716395cac683d0c4/biod/fake_biometrics_manager.cc
[modify] https://crrev.com/ab036964bdd37d5e041f797a716395cac683d0c4/biod/biometrics_daemon.cc
[modify] https://crrev.com/ab036964bdd37d5e041f797a716395cac683d0c4/biod/biometrics_manager.h
[modify] https://crrev.com/ab036964bdd37d5e041f797a716395cac683d0c4/biod/biod.gyp
[modify] https://crrev.com/ab036964bdd37d5e041f797a716395cac683d0c4/biod/tools/biod_client_tool.cc
[modify] https://crrev.com/ab036964bdd37d5e041f797a716395cac683d0c4/biod/biometrics_daemon.h

Project Member

Comment 45 by bugdroid1@chromium.org, May 2 2017

Project Member

Comment 46 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/2cf9070c4d8dfbd5972ca35f902530951a6ded5f

commit 2cf9070c4d8dfbd5972ca35f902530951a6ded5f
Author: Mengqi Guo <mqg@chromium.org>
Date: Tue May 02 02:18:08 2017

biod: change system_api ebuild to add proto to biod

Edit system_api ebuild to move biod constants into a separate
folder and add proto for signal EnrollScanDone.

BUG=chromium:629657
TEST=biod_client_tool & fake_biometric_tool
CQ-DEPEND=CL:487123, CL:483939

Change-Id: I3f1be56692732df5873dcd96f72e6f8a30d32a35
Reviewed-on: https://chromium-review.googlesource.com/483840
Commit-Ready: Mengqi Guo <mqg@chromium.org>
Tested-by: Mengqi Guo <mqg@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/2cf9070c4d8dfbd5972ca35f902530951a6ded5f/chromeos-base/system_api/system_api-9999.ebuild

Project Member

Comment 47 by bugdroid1@chromium.org, May 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/29742e11a5cdd8289fdf8df11027500765d09e0b

commit 29742e11a5cdd8289fdf8df11027500765d09e0b
Author: Mengqi Guo <mqg@chromium.org>
Date: Sat May 20 10:55:14 2017

biod: limit the range of scan result in fake_biometric_tool

Because of the change in EnrollScanDone dbus signal, we need to
limit the range of scan result in fake_biometric_tool. Otherwise
biod crashes.

BUG=chromium:629657
TEST=biod_client_tool & fake_biometric_tool

Change-Id: I0f63aed70fb90f820d9e0fee54cb005d81348900
Reviewed-on: https://chromium-review.googlesource.com/497971
Commit-Ready: Mengqi Guo <mqg@chromium.org>
Tested-by: Mengqi Guo <mqg@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/29742e11a5cdd8289fdf8df11027500765d09e0b/biod/tools/fake_biometric_tool.cc

Project Member

Comment 48 by bugdroid1@chromium.org, Jun 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/586905e8cf59d38393c8f4fe71724c6d488b6b43

commit 586905e8cf59d38393c8f4fe71724c6d488b6b43
Author: Mengqi Guo <mqg@chromium.org>
Date: Mon Jun 12 21:16:19 2017

biod: split and update libfp

Split libfp and update to 0.8.0 libfp.

BUG=chromium:629657
TEST=None
CQ-DEPEND=CL:514526

Change-Id: I2549364ace1c507c96b1f2b82f704b4834177651
Reviewed-on: https://chromium-review.googlesource.com/514411
Commit-Ready: Mengqi Guo <mqg@chromium.org>
Tested-by: Mengqi Guo <mqg@chromium.org>
Reviewed-by: Nicolas Norvez <norvez@chromium.org>

[add] https://crrev.com/586905e8cf59d38393c8f4fe71724c6d488b6b43/overlay-gru/virtual/libfp/libfp-2.ebuild
[modify] https://crrev.com/586905e8cf59d38393c8f4fe71724c6d488b6b43/overlay-gru/profiles/base/make.defaults
[add] https://crrev.com/586905e8cf59d38393c8f4fe71724c6d488b6b43/overlay-gru/chromeos-base/libfp-gru/Manifest
[add] https://crrev.com/586905e8cf59d38393c8f4fe71724c6d488b6b43/overlay-gru/chromeos-base/libfp-gru-test/libfp-gru-test-0.8.0-r1.ebuild
[add] https://crrev.com/586905e8cf59d38393c8f4fe71724c6d488b6b43/overlay-gru/chromeos-base/libfp-gru/files/gru_fpc_tball.sh
[add] https://crrev.com/586905e8cf59d38393c8f4fe71724c6d488b6b43/overlay-gru/chromeos-base/libfp-gru-test/libfp-gru-test-0.8.0.ebuild
[add] https://crrev.com/586905e8cf59d38393c8f4fe71724c6d488b6b43/overlay-gru/chromeos-base/libfp-gru/libfp-gru-0.8.0.ebuild
[add] https://crrev.com/586905e8cf59d38393c8f4fe71724c6d488b6b43/overlay-gru/chromeos-base/libfp-gru/libfp-gru-0.8.0-r1.ebuild
[add] https://crrev.com/586905e8cf59d38393c8f4fe71724c6d488b6b43/overlay-gru/chromeos-base/libfp-gru-test/Manifest

Project Member

Comment 49 by bugdroid1@chromium.org, Jun 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/98e29a3dbd0eca277490a184016838821d99f112

commit 98e29a3dbd0eca277490a184016838821d99f112
Author: Mengqi Guo <mqg@chromium.org>
Date: Mon Jun 12 21:16:19 2017

biod: add timestamp to fp_pal_get_timestamp and customize gyp

Adding another option to get timestamp for non-x86/amd64.
Also customizing gyp file for ARM devices due to libfp separation.

BUG=chromium:629657
TEST=cros_workon_make, cros deploy, biod_client_tool
CQ-DEPEND=CL:514411

Change-Id: I5a9ad18670d51096fbdbdcd9cfcbe56787c04c0c
Reviewed-on: https://chromium-review.googlesource.com/514526
Commit-Ready: Mengqi Guo <mqg@chromium.org>
Tested-by: Mengqi Guo <mqg@chromium.org>
Reviewed-by: Nicolas Norvez <norvez@chromium.org>

[modify] https://crrev.com/98e29a3dbd0eca277490a184016838821d99f112/biod/fpc/fpc_platform_utils.cc
[modify] https://crrev.com/98e29a3dbd0eca277490a184016838821d99f112/biod/biod.gyp

Project Member

Comment 50 by sheriffbot@chromium.org, Jun 13 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 51 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/4971b2abb4066a5ab53b949564081cbfe704fc85

commit 4971b2abb4066a5ab53b949564081cbfe704fc85
Author: oka@chromium.org <oka@chromium.org>
Date: Fri Sep 07 14:18:05 2018

common-mk: Write testrunner in gn

Subsequent CLs use the testrunner.
I split the CLs to decrease the chance of CQ failure.

BUG=chromium:629657
TEST=unittests with cros_workon_make --board=eve --test $package_name

Change-Id: Icf50d657bb63ee3ac61b757bae6b24cbf44f6cf0
Reviewed-on: https://chromium-review.googlesource.com/1149942
Commit-Ready: Keigo Oka <oka@chromium.org>
Tested-by: Keigo Oka <oka@chromium.org>
Reviewed-by: Keigo Oka <oka@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>

[modify] https://crrev.com/4971b2abb4066a5ab53b949564081cbfe704fc85/common-mk/BUILDCONFIG.gn
[add] https://crrev.com/4971b2abb4066a5ab53b949564081cbfe704fc85/common-mk/testrunner/BUILD.gn
[modify] https://crrev.com/4971b2abb4066a5ab53b949564081cbfe704fc85/common-mk/BUILD.gn

Cc: -za...@chromium.org
Project Member

Comment 53 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/c162fd8f8344f257eef146a6fa5cb6294e04ef8e

commit c162fd8f8344f257eef146a6fa5cb6294e04ef8e
Author: Keigo Oka <oka@chromium.org>
Date: Fri Sep 14 01:58:42 2018

goldfishd: migrate the package to GN.

BUG=chromium:629657
TEST=precq passes

Change-Id: I2b78d24a6fdc1ea8231c2a55b889e16eee3ed8be
Reviewed-on: https://chromium-review.googlesource.com/1201242
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Keigo Oka <oka@chromium.org>
Reviewed-by: Keigo Oka <oka@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>

[add] https://crrev.com/c162fd8f8344f257eef146a6fa5cb6294e04ef8e/goldfishd/BUILD.gn
[delete] https://crrev.com/1646b863efc0b48eb4563a93ce180eed1d5e11b6/goldfishd/goldfishd.gyp

Sign in to add a comment