Hmmm ... did the omnibox icon ever dismiss or was that when it was an infobar?

We could make it hide whenever you click Done, regardless of what you click, but might be unintuitive how you would undo that.

I'm pretty sure it used to hide, no? e.g. right now on my chromebox it doesn't
show, because I accepted the handler in the past.

It's annoying to see the icon, respond to it, and have it still be there even
though I've already answered its question. It's like a notification that won't
go away, yet is not actionable or useful.

To be clear, the icon in question is the "double-diamond" icon seen when a site is attempting to use registerProtocolHandler.

Deleted: double-diamond.png 5.1 KB

	double-diamond.png 5.1 KB View Download

Some additional details: it *does* go away if you refresh the page after having chosen any option and pressing Done. The bug is just that it doesn't go away immediately, right?

So steps to reproduce:
1. Visit https://mail.google.com.
2. Sign in.
3. Click the double-diamond icon in the URL bar.
4. Choose any option, and press Done.
5. Refresh the page.

Expected behaviour: the icon disappears after Step 4.
Actual behaviour: the icon disappears only after Step 5.

====================================

Good Build:

51.0.2702.0    Base Position: 385602


Bad Build:

52.0.2705.0    Base Position: 386318

=====================================

Able to repro this issue on Windows 7 & Ubuntu Trusty (14.04) for the Google Chrome Stable Version - 51.0.2704.106

This is a regression issue broken in M51, below mentioned is the bisect info:

CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/9d1960a45d22938a3deb641657d8e21f5ff7b76b..0c6faeb81f1461952b5c63ad33e9fccc021a0c95

Suspecting Commit: 6a7de16dc3bd3da6f51d4b654fdd51c7a546d7c1

Review URL: https://codereview.chromium.org/1870533002

@estade: Could you please look into the issue, and if it has nothing to do with your changes and if possible please do assign it to the concerned owner.

Thank you.

Note: Issue not observed on MAC OS, tested on OS Version - 10.11.5

I did break this, and looking at the code I feel we were lucky I didn't break more (such as the actual functionality). I have a fix here[1] which fixes the regression and also hides the icon if you change the setting (e.g. click on allow) and then dismiss the bubble by clicking outside its bounds. Previously, you would have had to click Done to get the icon to dismiss.

This patch could be merged to m53 but it seems relatively minor so I'd lean against that idea.

[1] https://codereview.chromium.org/2169453003

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/094178fd159b1c26e82e7a5fa7f33f28aec10dd1

commit 094178fd159b1c26e82e7a5fa7f33f28aec10dd1
Author: estade <estade@chromium.org>
Date: Thu Jul 21 15:28:03 2016

Hide protocol handler icon in location bar after user is done
interacting with it.

This fixes a regression where the icon lingered after the user pressed
"Done". Luckily this regression only affected the protocol handler icon
and didn't change functionality (the user's choice was still respected).

This also improves on the behavior of said icon by hiding it when the
user dismisses the bubble via other means (e.g. clicking outside the
bubble), so long as they've explicitly interacted with the bubble by changing
the setting.

BUG= 629645 

Review-Url: https://codereview.chromium.org/2169453003
Cr-Commit-Position: refs/heads/master@{#406857}

[modify] https://crrev.com/094178fd159b1c26e82e7a5fa7f33f28aec10dd1/chrome/browser/ui/content_settings/content_setting_bubble_model.cc
[modify] https://crrev.com/094178fd159b1c26e82e7a5fa7f33f28aec10dd1/chrome/browser/ui/content_settings/content_setting_bubble_model.h
[modify] https://crrev.com/094178fd159b1c26e82e7a5fa7f33f28aec10dd1/chrome/browser/ui/views/content_setting_bubble_contents.cc
[modify] https://crrev.com/094178fd159b1c26e82e7a5fa7f33f28aec10dd1/chrome/browser/ui/views/content_setting_bubble_contents.h