This bug has been sitting around for almost a year. During that time the win_nacl_sdk try bot (to choose one of several) has only run about sixty times, with 25 of those being failures.

Is this intended to be working? If so we should add it to the waterfall. If not we should remove the try bots.

It appears to be broken again, by crrev.com/2814503002 which removed SVN support from build\util\lastchange.py. I only happened to notice because I selected some random additional try bots for a change I was evaluating.

Other signs of obsolescence are that 28 months ago crrev.com/811533002 changed buildbot_common.py to look for the depot_tools version of VS 2013, here:

    vs2013_dir = os.path.join(depot_tools_dir, 'win_toolchain', 'vs2013_files')

Funny thing is, that code hasn't been updated since. Since then VS 2013's location in depot_tools has changed, and we've moved to VS 2015 and we are thinking of moving towards VS 2017. I'm not sure why this isn't causing failures - delete? Update?

I've got a NOP test change pending to verify that the failures I've seen are unrelated to VS 2017, but I'm already positive that they are unrelated. The test change, FWIW, is crrev.com/2828943002.

The test failures from the NOP change in crrev.com/2828943002 are the same as for the VS 2017 change, proving that they aren't related to the compiler change. The step that shows as failing is annotated_steps but the actual failure is in Run unittests. The failure messages, caused by the removal of FetchSVNRevision, are:

======================================================================
ERROR: testChromeCommitPosition (build_version_test.TestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "E:\b\build\slave\win_nacl_sdk\build\src\native_client_sdk\src\build_tools\tests\build_version_test.py", line 27, in setUp
    self.fetch_svn = mock.patch('lastchange.FetchSVNRevision').start()
  File "E:\b\build\slave\win_nacl_sdk\build\src\third_party\pymock\mock.py", line 1396, in start
    result = self.__enter__()
  File "E:\b\build\slave\win_nacl_sdk\build\src\third_party\pymock\mock.py", line 1268, in __enter__
    original, local = self.get_original()
  File "E:\b\build\slave\win_nacl_sdk\build\src\third_party\pymock\mock.py", line 1242, in get_original
    "%s does not have the attribute %r" % (target, name)
AttributeError: <module 'lastchange' from 'E:\b\build\slave\win_nacl_sdk\build\src\build/util\lastchange.py'> does not have the attribute 'FetchSVNRevision'

+sbc +bradnelson

Fix in flight: https://codereview.chromium.org/2842513002/

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/060db36535689ed73b7c453726a07b4185074938

commit 060db36535689ed73b7c453726a07b4185074938
Author: sbc <sbc@chromium.org>
Date: Mon Apr 24 21:10:11 2017

Update nacl SDK code to match recent changes to lastchange.py

The API in laschange.py recently changed with
https://codereview.chromium.org/2826263003.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk
BUG= 629626 

Review-Url: https://codereview.chromium.org/2842513002
Cr-Commit-Position: refs/heads/master@{#466764}

[modify] https://crrev.com/060db36535689ed73b7c453726a07b4185074938/native_client_sdk/src/build_tools/build_version.py
[modify] https://crrev.com/060db36535689ed73b7c453726a07b4185074938/native_client_sdk/src/build_tools/tests/build_version_test.py