Mac GLSL compiler doesn't handle #pragma STDGL invariant(all) correctly |
|||
Issue descriptionMac OS' GLSL compiler doesn't handle the: #pragma STDGL invariant(all) properly. In some situations it seems to ignore it, leading to later errors linking the shader program. Flattening it into the variables' declarations seems to work around this problem.
,
Aug 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/bccc65d32305ba3d5f456c4dd45b18cae33d4e7e commit bccc65d32305ba3d5f456c4dd45b18cae33d4e7e Author: Kenneth Russell <kbr@chromium.org> Date: Tue Jul 19 23:48:43 2016 Flatten "#pragma STDGL invariant(all)" into varying variables. This is implemented as a compiler option which is enabled by default when outputting to desktop GLSL version 130 and greater, which does not support this #pragma in fragment shaders. As a workaround, and for better compatibility on desktop OpenGL drivers, this pragma is also flattened into the outputs of vertex shaders, and the inputs of ESSL 1.00 fragment shaders. TEST=conformance/glsl/misc/shaders-with-invariance.html with --enable-unsafe-es3-apis BUG= 629622 , angleproject:1293 Change-Id: Ib040230915e639971505ed496d26e804c9d64e68 Reviewed-on: https://chromium-review.googlesource.com/361792 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> [modify] https://crrev.com/bccc65d32305ba3d5f456c4dd45b18cae33d4e7e/src/compiler/translator/TranslatorESSL.h [modify] https://crrev.com/bccc65d32305ba3d5f456c4dd45b18cae33d4e7e/include/GLSLANG/ShaderLang.h [modify] https://crrev.com/bccc65d32305ba3d5f456c4dd45b18cae33d4e7e/src/compiler/translator/Compiler.cpp [modify] https://crrev.com/bccc65d32305ba3d5f456c4dd45b18cae33d4e7e/src/compiler/translator/TranslatorESSL.cpp [modify] https://crrev.com/bccc65d32305ba3d5f456c4dd45b18cae33d4e7e/src/compiler/translator/TranslatorHLSL.cpp [modify] https://crrev.com/bccc65d32305ba3d5f456c4dd45b18cae33d4e7e/src/compiler/translator/Types.h [modify] https://crrev.com/bccc65d32305ba3d5f456c4dd45b18cae33d4e7e/src/compiler/translator/TranslatorGLSL.h [modify] https://crrev.com/bccc65d32305ba3d5f456c4dd45b18cae33d4e7e/src/compiler/translator/TranslatorGLSL.cpp [modify] https://crrev.com/bccc65d32305ba3d5f456c4dd45b18cae33d4e7e/src/compiler/translator/ParseContext.cpp [modify] https://crrev.com/bccc65d32305ba3d5f456c4dd45b18cae33d4e7e/src/compiler/translator/ParseContext.h [modify] https://crrev.com/bccc65d32305ba3d5f456c4dd45b18cae33d4e7e/src/compiler/translator/TranslatorHLSL.h [modify] https://crrev.com/bccc65d32305ba3d5f456c4dd45b18cae33d4e7e/src/compiler/translator/Compiler.h
,
Aug 19 2016
I'm calling this fixed.
,
Aug 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1804744969aee6759124ac17f84146307218f46e commit 1804744969aee6759124ac17f84146307218f46e Author: jmadill <jmadill@chromium.org> Date: Mon Aug 22 22:20:18 2016 Roll ANGLE d2f59bb..3fdec91 https://chromium.googlesource.com/angle/angle.git/+log/d2f59bb..3fdec91 BUG= 629622 , angleproject:1293 TBR=geofflang@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2266983002 Cr-Commit-Position: refs/heads/master@{#413551} [modify] https://crrev.com/1804744969aee6759124ac17f84146307218f46e/DEPS
,
Aug 23 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by kbr@chromium.org
, Jul 19 2016