Go converter generates empty tag value as a negation: https://chromium.googlesource.com/infra/infra.git/+/8c0bc93cbd2ca446314a5fc6c61df33971169b91/go/src/infra/tools/swarming-transition/cmd/swarmbucketbuilders/main.go#416 But doing this was rejected. From luci-config email: Change: https://boringssl.googlesource.com/boringssl/+/aa9a448f6f9b458a7f85f331395d0c41edc35b3d ERROR: Bucket client.boringssl: swarming: builder android_aarch64: dimension #1: no value ERROR: Bucket client.boringssl: swarming: builder android_aarch64_rel: dimension #1: no value ERROR: Bucket client.boringssl: swarming: builder android_arm: dimension #1: no value ERROR: Bucket client.boringssl: swarming: builder android_arm_rel: dimension #1: no value
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/60670f24bd58b986790ca440761649bb758a6753 commit 60670f24bd58b986790ca440761649bb758a6753 Author: nodir <nodir@chromium.org> Date: Tue Jul 26 16:50:53 2016 swarmbucket: fix empty dimension value Make a dimension with no value valid and meaning that it cancels a value for this dimension defined at wider scope, e.g. in common_dimension R=tandrii@chromium.org BUG= 629620 Review-Url: https://codereview.chromium.org/2160913003 [modify] https://crrev.com/60670f24bd58b986790ca440761649bb758a6753/appengine/cr-buildbucket/proto/project_config.proto [modify] https://crrev.com/60670f24bd58b986790ca440761649bb758a6753/appengine/cr-buildbucket/swarming/swarming.py [modify] https://crrev.com/60670f24bd58b986790ca440761649bb758a6753/appengine/cr-buildbucket/swarming/swarmingcfg.py [modify] https://crrev.com/60670f24bd58b986790ca440761649bb758a6753/appengine/cr-buildbucket/swarming/test/swarming_test.py [modify] https://crrev.com/60670f24bd58b986790ca440761649bb758a6753/appengine/cr-buildbucket/swarming/test/swarmingcfg_test.py [modify] https://crrev.com/60670f24bd58b986790ca440761649bb758a6753/go/src/infra/tools/swarming-transition/cmd/swarmbucketbuilders/testdata/builders.pyl [modify] https://crrev.com/60670f24bd58b986790ca440761649bb758a6753/go/src/infra/tools/swarming-transition/cmd/swarmbucketbuilders/testdata/expected.cfg
Comment 1 by no...@chromium.org
, Jul 19 2016Status: Assigned (was: Untriaged)