New issue
Advanced search Search tips

Issue 629605 link

Starred by 2 users
Status: Fixed
Owner:
msw@chromium.org
Closed: Sep 2016
Cc:
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

mash: Migrate ash_sysui wallpaper code to wm common types.

Project Member Reported by msw@chromium.org, Jul 19 2016 
mash: Migrate ash_sysui wallpaper code to wm common types.

Migrating ash/desktop_background/* will be a mix of straightforward and more complex tasks.
 desktop_background_controller.h WindowTreeHostManager::Observer -> WmDisplayObserver
 desktop_background_controller.cc DisplayManager::GetDisplayInfo -> WmShell::GetDisplayInfo
 desktop_background_controller.cc aura::Window -> WmWindow for 
 Shell::[user_wallpaper_delegate, desktop_background_controller] -> WmShell
 Support WmRootWindowController::[OnWallpaperAnimationFinished, HandleInitialDesktopBackgroundAnimationStarted, animating_wallpaper_controller]
 Support views::Widget::ReparentNativeView... (for locking, uses aura::Window)
 Move ash/sysui/user_wallpaper_delegate_mus.* to ash/mus.
 etc...
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60ca980b7d941d76094f53e633c2d11ff5c9b362

commit 60ca980b7d941d76094f53e633c2d11ff5c9b362
Author: msw <msw@chromium.org>
Date: Tue Aug 02 22:48:30 2016

mash: Partially migrate ash/desktop_background to ash common types.

Nix shell_factory.h (move used decl to desktop_background_view).
Nix DesktopBackgroundController::TestAPI (make test accessor public).
Nix unused DesktopBackgroundController functions, members, friends.
Nix unused solid_color_user_wallpaper_delegate.
Inline SetDesktopBackgroundImageMode.

Use WmDisplayObserver, not WindowTreeHostManager::Observer.
Use WmWindow instead of aura::Window in various places.
Use WmShell::GetDisplayInfo, not DisplayManager.
Use WmWindow animation functions.

BUG= 629605 
TEST=Automated; no Chrome OS wallpaper behavior changes.
R=jamescook@chromium.org
TBR=sky@chromium.org

Review-Url: https://codereview.chromium.org/2200893002
Cr-Commit-Position: refs/heads/master@{#409360}

[modify] https://crrev.com/60ca980b7d941d76094f53e633c2d11ff5c9b362/ash/ash.gyp
[modify] https://crrev.com/60ca980b7d941d76094f53e633c2d11ff5c9b362/ash/desktop_background/desktop_background_controller.cc
[modify] https://crrev.com/60ca980b7d941d76094f53e633c2d11ff5c9b362/ash/desktop_background/desktop_background_controller.h
[delete] https://crrev.com/1a5d12e8bdbd3b09acde1cdf669bd4403a982553/ash/desktop_background/desktop_background_controller_test_api.cc
[delete] https://crrev.com/1a5d12e8bdbd3b09acde1cdf669bd4403a982553/ash/desktop_background/desktop_background_controller_test_api.h
[modify] https://crrev.com/60ca980b7d941d76094f53e633c2d11ff5c9b362/ash/desktop_background/desktop_background_controller_unittest.cc
[modify] https://crrev.com/60ca980b7d941d76094f53e633c2d11ff5c9b362/ash/desktop_background/desktop_background_view.cc
[modify] https://crrev.com/60ca980b7d941d76094f53e633c2d11ff5c9b362/ash/desktop_background/desktop_background_view.h
[modify] https://crrev.com/60ca980b7d941d76094f53e633c2d11ff5c9b362/ash/desktop_background/desktop_background_widget_controller.cc
[modify] https://crrev.com/60ca980b7d941d76094f53e633c2d11ff5c9b362/ash/root_window_controller.cc
[modify] https://crrev.com/60ca980b7d941d76094f53e633c2d11ff5c9b362/ash/shell.cc
[modify] https://crrev.com/60ca980b7d941d76094f53e633c2d11ff5c9b362/ash/shell/content/client/shell_browser_main_parts.cc
[delete] https://crrev.com/1a5d12e8bdbd3b09acde1cdf669bd4403a982553/ash/shell_factory.h
[modify] https://crrev.com/60ca980b7d941d76094f53e633c2d11ff5c9b362/ash/sysui/sysui_application.cc
[modify] https://crrev.com/60ca980b7d941d76094f53e633c2d11ff5c9b362/ash/test/ui_controls_factory_ash.cc
[modify] https://crrev.com/60ca980b7d941d76094f53e633c2d11ff5c9b362/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/60ca980b7d941d76094f53e633c2d11ff5c9b362/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[modify] https://crrev.com/60ca980b7d941d76094f53e633c2d11ff5c9b362/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h
[modify] https://crrev.com/60ca980b7d941d76094f53e633c2d11ff5c9b362/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc
[modify] https://crrev.com/60ca980b7d941d76094f53e633c2d11ff5c9b362/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_unittest.cc
[modify] https://crrev.com/60ca980b7d941d76094f53e633c2d11ff5c9b362/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc
[modify] https://crrev.com/60ca980b7d941d76094f53e633c2d11ff5c9b362/chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc
[delete] https://crrev.com/1a5d12e8bdbd3b09acde1cdf669bd4403a982553/chrome/browser/ui/ash/solid_color_user_wallpaper_delegate.cc
[delete] https://crrev.com/1a5d12e8bdbd3b09acde1cdf669bd4403a982553/chrome/browser/ui/ash/solid_color_user_wallpaper_delegate.h
[modify] https://crrev.com/60ca980b7d941d76094f53e633c2d11ff5c9b362/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/60ca980b7d941d76094f53e633c2d11ff5c9b362/chrome/chrome_browser_ui.gypi
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e91d93494aa2e7638df38c11b0c7d881d46c213

commit 0e91d93494aa2e7638df38c11b0c7d881d46c213
Author: msw <msw@chromium.org>
Date: Thu Aug 25 22:34:09 2016

mash: Port mojo:ash_sysui's ContextMenuMus to mojo:ash.

Move and rename ash/common/wallpaper/wallpaper_delegate.h
Move instance/accessor to WmShell; rename subclasses, etc.

Add NativeWidgetFactoryMus for mojo:ash's ui widgets.
(needed to make a NativeWidgetMus for the context menu)

BUG= 640693 , 629605 
TEST=Basic context menus show in mash; no cros changes.
R=jamescook@chromium.org,sky@chromium.org
TBR=stevenjb@chromium.org,yusukes@chromium.org

Review-Url: https://codereview.chromium.org/2271373002
Cr-Commit-Position: refs/heads/master@{#414561}

[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/accelerators/accelerator_controller_delegate_aura.cc
[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/ash.gyp
[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/common/shell_delegate.h
[rename] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/common/wallpaper/wallpaper_delegate.h
[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/common/wm_shell.cc
[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/common/wm_shell.h
[delete] https://crrev.com/403a3527c8254da0addb2b650020dc11d241b0c3/ash/default_user_wallpaper_delegate.cc
[add] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/default_wallpaper_delegate.cc
[rename] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/default_wallpaper_delegate.h
[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/desktop_background/desktop_background_controller.cc
[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/desktop_background/desktop_background_controller_unittest.cc
[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/desktop_background/desktop_background_view.cc
[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/desktop_background/desktop_background_widget_controller.cc
[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/mus/BUILD.gn
[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/mus/bridge/wm_shell_mus.cc
[rename] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/mus/context_menu_mus.cc
[rename] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/mus/context_menu_mus.h
[add] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/mus/native_widget_factory_mus.cc
[add] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/mus/native_widget_factory_mus.h
[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/mus/shell_delegate_mus.cc
[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/mus/shell_delegate_mus.h
[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/mus/window_manager_application.cc
[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/mus/window_manager_application.h
[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/root_window_controller.cc
[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/shell.cc
[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/shell.h
[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/shell/shell_delegate_impl.h
[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/sysui/BUILD.gn
[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/sysui/shell_delegate_mus.cc
[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/sysui/shell_delegate_mus.h
[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/sysui/sysui_application.cc
[rename] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/sysui/wallpaper_delegate_mus.cc
[rename] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/sysui/wallpaper_delegate_mus.h
[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/test/test_shell_delegate.cc
[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/test/test_shell_delegate.h
[rename] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/test/test_wallpaper_delegate.cc
[rename] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/ash/test/test_wallpaper_delegate.h
[delete] https://crrev.com/403a3527c8254da0addb2b650020dc11d241b0c3/chrome/browser/chromeos/background/ash_user_wallpaper_delegate.h
[rename] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/chrome/browser/chromeos/background/ash_wallpaper_delegate.cc
[add] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/chrome/browser/chromeos/background/ash_wallpaper_delegate.h
[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/chrome/browser/chromeos/login/ui/login_display_host_impl.cc
[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/chrome/browser/ui/ash/chrome_shell_delegate.h
[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/chrome/browser/ui/ash/launcher/launcher_context_menu.cc
[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/chrome/browser/ui/ash/multi_user/user_switch_animator_chromeos.cc
[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/chrome/browser/ui/webui/options/browser_options_handler.cc
[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/chrome/browser/ui/webui/settings/appearance_handler.cc
[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/chrome/chrome_browser_chromeos.gypi
[modify] https://crrev.com/0e91d93494aa2e7638df38c11b0c7d881d46c213/components/arc/intent_helper/arc_intent_helper_bridge.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/607227f82031ad5afb33b33cd92adfbd69757d2b

commit 607227f82031ad5afb33b33cd92adfbd69757d2b
Author: msw <msw@chromium.org>
Date: Tue Aug 30 17:22:39 2016

Rename ash desktop_background to wallpaper.

Move and rename ash/desktop_background/*
Move and rename ash/wm/system_background_controller*
Rename identifiers; update comments.

Remove unused src_container for Reparent* functions.

BUG= 629605 
TEST=No functional changes; just renaming.
R=jamescook@chromium.org
TBR=sky@chromium.org,tsepez@chromium.org,jochen@chromium.org

Review-Url: https://codereview.chromium.org/2290473004
Cr-Commit-Position: refs/heads/master@{#415335}

[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/accelerators/accelerator_controller_delegate_aura.cc
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/ash.gyp
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/common/accelerators/accelerator_table.cc
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/common/accelerators/accelerator_table.h
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/common/root_window_controller_common.cc
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/common/shell_delegate.h
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/common/shell_window_ids.h
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/common/wm/overview/window_grid.cc
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/default_wallpaper_delegate.cc
[delete] https://crrev.com/e8b7133f781db0fe40ba704b9655d16ba3c2be7e/ash/desktop_background/desktop_background_controller.cc
[delete] https://crrev.com/e8b7133f781db0fe40ba704b9655d16ba3c2be7e/ash/desktop_background/desktop_background_controller_observer.h
[delete] https://crrev.com/e8b7133f781db0fe40ba704b9655d16ba3c2be7e/ash/desktop_background/desktop_background_view.h
[delete] https://crrev.com/e8b7133f781db0fe40ba704b9655d16ba3c2be7e/ash/desktop_background/desktop_background_widget_controller.h
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/display/root_window_transformers_unittest.cc
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/display/window_tree_host_manager_unittest.cc
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/mus/accelerators/accelerator_controller_delegate_mus.cc
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/mus/container_ids.cc
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/public/interfaces/container.mojom
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/root_window_controller.cc
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/root_window_controller.h
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/root_window_controller_unittest.cc
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/shell.cc
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/shell.h
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/shell_unittest.cc
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/sysui/sysui_application.cc
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/sysui/wallpaper_delegate_mus.cc
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/test/test_session_state_animator.cc
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/test/test_session_state_animator.h
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/test/test_wallpaper_delegate.cc
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/touch/touch_uma.cc
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/utility/screenshot_controller.cc
[rename] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/wallpaper/DEPS
[rename] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/wallpaper/OWNERS
[add] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/wallpaper/wallpaper_controller.cc
[rename] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/wallpaper/wallpaper_controller.h
[add] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/wallpaper/wallpaper_controller_observer.h
[rename] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/wallpaper/wallpaper_controller_unittest.cc
[rename] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/wallpaper/wallpaper_view.cc
[add] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/wallpaper/wallpaper_view.h
[rename] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/wallpaper/wallpaper_widget_controller.cc
[add] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/wallpaper/wallpaper_widget_controller.h
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/wm/event_client_impl.cc
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/wm/lock_state_controller.cc
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/wm/lock_state_controller.h
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/wm/lock_state_controller_unittest.cc
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/wm/overview/window_selector_unittest.cc
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/wm/root_window_layout_manager_unittest.cc
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/wm/session_state_animator.cc
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/wm/session_state_animator.h
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/wm/session_state_animator_impl.cc
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/wm/session_state_animator_impl.h
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/wm/session_state_animator_impl_unittest.cc
[rename] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/wm/system_wallpaper_controller.cc
[rename] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/ash/wm/system_wallpaper_controller.h
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/chrome/browser/chromeos/customization/customization_wallpaper_downloader_browsertest.cc
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/chrome/browser/chromeos/login/kiosk_browsertest.cc
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/chrome/browser/chromeos/login/lock/screen_locker.cc
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/chrome/browser/chromeos/login/ui/login_display_host_impl.cc
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/chrome/browser/chromeos/login/ui/login_display_host_impl.h
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc
[modify] https://crrev.com/607227f82031ad5afb33b33cd92adfbd69757d2b/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_policy_browsertest.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f439af9401f6f7c5af6a7239a09cac118c17aab

commit 3f439af9401f6f7c5af6a7239a09cac118c17aab
Author: msw <msw@chromium.org>
Date: Thu Sep 08 22:35:26 2016

mash: Migrate wallpaper controllers to ash/common.

Migrate ash/wallpaper files to ash/common/.
(move WallpaperController to WmShell)
(move [Animating]WallpaperWidgetController to WmRootWindowController)

Add WmRootWindowController wallpaper animation functions.
(TODO: port system wallpaper and boot screen to mash)

Move Shell::blocking_pool_ to WmShell; init for mash and tests.
Make WallpaperResizer use a scoped_refptr<TaskRunner>.
Move debug wallpaper shortcut to common.

BUG= 629605 
TEST=Automated; no ChromeOS wallpaper changes.
R=jamescook@chromium.org,sky@chromium.org
TBR=achuith@chromium.org,bshe@chromium.org

Review-Url: https://codereview.chromium.org/2318223003
Cr-Commit-Position: refs/heads/master@{#417420}

[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/accelerators/accelerator_controller_delegate_aura.cc
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/ash.gyp
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/aura/wm_root_window_controller_aura.cc
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/aura/wm_root_window_controller_aura.h
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/common/accelerators/accelerator_controller.cc
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/common/accelerators/debug_commands.cc
[add] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/common/wallpaper/DEPS
[rename] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/common/wallpaper/OWNERS
[rename] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/common/wallpaper/wallpaper_controller.cc
[rename] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/common/wallpaper/wallpaper_controller.h
[rename] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/common/wallpaper/wallpaper_controller_observer.h
[rename] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/common/wallpaper/wallpaper_controller_unittest.cc
[rename] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/common/wallpaper/wallpaper_view.cc
[rename] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/common/wallpaper/wallpaper_view.h
[rename] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/common/wallpaper/wallpaper_widget_controller.cc
[rename] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/common/wallpaper/wallpaper_widget_controller.h
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/common/wm_root_window_controller.cc
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/common/wm_root_window_controller.h
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/common/wm_shell.cc
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/common/wm_shell.h
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/default_wallpaper_delegate.cc
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/mus/BUILD.gn
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/mus/accelerators/accelerator_controller_delegate_mus.cc
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/mus/test/wm_test_helper.cc
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/mus/test/wm_test_helper.h
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/mus/window_manager.cc
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/mus/window_manager.h
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/mus/window_manager_application.cc
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/mus/window_manager_application.h
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/root_window_controller.cc
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/root_window_controller.h
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/shell.cc
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/shell.h
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/shell_unittest.cc
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/sysui/wallpaper_delegate_mus.cc
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/ash/test/test_wallpaper_delegate.cc
[delete] https://crrev.com/a52c715618a5f2ad02f507c6ad3ef6282c112bc7/ash/wallpaper/DEPS
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/chrome/browser/chromeos/customization/customization_wallpaper_downloader_browsertest.cc
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/chrome/browser/chromeos/login/kiosk_browsertest.cc
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/chrome/browser/chromeos/login/lock/screen_locker.cc
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/chrome/browser/chromeos/login/ui/login_display_host_impl.cc
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_policy_browsertest.cc
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/components/wallpaper/wallpaper_resizer.cc
[modify] https://crrev.com/3f439af9401f6f7c5af6a7239a09cac118c17aab/components/wallpaper/wallpaper_resizer.h
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d03b20662808183e75e52ad17ddf430a908d44f

commit 7d03b20662808183e75e52ad17ddf430a908d44f
Author: msw <msw@chromium.org>
Date: Sat Sep 10 00:13:21 2016

mash: Port sysui's WallpaperDelegateMus to mojo:ash.

Move wallpaper_delegate_mus.* to ash/mus.
Vend mojom::WallpaperController from WindowManagerApplication.
Enable context menu command.

Workaround NOTIMPLEMENTED WmShellMus::GetDisplayInfo.
TODO: Fix crash on actually setting wallpaper via picker...

BUG= 629605 
TEST=chrome --mash has default gray wallpaper, can open picker.
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2323063003
Cr-Commit-Position: refs/heads/master@{#417774}

[modify] https://crrev.com/7d03b20662808183e75e52ad17ddf430a908d44f/ash/common/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/7d03b20662808183e75e52ad17ddf430a908d44f/ash/common/wallpaper/wallpaper_view.cc
[modify] https://crrev.com/7d03b20662808183e75e52ad17ddf430a908d44f/ash/mus/BUILD.gn
[modify] https://crrev.com/7d03b20662808183e75e52ad17ddf430a908d44f/ash/mus/bridge/wm_shell_mus.cc
[modify] https://crrev.com/7d03b20662808183e75e52ad17ddf430a908d44f/ash/mus/context_menu_mus.cc
[modify] https://crrev.com/7d03b20662808183e75e52ad17ddf430a908d44f/ash/mus/manifest.json
[modify] https://crrev.com/7d03b20662808183e75e52ad17ddf430a908d44f/ash/mus/shell_delegate_mus.cc
[rename] https://crrev.com/7d03b20662808183e75e52ad17ddf430a908d44f/ash/mus/wallpaper_delegate_mus.cc
[rename] https://crrev.com/7d03b20662808183e75e52ad17ddf430a908d44f/ash/mus/wallpaper_delegate_mus.h
[modify] https://crrev.com/7d03b20662808183e75e52ad17ddf430a908d44f/ash/mus/window_manager_application.cc
[modify] https://crrev.com/7d03b20662808183e75e52ad17ddf430a908d44f/ash/mus/window_manager_application.h
[modify] https://crrev.com/7d03b20662808183e75e52ad17ddf430a908d44f/ash/sysui/BUILD.gn
[modify] https://crrev.com/7d03b20662808183e75e52ad17ddf430a908d44f/ash/sysui/manifest.json
[modify] https://crrev.com/7d03b20662808183e75e52ad17ddf430a908d44f/ash/sysui/shell_delegate_mus.cc
[modify] https://crrev.com/7d03b20662808183e75e52ad17ddf430a908d44f/ash/sysui/sysui_application.cc
[modify] https://crrev.com/7d03b20662808183e75e52ad17ddf430a908d44f/ash/sysui/sysui_application.h

Comment 6 by msw@chromium.org, Sep 12 2016

Status: Fixed (was: Assigned)

Comment 7 by lafo...@chromium.org, Feb 26 2018

Components: -MUS Internals>Services>WindowService
►

Sign in to add a comment