[people] differentiate UI if signin or sync are disabled by policy |
||||||||||||||||||||||
Issue description
I just tried old settings (i.e. chrome://settings-frame) with different policy combos. I'm attaching results of the screenshots.
When sync is disabled, but signin is enabled, old settings:
* allows signin
* disallows sync (hides "Set up sync..." button)
* [Sign in to Chrome] button is enabled in the user switcher
When sync and signin are disabled, old settings:
* hides the whole signin section
(there's a screenshot of this, it just looks like the user has scrolled, though...)
* [Sign in to Chrome] button is hidden in the user switcher
==> TL;DR - bettes@ what should new settings do if: <==
1) sync is disabled
2) sync+signin are disabled
==> /TL;DR <==
NOTES:
Some issues with the previous UI:
1) we shouldn't be showing the "changes will no longer by synced to your Google Account" if signin is allowed but sync is disabled
Interested in how I enabled these policies or which ones I'm talking about?
On Linux, I did:
$ sudo mkdir -p /etc/chromium/policies/managed/
And some combo of the 2 policies, i.e.
echo '{"SyncDisabled": true, "SigninAllowed": false}' | sudo tee /etc/chromium/policies/managed/test_policy.json
See also:
https://www.chromium.org/administrators/policy-list-3#SigninAllowed
https://www.chromium.org/administrators/policy-list-3#SyncDisabled
,
Jul 22 2016
Preference: do the same thing as old settings (except for the issue with the "Disconnect your Google Account" dialog when sync is disabled by policy... or just not set up at all?)
,
Jul 22 2016
,
Jul 23 2016
tbuckley@: do you mean just don't show the disconnect dialog at all when sync is disabled?
,
Jul 29 2016
For (1), I think there's already a mock (see https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-People-account.png%3Fz=half, "error_01"). Is it possible for sync to be enabled for some period of time and then be disabled later? I'd rather err on the side of showing a potentially unnecessary dialogue than potentially miss showing the dialogue to some users for whom it's relevant. (2) is interesting. I'm in favor of just removing the "Sign in to Chrome" button and the sign in promo/description text from the card, but keeping around the People card to allow the user to edit their local profile info (e.g. name/icon) and open the user manager. Also in favor of removing the "Sign in to Chrome" button from the user menu in this case. +Jane - can you confirm that in the new user menu, if signin is disallowed by enterprise policy, we don't show the "sign in to Chrome" button?
,
Jul 29 2016
Re: #4 -- I mean we should remove that snippet of text from the disconnect dialog if 1) sync is disabled by policy or 2) sync was never set up (maybe)
,
Jul 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/952e2e28ee1501c58d1de1830792418805c245ab commit 952e2e28ee1501c58d1de1830792418805c245ab Author: dbeam <dbeam@chromium.org> Date: Fri Jul 29 19:21:04 2016 MD Settings: disable cursor: pointer when sync is disabled R=tommycli@chromium.org BUG= 629604 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2178303003 Cr-Commit-Position: refs/heads/master@{#408716} [modify] https://crrev.com/952e2e28ee1501c58d1de1830792418805c245ab/chrome/browser/resources/settings/people_page/people_page.html
,
Jul 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91307343c94e876ef1951063c0ef5a53a0f2ca85 commit 91307343c94e876ef1951063c0ef5a53a0f2ca85 Author: dbeam <dbeam@chromium.org> Date: Fri Jul 29 21:15:22 2016 MD Settings: add test for managed actionability of people section R=tommycli@chromium.org BUG= 629604 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2195793003 Cr-Commit-Position: refs/heads/master@{#408753} [modify] https://crrev.com/91307343c94e876ef1951063c0ef5a53a0f2ca85/chrome/browser/resources/settings/people_page/people_page.html [modify] https://crrev.com/91307343c94e876ef1951063c0ef5a53a0f2ca85/chrome/test/data/webui/settings/people_page_test.js
,
Aug 8 2016
@dbeam let's bring this up in the UX sync if Alan still needs to weigh in
,
Aug 8 2016
For the record, I still think that: (1) is already addressed with the mock linked in #5 (2) should be addressed by removing the "Sign in to Chrome" button and description of sync from the settings card, but we should keep the card around so the profile info can be edited.
,
Sep 29 2016
well, take your pick: https://codereview.chromium.org/2375013004 hides parts of the UI https://codereview.chromium.org/2381783002 hides the whole people section ewald@, tbuckley@, bettes@: can we please agree on what we want here? I personally think ewald@'s proposal is the sanest, as a user can still locally edit their profile (and the section doesn't just disappear without explanation). ewald@: the "signin is allowed, by sync isn't" behavior you linked to in your mocks is already implements, afaik screenshots: - missing the whole section (just "Appearance" at the top) - missing parts of the people section - showing what "sync disabled" case looks like
,
Sep 29 2016
Thanks for putting together all the options and providing screenshots dbeam@! A couple thoughts: - I prefer the proposal where we keep the "People" section (first screenshot). - The "sync disabled" case looks great, glad we've got that implemented. Just one question: do we not show the "Managed by <domain name>" row above the Sync row in that scenario? When sync *is* allowed (and enabled), the row is there (see my attached screenshot). I think we should keep it there as well in the case where it's disabled by policy. tbuckley@ and bettes@ - are you on board with keeping the people section around?
,
Sep 29 2016
ewald@: yes, the row is there but "Managed by <domain>" depends on the account. The first account I was using was @gmail.com (and not managed). My @google account is managed by google.com.
,
Sep 29 2016
tommycli@, ewald@, and dbeam@ all prefer the "show a slimmed down" section approach, and it seems way saner in general (the previous settings page put profile editing in a different place, so it made more sense to hide the sync and sign-in section). the people section in md-settings deals with sync, signin, and local profile editing, so matching the old options isn't a good fit in this case.
,
Sep 29 2016
#14 ah got it, makes sense. Thanks for the explanation.
,
Sep 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15aaee9f3f5d9137bc5864ab923408a409188201 commit 15aaee9f3f5d9137bc5864ab923408a409188201 Author: dbeam <dbeam@chromium.org> Date: Thu Sep 29 22:06:12 2016 MD Settings: hide signin-related UI when signin is disabled (e.g. by policy) R=tommycli@chromium.org BUG= 629604 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2375013004 Cr-Commit-Position: refs/heads/master@{#421948} [modify] https://crrev.com/15aaee9f3f5d9137bc5864ab923408a409188201/chrome/browser/resources/settings/people_page/people_page.html [modify] https://crrev.com/15aaee9f3f5d9137bc5864ab923408a409188201/chrome/browser/resources/settings/people_page/people_page.js
,
Sep 29 2016
,
Nov 14 2016
,
Apr 9 2018
Verified fixed. If Sync is disabled by policy, in People section it shows the following: "Sync is disabled by your administrator." (see attached screenshot). SigninAllowed policy was deprecated. Chrome OS: 10452.52.0 Chrome: 66.0.3359.94 Device: Robo360 |
||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||
Comment 1 by dbeam@chromium.org
, Jul 19 2016