MD Settings: Searching navigates to chrome://md-settings/quickUnlock/authenticate on ToT |
|||||||
Issue description1. Open chrome://md-settings 2. Type something in search, e.g. "a" Page displays quick unlock section and navigates to chrome://md-settings/quickUnlock/authenticate. Guessing this has something to do with quick_unlock_routing_behavior.js.
,
Jul 19 2016
@tommycli: Could you take a look at this bug? One (or more) of the settings-subpages instances at https://cs.chromium.org/search/?q=people_page.html+dom-if%5C%22+name%3D&sq=package:chromium&type=cs, are modifying the current route when they are forced-rendered. This does not happen with other <settings-subpages> and it is a problem for searching, since force-rendering should not be modifiying the current route.
,
Jul 19 2016
jdufault: I'm guessing this has to do with the redirect-to-authenticate behavior of Quick unlock. How can we make this work with search correctly?
,
Jul 19 2016
,
Jul 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/611982bedb154c8f6138d7bb881047520940919a commit 611982bedb154c8f6138d7bb881047520940919a Author: jdufault <jdufault@chromium.org> Date: Wed Jul 20 18:05:10 2016 Fix search always navigating to quick unlock authenticate screen. BUG= 629598 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2160423002 Cr-Commit-Position: refs/heads/master@{#406617} [modify] https://crrev.com/611982bedb154c8f6138d7bb881047520940919a/chrome/browser/resources/settings/people_page/quick_unlock_choose_method.js [modify] https://crrev.com/611982bedb154c8f6138d7bb881047520940919a/chrome/browser/resources/settings/people_page/quick_unlock_setup_pin.js
,
Jul 20 2016
,
Aug 29 2016
,
Oct 7 2016
,
Oct 20 2016
Verified on ChromeOS 8872.18.0, 55.0.2883.20 |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by dpa...@chromium.org
, Jul 19 2016