New issue
Advanced search Search tips

Issue 629592 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Clean up the PendingCallback* helper functions

Project Member Reported by jkarlin@chromium.org, Jul 19 2016

Issue description

Templates should be used to remove the PendingCallback* methods in CacheStorage.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3555fc8a7880f6c132292689694aa1925dee461b

commit 3555fc8a7880f6c132292689694aa1925dee461b
Author: jkarlin <jkarlin@chromium.org>
Date: Wed Jul 20 20:59:47 2016

[CacheStorage] Simpler way to wrap callbacks to run pending operation completions

CacheStorage (and BackgroundSync) wrap callbacks in order to ensure that the scheduler
is bumped after running the callback. This resulted in lots of helper functions. This
CL cleans up the helper functions with the help of template magic.

BUG= 629592 

Review-Url: https://codereview.chromium.org/2167483002
Cr-Commit-Position: refs/heads/master@{#406668}

[modify] https://crrev.com/3555fc8a7880f6c132292689694aa1925dee461b/content/browser/background_sync/background_sync_manager.cc
[modify] https://crrev.com/3555fc8a7880f6c132292689694aa1925dee461b/content/browser/background_sync/background_sync_manager.h
[modify] https://crrev.com/3555fc8a7880f6c132292689694aa1925dee461b/content/browser/cache_storage/cache_storage.cc
[modify] https://crrev.com/3555fc8a7880f6c132292689694aa1925dee461b/content/browser/cache_storage/cache_storage.h
[modify] https://crrev.com/3555fc8a7880f6c132292689694aa1925dee461b/content/browser/cache_storage/cache_storage_cache.cc
[modify] https://crrev.com/3555fc8a7880f6c132292689694aa1925dee461b/content/browser/cache_storage/cache_storage_cache.h
[modify] https://crrev.com/3555fc8a7880f6c132292689694aa1925dee461b/content/browser/cache_storage/cache_storage_scheduler.cc
[modify] https://crrev.com/3555fc8a7880f6c132292689694aa1925dee461b/content/browser/cache_storage/cache_storage_scheduler.h

Status: Fixed (was: Started)

Sign in to add a comment