New issue
Advanced search Search tips

Issue 629571 link

Starred by 3 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocked on:
issue 629992
issue 629997

Blocking:
issue 629348



Sign in to add a comment

browser_test failures on macOS Sierra

Project Member Reported by erikc...@chromium.org, Jul 19 2016

Issue description

12 tests failed:
    AppBannerDataFetcherBrowserTest.WebAppBannerNoTypeInManifest (../../chrome/browser/banners/app_banner_data_fetcher_browsertest.cc:286)
    AppBannerDataFetcherBrowserTest.WebAppBannerNoTypeInManifestCapsExtension (../../chrome/browser/banners/app_banner_data_fetcher_browsertest.cc:292)
    GeolocationBrowserTest.DisplaysPrompt (../../chrome/browser/geolocation/geolocation_browsertest.cc:440)
    GeolocationBrowserTest.Geoposition (../../chrome/browser/geolocation/geolocation_browsertest.cc:451)
    GeolocationBrowserTest.IFramesWithCachedPosition (../../chrome/browser/geolocation/geolocation_browsertest.cc:586)
    GeolocationBrowserTest.IFramesWithFreshPosition (../../chrome/browser/geolocation/geolocation_browsertest.cc:549)
    GeolocationBrowserTest.LastUsageUpdated (../../chrome/browser/geolocation/geolocation_browsertest.cc:738)
    GeolocationBrowserTest.NoPromptBeforeStart (../../chrome/browser/geolocation/geolocation_browsertest.cc:654)
    GeolocationBrowserTest.NoPromptForAllowedOrigin (../../chrome/browser/geolocation/geolocation_browsertest.cc:501)
    GeolocationBrowserTest.NoPromptForOffTheRecord (../../chrome/browser/geolocation/geolocation_browsertest.cc:512)
    GeolocationBrowserTest.NoPromptForSecondTab (../../chrome/browser/geolocation/geolocation_browsertest.cc:469)
    GeolocationBrowserTest.TwoWatchesInOneFrame (../../chrome/browser/geolocation/geolocation_browsertest.cc:684)
16 tests timed out:
    ChromeServiceWorkerFetchPPAPIPrivateTest.OtherOrigin (../../chrome/browser/chrome_service_worker_browsertest.cc:480)
    ChromeServiceWorkerFetchPPAPIPrivateTest.OtherOriginCORS (../../chrome/browser/chrome_service_worker_browsertest.cc:485)
    ChromeServiceWorkerFetchPPAPIPrivateTest.OtherOriginCORSCredentials (../../chrome/browser/chrome_service_worker_browsertest.cc:496)
    ChromeServiceWorkerFetchPPAPIPrivateTest.OtherOriginCredentials (../../chrome/browser/chrome_service_worker_browsertest.cc:490)
    ChromeServiceWorkerFetchPPAPIPrivateTest.SameOrigin (../../chrome/browser/chrome_service_worker_browsertest.cc:459)
    ChromeServiceWorkerFetchPPAPIPrivateTest.SameOriginCORS (../../chrome/browser/chrome_service_worker_browsertest.cc:464)
    ChromeServiceWorkerFetchPPAPIPrivateTest.SameOriginCORSCredentials (../../chrome/browser/chrome_service_worker_browsertest.cc:475)
    ChromeServiceWorkerFetchPPAPIPrivateTest.SameOriginCredentials (../../chrome/browser/chrome_service_worker_browsertest.cc:469)
    ChromeServiceWorkerFetchPPAPITest.OtherOrigin (../../chrome/browser/chrome_service_worker_browsertest.cc:398)
    ChromeServiceWorkerFetchPPAPITest.OtherOriginCORS (../../chrome/browser/chrome_service_worker_browsertest.cc:406)
    ChromeServiceWorkerFetchPPAPITest.OtherOriginCORSCredentials (../../chrome/browser/chrome_service_worker_browsertest.cc:429)
    ChromeServiceWorkerFetchPPAPITest.OtherOriginCredentials (../../chrome/browser/chrome_service_worker_browsertest.cc:418)
    ChromeServiceWorkerFetchPPAPITest.SameOrigin (../../chrome/browser/chrome_service_worker_browsertest.cc:356)
    ChromeServiceWorkerFetchPPAPITest.SameOriginCORS (../../chrome/browser/chrome_service_worker_browsertest.cc:365)
    ChromeServiceWorkerFetchPPAPITest.SameOriginCORSCredentials (../../chrome/browser/chrome_service_worker_browsertest.cc:387)
    ChromeServiceWorkerFetchPPAPITest.SameOriginCredentials (../../chrome/browser/chrome_service_worker_browsertest.cc:376)
 
The ChromeServiceWorkerFetchPPAPITest and ChromeServiceWorkerFetchPPAPIPrivateTest failures were because I compiled without NACL support. The GeolocationBrowserTest and AppBannerDataFetcherBrowserTest are still real.
Owner: erikc...@chromium.org
Status: Assigned (was: Untriaged)
Assigning to Erik to find the right owner for this issue.

Note: This issue is marked as Beta blocker, M53 is scheduled to be promoted to Beta next week (07/27) please resolve asap.
Cc: erikc...@chromium.org
Labels: -Pri-1 -ReleaseBlock-Beta -M-53 M-54 Pri-2
Owner: ----
Status: Available (was: Assigned)
The geolocation test failures are caused by memory leaks. While bad, I wouldn't consider that a release blocker. AppBannerDataFetcherBrowserTest failures might be functional, but I don’t think they’re worth blocking a Beta release.

[ RUN      ] GeolocationBrowserTest.LastUsageUpdated
2016-07-20 14:54:01.459 browser_tests[95157:1493575] NSWindow warning: adding an unknown subview: <FullSizeContentView: 0x7fb1004983d0>. Break on NSLog to debug.
2016-07-20 14:54:01.459 browser_tests[95157:1493575] Call stack:
(
    "+callStackSymbols disabled for performance reasons"
)
[95157:88579:0720/145401:WARNING:simple_synchronous_entry.cc(1054)] Could not open platform files for entry.
[95157:86543:0720/145402:WARNING:embedded_test_server.cc(193)] Request not handled. Returning 404: /favicon.ico
[95157:29699:0720/145402:ERROR:leak_tracker.h(99)] Leaked 0x7fb101ab3a68 which was allocated by:
[95157:29699:0720/145402:ERROR:leak_tracker.h(100)] 0   libbase.dylib                       0x00000001180b087e _ZN4base5debug10StackTraceC2Ev + 30
1   libbase.dylib                       0x00000001180b08e5 _ZN4base5debug10StackTraceC1Ev + 21
2   browser_tests                       0x0000000104af1dcf _ZN4base5debug11LeakTrackerI29SystemURLRequestContextGetterEC2Ev + 47
3   browser_tests                       0x0000000104addaa5 _ZN4base5debug11LeakTrackerI29SystemURLRequestContextGetterEC1Ev + 21
4   browser_tests                       0x0000000104adda7b _ZN29SystemURLRequestContextGetterC2EP8IOThread + 91
5   browser_tests                       0x0000000104addacd _ZN29SystemURLRequestContextGetterC1EP8IOThread + 29
6   browser_tests                       0x0000000104ae51c0 _ZN8IOThread24InitSystemRequestContextEv + 912
7   browser_tests                       0x0000000104ae4de6 _ZN8IOThread33system_url_request_context_getterEv + 358
8   browser_tests                       0x0000000104d1f65e _ZN18BrowserProcessImpl22system_request_contextEv + 270
9   browser_tests                       0x00000001054dd8c0 _ZN13safe_browsing19SafeBrowsingService10InitializeEv + 128
10  browser_tests                       0x0000000104d25579 _ZN18BrowserProcessImpl25CreateSafeBrowsingServiceEv + 329
11  browser_tests                       0x0000000104d253e3 _ZN18BrowserProcessImpl21safe_browsing_serviceEv + 275
12  browser_tests                       0x0000000104c32a31 _ZN36ChromeResourceDispatcherHostDelegateC2Ev + 177
13  browser_tests                       0x0000000104c32c35 _ZN36ChromeResourceDispatcherHostDelegateC1Ev + 21
14  browser_tests                       0x0000000104d26add _ZN18BrowserProcessImpl29ResourceDispatcherHostCreatedEv + 93
15  browser_tests                       0x00000001049af0f0 _ZN26ChromeContentBrowserClient29ResourceDispatcherHostCreatedEv + 320
16  libcontent.dylib                    0x0000000122b0c5b7 _ZN7content26ResourceDispatcherHostImplC2Ev + 1719
17  libcontent.dylib                    0x0000000122b0cb15 _ZN7content26ResourceDispatcherHostImplC1Ev + 21
18  libcontent.dylib                    0x000000012236a587 _ZN7content15BrowserMainLoop21BrowserThreadsStartedEv + 3447
19  libcontent.dylib                    0x00000001223724ad _ZN4base8internal13FunctorTraitsIMN7content15BrowserMainLoopEFivEvE6InvokeIPS3_JEEEiS5_OT_DpOT0_ + 125
20  libcontent.dylib                    0x00000001223723df _ZN4base8internal12InvokeHelperILb0EiE8MakeItSoIRKMN7content15BrowserMainLoopEFivEJPS5_EEEiOT_DpOT0_ + 63
21  libcontent.dylib                    0x000000012237236b _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEiOT_OT0_NS_13IndexSequenceIJXspT1_EEEE + 91
22  libcontent.dylib                    0x0000000122371fec _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE + 44
23  libcontent.dylib                    0x0000000122c1650e _ZNK4base8CallbackIFivELNS_8internal8CopyModeE1EE3RunEv + 46
24  libcontent.dylib                    0x000000012322a4b0 _ZN7content17StartupTaskRunner14RunAllTasksNowEv + 528
25  libcontent.dylib                    0x0000000122368908 _ZN7content15BrowserMainLoop18CreateStartupTasksEv + 1816
26  libcontent.dylib                    0x0000000122374ea1 _ZN7content21BrowserMainRunnerImpl10InitializeERKNS_18MainFunctionParamsE + 2033
27  libcontent.dylib                    0x0000000122360b13 _ZN7content11BrowserMainERKNS_18MainFunctionParamsE + 531
28  libcontent.dylib                    0x000000012454b587 _ZN7content23RunNamedProcessTypeMainERKNSt3__112basic_stringIcNS0_11char_traitsIcEENS0_9allocatorIcEEEERKNS_18MainFunctionParamsEPNS_19ContentMainDelegateE + 599
29  libcontent.dylib                    0x000000012454d476 _ZN7content21ContentMainRunnerImpl3RunEv + 1462
30  libcontent.dylib                    0x000000012454aded _ZN7content11ContentMainERKNS_17ContentMainParamsE + 349
31  browser_tests                       0x0000000105dc1af8 _ZN7content15BrowserTestBase5SetUpEv + 3928
32  browser_tests                       0x00000001047e785e _ZN20InProcessBrowserTest5SetUpEv + 1822
33  browser_tests                       0x00000001060bffea _ZN7testing8internal38HandleSehExceptionsInMethodIfSupportedINS_4TestEvEET0_PT_MS4_FS3_vEPKc + 122
34  browser_tests                       0x000000010609d6ee _ZN7testing8internal35HandleExceptionsInMethodIfSupportedINS_4TestEvEET0_PT_MS4_FS3_vEPKc + 110
35  browser_tests                       0x000000010609d5e3 _ZN7testing4Test3RunEv + 115
36  browser_tests                       0x000000010609e768 _ZN7testing8TestInfo3RunEv + 216
37  browser_tests                       0x000000010609fa87 _ZN7testing8TestCase3RunEv + 231
38  browser_tests                       0x00000001060ad37a _ZN7testing8internal12UnitTestImpl11RunAllTestsEv + 922
39  browser_tests                       0x00000001060c320a _ZN7testing8internal38HandleSehExceptionsInMethodIfSupportedINS0_12UnitTestImplEbEET0_PT_MS4_FS3_vEPKc + 122
40  browser_tests                       0x00000001060acf5e _ZN7testing8internal35HandleExceptionsInMethodIfSupportedINS0_12UnitTestImplEbEET0_PT_MS4_FS3_vEPKc + 110
41  browser_tests                       0x00000001060ace39 _ZN7testing8UnitTest3RunEv + 393
42  browser_tests                       0x00000001048160c1 _Z13RUN_ALL_TESTSv + 17
43  browser_tests                       0x00000001048157dd _ZN4base9TestSuite3RunEv + 349
44  browser_tests                       0x000000010478a0a3 _ZN21ChromeTestSuiteRunner12RunTestSuiteEiPPc + 67
45  browser_tests                       0x000000010478a219 _ZN26ChromeTestLauncherDelegate12RunTestSuiteEiPPc + 57
46  browser_tests                       0x0000000105e8d01d _ZN7content11LaunchTestsEPNS_20TestLauncherDelegateEiiPPc + 829
47  browser_tests                       0x000000010478b03e _Z17LaunchChromeTestsiPN7content20TestLauncherDelegateEiPPc + 46
48  browser_tests                       0x000000010074c54f main + 239
49  browser_tests                       0x000000010074c434 start + 52
50  ???                                 0x0000000000000006 0x0 + 6

[95157:29699:0720/145402:FATAL:leak_tracker.h(104)] Check failed: 0u == count (0 vs. 1)
0   libbase.dylib                       0x00000001180b087e _ZN4base5debug10StackTraceC2Ev + 30
1   libbase.dylib                       0x00000001180b08e5 _ZN4base5debug10StackTraceC1Ev + 21
2   libbase.dylib                       0x0000000118134fc0 _ZN7logging10LogMessageD2Ev + 80
3   libbase.dylib                       0x0000000118132b75 _ZN7logging10LogMessageD1Ev + 21
4   browser_tests                       0x0000000104aef2df _ZN4base5debug11LeakTrackerI29SystemURLRequestContextGetterE13CheckForLeaksEv + 687
5   browser_tests                       0x0000000104aeec4e _ZN8IOThread7CleanUpEv + 974
6   libcontent.dylib                    0x0000000122391a34 _ZN7content17BrowserThreadImpl7CleanUpEv + 132
7   libcontent.dylib                    0x000000012238e245 _ZN7content23BrowserProcessSubThread7CleanUpEv + 69
8   libbase.dylib                       0x000000011831a1b2 _ZN4base6Thread10ThreadMainEv + 1650
9   libbase.dylib                       0x00000001182fa261 _ZN4base12_GLOBAL__N_110ThreadFuncEPv + 705
10  libsystem_pthread.dylib             0x00007fffb5c27c4f _pthread_body + 176
11  libsystem_pthread.dylib             0x00007fffb5c27b9f _pthread_body + 0
12  libsystem_pthread.dylib             0x00007fffb5c273d5 thread_start + 13


[ RUN      ] AppBannerDataFetcherBrowserTest.WebAppBannerNoTypeInManifest
2016-07-20 14:57:20.161 browser_tests[95193:1494463] NSWindow warning: adding an unknown subview: <FullSizeContentView: 0x7fbbe06cb150>. Break on NSLog to debug.
2016-07-20 14:57:20.161 browser_tests[95193:1494463] Call stack:
(
    "+callStackSymbols disabled for performance reasons"
)
[95193:93975:0720/145720:WARNING:simple_synchronous_entry.cc(1054)] Could not open platform files for entry.
[95193:51471:0720/145720:WARNING:embedded_test_server.cc(193)] Request not handled. Returning 404: /favicon.ico
../../chrome/browser/banners/app_banner_data_fetcher_browsertest.cc:112: Failure
Value of: observer->will_show()
  Actual: false
Expected: expected_to_show
Which is: true
[95193:1547:0720/145720:WARNING:pref_notifier_impl.cc(27)] pref observer found at shutdown printing.enabled
[95193:1547:0720/145720:WARNING:pref_notifier_impl.cc(27)] pref observer found at shutdown plugins.always_authorize
[95193:1547:0720/145720:WARNING:pref_notifier_impl.cc(27)] pref observer found at shutdown plugins.allow_outdated
[  FAILED  ] AppBannerDataFetcherBrowserTest.WebAppBannerNoTypeInManifest, where TypeParam =  and GetParam() =  (1341 ms)
Blockedon: 629992
Blockedon: 629997

Comment 6 by mcasas@chromium.org, Apr 19 2017

Re. #3, I just updated  https://crbug.com/629992 

> The test mentioned in #1 (GeolocationBrowserTest.LastUsageUpdated) has 
> been removed by [1], although before it had been reenabled by dominickn@ 
> in [2] after showing no flakiness. 
>
> Marking this issue as WontFix.
> 
> 
> [1] https://codereview.chromium.org/2697473002
> [2] https://codereview.chromium.org/2336903004
Status: WontFix (was: Available)

Sign in to add a comment