factory: Revise umpire-docker shared folder hierarchy |
||||||
Issue description
Version: ToT
OS: Chrome
What steps will reproduce the problem?
(1) factory_setup/umpire_docker.sh start
What is the expected output?
A single entry point with easy-to-understand layout for docker images we've created
What do you see instead?
Two folders created: /docker_shared, /docker_umpire
By offline discussion, in order to make sure we can create docker images for all ChromeOS factory software components in future (for example, Dome and Umpire), we propose the layout to be changed to:
/cros_docker/ # root of docker folders, should be assigned by environment variable or a --arg.
/umpire # collection of all umpires
$CONTAINER_NAME1 -> container1 /var/db/factory/umpire
$CONTAINER_NAME2 -> container2 /var/db/factory/umpire
# We probably want to may few more folders into umpire folder, for example /var/log/upstart/umpire* -- or add a command to find its logs.
/dome # collection of all domes, if in future
/mnt # shared by all container/docker images in /mnt
README # probably create a readme file to explain what this folder is and where it'll be mounted.
,
Jan 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/9ec419add54e90569fd83cdbebd552e0d1bca3df commit 9ec419add54e90569fd83cdbebd552e0d1bca3df Author: Hung-Te Lin <hungte@chromium.org> Date: Wed Jan 25 14:15:05 2017 setup: cros_docker: Merge /docker_umpire and /docker_shared/umpire. To simplify docker data management, put everything in same folder as single entry point and unify the folder layout structure. This commit changes /docker_umpire/$container_name to /docker_shared/umpire/$board_name. BUG= chromium:629568 TEST=make test; cd py/dome; make test Change-Id: Ie7ed722419868509d4e5e4e7cd6ae3ff3a38df24 Reviewed-on: https://chromium-review.googlesource.com/430561 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Pi-Hsun Shih <pihsun@chromium.org> [modify] https://crrev.com/9ec419add54e90569fd83cdbebd552e0d1bca3df/setup/cros_docker.sh [modify] https://crrev.com/9ec419add54e90569fd83cdbebd552e0d1bca3df/py/dome/backend/models.py [modify] https://crrev.com/9ec419add54e90569fd83cdbebd552e0d1bca3df/py/umpire/README.md
,
Feb 10 2017
,
Feb 10 2017
The only difference is the folder name has been kept "docker_shared" instead of "cros_docker". We may change the root folder name any time, but at least the hierarchy has been fixed.
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by hungte@chromium.org
, Jan 25 2017