New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 629554 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 522100



Sign in to add a comment

Change initTouchEvent removal warning to M54

Project Member Reported by chongz@chromium.org, Jul 19 2016

Issue description

We should update the removal warning to M54 since we have missed
M53 branch. (and merge into M53)

After that we can remove initTouchEvent in M54.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae2c536166e766bdff9b4a7ccb8757cd9b569598

commit ae2c536166e766bdff9b4a7ccb8757cd9b569598
Author: chongz <chongz@chromium.org>
Date: Tue Jul 19 19:43:02 2016

Change initTouchEvent removal warning to M54

This CL updates TouchEvent.InitTouchEvent removal warning to M54
since we missed M53 branch point. (The original plan was to remove
in M53)

The Chrome Status Entry has also been updated to M54:
https://www.chromestatus.com/features/5730982598541312

BUG= 629554 

Review-Url: https://codereview.chromium.org/2158863002
Cr-Commit-Position: refs/heads/master@{#406350}

[modify] https://crrev.com/ae2c536166e766bdff9b4a7ccb8757cd9b569598/third_party/WebKit/LayoutTests/fast/events/touch/document-create-touch-list-expected.txt
[modify] https://crrev.com/ae2c536166e766bdff9b4a7ccb8757cd9b569598/third_party/WebKit/LayoutTests/fast/events/touch/touch-event-dispatch-no-crash-expected.txt
[modify] https://crrev.com/ae2c536166e766bdff9b4a7ccb8757cd9b569598/third_party/WebKit/Source/core/frame/Deprecation.cpp

Comment 2 by chongz@chromium.org, Jul 21 2016

Cc: dtapu...@chromium.org
Labels: Merge-Request-53
Verified on Windows Canary 54.0.2803.0

Comment 3 by dimu@google.com, Jul 21 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 21 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/805adf0862083a6a20dfbd6114b3a392ffdb7a49

commit 805adf0862083a6a20dfbd6114b3a392ffdb7a49
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Thu Jul 21 18:54:55 2016

Change initTouchEvent removal warning to M54

This CL updates TouchEvent.InitTouchEvent removal warning to M54
since we missed M53 branch point. (The original plan was to remove
in M53)

The Chrome Status Entry has also been updated to M54:
https://www.chromestatus.com/features/5730982598541312

BUG= 629554 

Review-Url: https://codereview.chromium.org/2158863002
Cr-Commit-Position: refs/heads/master@{#406350}
(cherry picked from commit ae2c536166e766bdff9b4a7ccb8757cd9b569598)

Review URL: https://codereview.chromium.org/2171863002 .

Cr-Commit-Position: refs/branch-heads/2785@{#270}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/805adf0862083a6a20dfbd6114b3a392ffdb7a49/third_party/WebKit/LayoutTests/fast/events/touch/document-create-touch-list-expected.txt
[modify] https://crrev.com/805adf0862083a6a20dfbd6114b3a392ffdb7a49/third_party/WebKit/LayoutTests/fast/events/touch/touch-event-dispatch-no-crash-expected.txt
[modify] https://crrev.com/805adf0862083a6a20dfbd6114b3a392ffdb7a49/third_party/WebKit/Source/core/frame/Deprecation.cpp

Comment 5 by chongz@chromium.org, Jul 21 2016

Status: Fixed (was: Started)
Cc: ashej...@chromium.org
@chongz: Hey, are there any manual steps for TE to verify the above change ?

Appreciate your response.

Thank you!

Comment 7 by chongz@chromium.org, Jul 26 2016

@ashejole: Yes, to manually verify please:
  1. Go to chrome://flags/#touch-events and select "Enabled"
  2. Restart Chrome if necessary
  3. Go to any web page and open Console
  4. Paste "document.createEvent('TouchEvent').initTouchEvent()" and enter
  5. Observe Console warning

Expected Result:
The warning should be:
```
'TouchEvent.initTouchEvent' is deprecated and will be removed in M54, around October 2016. Please use the TouchEvent constructor instead. See https://www.chromestatus.com/features/5730982598541312 for more details.
```

The Warning used to be:
```
'TouchEvent.initTouchEvent' is deprecated and will be removed in M53, around September 2016. Please use the TouchEvent constructor instead. See https://www.chromestatus.com/features/5730982598541312 for more details.
```

Thanks for testing!
Labels: TE-Verified-M53 TE-Verified-53.0.2785.30
@chongz: Thanks for the prompt reply. I verified the above change as per steps mentioned in comment#7 on All-OS(Windows, Mac 10.11.5 & Ubuntu 14.04) with chrome version - 53.0.2785.30 and warning is displayed as mentioned in expected result. Hence marking the above issue as TE-Verified-53.0.2785.30.

Attach is the screen-print.

Thank you!
Screen Shot 2016-07-27 at 1.03.07 PM.png
164 KB View Download

Sign in to add a comment