servod broken. |
||
Issue description
sudo servod -b chell
2016-07-19 10:38:25,128 - servod - INFO - Start
2016-07-19 10:38:25,252 - servod - INFO - Found servo, vid: 0x18d1 pid: 0x5002 sid: 875286-00109
2016-07-19 10:38:25,254 - servod - INFO - Found XML overlay for board chell
2016-07-19 10:38:25,254 - SystemConfig - INFO - Loading XML config /usr/lib64/python2.7/site-packages/servo/data/servo_v2_r1.xml
2016-07-19 10:38:25,255 - SystemConfig - INFO - Loading XML config /usr/lib64/python2.7/site-packages/servo/data/servo_v2_r0.xml
2016-07-19 10:38:25,265 - SystemConfig - INFO - Loading XML config /usr/lib64/python2.7/site-packages/servo/data/common.xml
2016-07-19 10:38:25,271 - SystemConfig - INFO - Loading XML config /usr/lib64/python2.7/site-packages/servo/data/keyboard.xml
2016-07-19 10:38:25,287 - SystemConfig - INFO - Loading XML config /usr/lib64/python2.7/site-packages/servo/data/servo_chell_overlay.
2016-07-19 10:38:25,288 - SystemConfig - INFO - Loading XML config /usr/lib64/python2.7/site-packages/servo/data/servo_glados_overlay
2016-07-19 10:38:25,290 - SystemConfig - INFO - Loading XML config /usr/lib64/python2.7/site-packages/servo/data/servoflex_v2_r0_p50.
2016-07-19 10:38:25,291 - SystemConfig - INFO - Loading XML config /usr/lib64/python2.7/site-packages/servo/data/x86_ec_common.xml
2016-07-19 10:38:25,293 - SystemConfig - INFO - Loading XML config /usr/lib64/python2.7/site-packages/servo/data/ec_common.xml
2016-07-19 10:38:25,303 - Servod - INFO - Initializing interface 1 to ftdi_uart
2016-07-19 10:38:25,309 - Servod - INFO - /dev/pts/24
2016-07-19 10:38:25,309 - Servod - INFO - Initializing interface 2 to ftdi_i2c
2016-07-19 10:38:25,316 - Servod - INFO - Initializing interface 3 to ftdi_uart
2016-07-19 10:38:25,321 - Servod - INFO - /dev/pts/29
2016-07-19 10:38:25,321 - Servod - INFO - Initializing interface 4 to ftdi_uart
2016-07-19 10:38:25,326 - Servod - INFO - /dev/pts/30
2016-07-19 10:38:25,326 - Servod - INFO - Initializing interface 5 to ftdi_uart
Traceback (most recent call last):
File "/usr/lib/python-exec/python2.7/servod", line 9, in <module>
load_entry_point('servo===0.0.1-5c66721', 'console_scripts', 'servod')()
File "/usr/lib64/python2.7/site-packages/servo/servod.py", line 515, in main
main_function()
File "/usr/lib64/python2.7/site-packages/servo/servod.py", line 504, in main_function
usbkm232=options.usbkm232)
File "/usr/lib64/python2.7/site-packages/servo/servo_server.py", line 131, in __init__
result = func(interface)
File "/usr/lib64/python2.7/site-packages/servo/servo_server.py", line 330, in _init_ftdi_uart
self._serialname)
File "/usr/lib64/python2.7/site-packages/servo/ftdiuart.py", line 105, in __init__
sbits=0 # STOP_BIT_1 in ftdi.h
TypeError: an integer is required
Exception AttributeError: "'Fuart' object has no attribute '_is_closed'" in <bound method Fuart.__del__ of <servo.ftdiuart.Fuart obje
Segmentation fault (core dumped)
Looks like offending CL is:
Reviewed-on: https://chromium-review.googlesource.com/358881
Reverting to unblock users.
,
Jul 19 2016
Revert here: https://chromium-review.googlesource.com/361569. Will hold off pushing if you have a quick fix.
,
Jul 19 2016
,
Jul 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/hdctools/+/042f493a19249b920343fd8a31d0677d9f065da3 commit 042f493a19249b920343fd8a31d0677d9f065da3 Author: Kevin Cheng <kevcheng@chromium.org> Date: Tue Jul 19 17:46:00 2016 servod: Fix init function to properly init ftdi dummy spots. BUG= chromium:629550 TEST=Can init servod with a servo v2. Change-Id: Ie572729cfc801d157471f353b92e983f016b7821 Reviewed-on: https://chromium-review.googlesource.com/361575 Commit-Ready: Kevin Cheng <kevcheng@chromium.org> Tested-by: Kevin Cheng <kevcheng@chromium.org> Tested-by: Todd Broch <tbroch@chromium.org> Reviewed-by: Todd Broch <tbroch@chromium.org> [modify] https://crrev.com/042f493a19249b920343fd8a31d0677d9f065da3/servo/servo_server.py [modify] https://crrev.com/042f493a19249b920343fd8a31d0677d9f065da3/servo/servo_interfaces.py
,
Jul 21 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by kevcheng@chromium.org
, Jul 19 2016Owner: kevcheng@chromium.org