New issue
Advanced search Search tips

Issue 629544 link

Starred by 1 user
Status: Fixed
Owner:
jkarlin@chromium.org
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Immediately open cache backend on CacheStorageCache creation

Project Member Reported by jkarlin@chromium.org, Jul 19 2016 
We currently lazily open a cache backend on a CacheStorageCache's first operation. There are basically no circumstances in which one would open a cache and not use it. We can decrease the cost of the first operation by initializing immediately upon creation.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a545c04d6a45b90b1b021eff572c0a72c8f6c0a

commit 7a545c04d6a45b90b1b021eff572c0a72c8f6c0a
Author: jkarlin <jkarlin@chromium.org>
Date: Wed Jul 20 00:45:50 2016

[CacheStorage] Initialize the cache backend immediately upon opening instead of lazily.

Caches are used immediately after opening, we shouldn't lazily init them.

This CL:
1) Immediately initializes its backend upon creation
2) Changes the init method to use a pending closure, like the rest of the class.

BUG= 629544 

Review-Url: https://codereview.chromium.org/2112383002
Cr-Commit-Position: refs/heads/master@{#406430}

[modify] https://crrev.com/7a545c04d6a45b90b1b021eff572c0a72c8f6c0a/content/browser/cache_storage/cache_storage_cache.cc
[modify] https://crrev.com/7a545c04d6a45b90b1b021eff572c0a72c8f6c0a/content/browser/cache_storage/cache_storage_cache.h
[modify] https://crrev.com/7a545c04d6a45b90b1b021eff572c0a72c8f6c0a/content/browser/cache_storage/cache_storage_cache_unittest.cc
[modify] https://crrev.com/7a545c04d6a45b90b1b021eff572c0a72c8f6c0a/content/browser/cache_storage/cache_storage_manager_unittest.cc

Comment 2 by jkarlin@chromium.org, Jul 20 2016

Status: Fixed (was: Started)
►

Sign in to add a comment