New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 629539 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 627866



Sign in to add a comment

add tags to swarming runs

Project Member Reported by kevcheng@chromium.org, Jul 19 2016

Issue description

From https://bugs.chromium.org/p/chromium/issues/detail?id=627866#c2

Things that would help:
- Specify --tags and add tags
- Specify --decorate so the task id and URL are printed.

The main problem is that the task id is not printed so it's hard to find the task back. The tags helps searching for a kind of tasks.

https://chromeos-proxy.appspot.com/user/tasks?state=completed_failure


I'll add the following tags:
build:<build>
board:<board>
suite_name:<suite_name>

Let me know if there are others that might be interesting.
 

Comment 1 by sbasi@chromium.org, Jul 19 2016

Cc: mar...@chromium.org
Labels: -Pri-3 Pri-2
+maruel

Comment 2 by mar...@chromium.org, Jul 19 2016

release:R54
bvt:1
cq:1
flavor:debug or flavor:release

etc
feel free to be very liberal to add more than less.

Comment 3 by sbasi@chromium.org, Sep 12 2016

Ping Kevin, how much work is this? Aviv is asking if we can prioritize it. Let me know if you think it's a lot tho.
prob a day's worth of work, I can get to it this week if it's urgent.

Comment 5 by snanda@chromium.org, Sep 13 2016

Cc: akes...@chromium.org keta...@chromium.org semenzato@chromium.org snanda@chromium.org
Labels: -Pri-2 Pri-1
Kevin, will appreciate if you can get to it this week.  We are seeing a bunch of failures in Canary as well as CQ runs due to swarming timeouts and getting better insight into those failures will be really useful.

Here're some example CQ builds that failed due to swarming timeout just today:
HWTest [bvt-inline]
    lumpy/26118 (swarming timeout 8641s)
    veyron_mighty/3115 (swarming timeout 8642s)
    elm/571 (swarming timeout 8641s)
    x86-zgb/7719 (swarming timeout 8641s)
    wolf/12161 (swarming timeout 8642s)
    link/26153 (swarming timeout 8642s)
HWTest [arc-bvt-cq]
    veyron_minnie/384 (swarming timeout 8641s)
    cyan/384 (swarming timeout 8641s)
HWTest [sanity]
    wolf-tot/7827 (swarming timeout 8641s)

Initial cl is up: https://chromium-review.googlesource.com/#/c/384589/

Adding tags work.  

Decorate (which will add a link to the swarming task) looks like we'll need to update swarming.py on the servers (which may involve updating our libs as well).
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/74a60ce0fb3a7d3b5d9db8b85c672af91632d4de

commit 74a60ce0fb3a7d3b5d9db8b85c672af91632d4de
Author: Kevin Cheng <kevcheng@chromium.org>
Date: Tue Sep 13 17:18:54 2016

chromite: Add tags to swarming command and output task id.

BUG= chromium:629539 
TEST=unittest and tryjob

Change-Id: I91115248a77edef7e949653fdbeeea4797f11fd8
Reviewed-on: https://chromium-review.googlesource.com/384589
Commit-Ready: Kevin Cheng <kevcheng@chromium.org>
Tested-by: Kevin Cheng <kevcheng@chromium.org>
Reviewed-by: Fang Deng <fdeng@chromium.org>

[modify] https://crrev.com/74a60ce0fb3a7d3b5d9db8b85c672af91632d4de/cbuildbot/swarming_lib.py
[modify] https://crrev.com/74a60ce0fb3a7d3b5d9db8b85c672af91632d4de/cbuildbot/commands.py
[modify] https://crrev.com/74a60ce0fb3a7d3b5d9db8b85c672af91632d4de/cbuildbot/commands_unittest.py

Status: Fixed (was: Untriaged)
tags are now in, example task has the following tags: 

https://uberchromegw.corp.google.com/i/chromeos/builders/daisy_skate-paladin/builds/7831/steps/HWTest%20%5Bbvt-inline%5D/logs/stdio

https://chromeos-proxy.appspot.com/user/task/31802306be385610

board:daisy_skate
build:daisy_skate-paladin/R55-8838.0.0-rc3
os:Ubuntu-14.04
pool:default
priority:100
priority:CQ
suite:bvt-inline
task_name:daisy_skate-paladin/R55-8838.0.0-rc3-bvt-inline
user:
Great, thanks.

A related issue is the difficulty for newcomers (sheriffs, for instance) to notice the timeout in those logs.  I've opened issue 645259 a while ago.  Would it be possible and not too difficult to improve the (non-existent) error message in those cases?

I'll copy a few folks to that bug.



Sign in to add a comment