New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 629514 link

Starred by 2 users
Status: Duplicate
Merged: issue 629499
Owner:
█ raymes@chromium.org
OOO until 4th Feb
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

NotificationPermissionContextTest.PushSecureOriginRequirement fails on DrMemory

Project Member Reported by isheriff@chromium.org, Jul 19 2016 
NotificationPermissionContextTest.PushSecureOriginRequirement:
c:\b\build\slave\drm-cr\build\src\chrome\browser\notifications\notification_permission_context_unittest.cc(191): error: Value of: context.GetPermissionStatus(origin, origin)
Actual: 3
Expected: CONTENT_SETTING_BLOCK
Which is: 2
c:\b\build\slave\drm-cr\build\src\chrome\browser\notifications\notification_permission_context_unittest.cc(195): error: Value of: context.GetPermissionStatus(origin, origin)
Actual: 1
Expected: CONTENT_SETTING_BLOCK
Which is: 2


https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%29/builds/5351
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/170641109a0ef22dcff99a03cc4a6ad8610cf742

commit 170641109a0ef22dcff99a03cc4a6ad8610cf742
Author: isheriff <isheriff@chromium.org>
Date: Tue Jul 19 16:24:50 2016

Revert "Use the same codepath for NOTIFICATIONS and PUSH_MESSAGING permissions"

This reverts commit 4f82b403f397fbad2e44fe287c05956fcb7cf282.

NotificationPermissionContextTest.PushSecureOriginRequirement introduced
by this CL fails on DrMemory

TBR=raymes@chromium.org
BUG= 629514 

Review-Url: https://codereview.chromium.org/2162033002
Cr-Commit-Position: refs/heads/master@{#406291}

[modify] https://crrev.com/170641109a0ef22dcff99a03cc4a6ad8610cf742/chrome/app/generated_resources.grd
[modify] https://crrev.com/170641109a0ef22dcff99a03cc4a6ad8610cf742/chrome/browser/notifications/notification_permission_context.cc
[modify] https://crrev.com/170641109a0ef22dcff99a03cc4a6ad8610cf742/chrome/browser/notifications/notification_permission_context.h
[modify] https://crrev.com/170641109a0ef22dcff99a03cc4a6ad8610cf742/chrome/browser/notifications/notification_permission_context_unittest.cc
[modify] https://crrev.com/170641109a0ef22dcff99a03cc4a6ad8610cf742/chrome/browser/permissions/permission_bubble_request_impl.cc
[modify] https://crrev.com/170641109a0ef22dcff99a03cc4a6ad8610cf742/chrome/browser/permissions/permission_manager.cc
[modify] https://crrev.com/170641109a0ef22dcff99a03cc4a6ad8610cf742/chrome/browser/push_messaging/push_messaging_browsertest.cc
[add] https://crrev.com/170641109a0ef22dcff99a03cc4a6ad8610cf742/chrome/browser/push_messaging/push_messaging_permission_context.cc
[add] https://crrev.com/170641109a0ef22dcff99a03cc4a6ad8610cf742/chrome/browser/push_messaging/push_messaging_permission_context.h
[add] https://crrev.com/170641109a0ef22dcff99a03cc4a6ad8610cf742/chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc
[modify] https://crrev.com/170641109a0ef22dcff99a03cc4a6ad8610cf742/chrome/browser/push_messaging/push_messaging_service_unittest.cc
[modify] https://crrev.com/170641109a0ef22dcff99a03cc4a6ad8610cf742/chrome/chrome_browser.gypi
[modify] https://crrev.com/170641109a0ef22dcff99a03cc4a6ad8610cf742/chrome/chrome_tests_unit.gypi

Comment 2 by raymes@chromium.org, Jul 20 2016

Mergedinto: 629499
Status: Duplicate (was: Untriaged)
►

Sign in to add a comment