Issue metadata
Sign in to add a comment
|
NotificationPermissionContextTest.PushSecureOriginRequirement failing on DrMemory bot |
||||||||||||||||||||||||
Issue descriptionhttps://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%29/builds/5351/steps/memory%20test%3A%20unit/logs/stdio [ RUN ] NotificationPermissionContextTest.PushSecureOriginRequirement c:\b\build\slave\drm-cr\build\src\chrome\browser\notifications\notification_permission_context_unittest.cc(191): error: Value of: context.GetPermissionStatus(origin, origin) Actual: 3 Expected: CONTENT_SETTING_BLOCK Which is: 2 c:\b\build\slave\drm-cr\build\src\chrome\browser\notifications\notification_permission_context_unittest.cc(195): error: Value of: context.GetPermissionStatus(origin, origin) Actual: 1 Expected: CONTENT_SETTING_BLOCK Which is: 2 [ FAILED ] NotificationPermissionContextTest.PushSecureOriginRequirement (78 ms)
,
Jul 20 2016
This is happening because SecureOriginWhiteListTest.UnsafelyTreatInsecureOriginAsSecure marks http://example.com as secure which is leaked to other tests.
,
Jul 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0dfe00f7e138a1f9221e8865fffe3b3a859c92f commit d0dfe00f7e138a1f9221e8865fffe3b3a859c92f Author: raymes <raymes@chromium.org> Date: Thu Jul 21 00:58:25 2016 Fix SecureOriginWhiteListTest.UnsafelyTreatInsecureOriginAsSecure to not leak test state SecureOriginWhiteListTest.UnsafelyTreatInsecureOriginAsSecure currently marks 2 insecure origins as secure. This state leaks to other tests such that those origins are treated as secure in those tests. This CL cleans up the state by resetting SchemeAndOriginWhitelist after the test. BUG= 629499 Review-Url: https://codereview.chromium.org/2157363004 Cr-Commit-Position: refs/heads/master@{#406733} [modify] https://crrev.com/d0dfe00f7e138a1f9221e8865fffe3b3a859c92f/chrome/common/secure_origin_whitelist_unittest.cc [modify] https://crrev.com/d0dfe00f7e138a1f9221e8865fffe3b3a859c92f/content/common/origin_util.cc
,
Jul 21 2016
,
Dec 9 2016
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by raymes@chromium.org
, Jul 20 2016