New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 629491 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocked on:
issue 633212



Sign in to add a comment

Regression: Vertical scrollbar is seen misplaced in google drive page.

Project Member Reported by bj00129...@techmahindra.com, Jul 19 2016

Issue description

Version: 54.0.2800.0 Dev
OS: Ubuntu 14.04,Windows

What steps will reproduce the problem?
(1)Sign in to chrome>> Navigate to https://drive.google.com/drive/u/0/my-drive page and observe for vertical scrollbar

Expected:Vertical scrollbar should be seen at extreme end of the page.
Actual: Instead unwanted space is seen between scrollbar and end of the page.

This is Regression issue broken in M-54.
Good build:54.0.2790.0 Dev
Bad build:54.0.2791.0 Dev

CHANGELOG URL:  https://chromium.googlesource.com/chromium/src/+log/78fdffc1e7db6029385056589517fee14185828a..0e902e6e9dd6919de0cacc0286bfa8cb54ebb3b0

Suspecting https://codereview.chromium.org/2128093003 from changelog.

@cbiesinger: Please help in re-assigining if this is not related to your change.

Attaching screenshot for reference.
 
Expected_Drive.png
154 KB View Download
Actual_Drive.png
155 KB View Download
Labels: ReleaseBlock-Stable OS-Mac
Able to reproduce the issue on Mac 10.11.5 using chrome version 54.0.2800.0.

Adding stable blocker as this is recent regression.

Thanks,
Cc: szager@chromium.org
I'll look into this but I suspect that my patch only uncovered an underlying issue, perhaps relating to one of Stefan's changes.
Cc: ranjitkan@chromium.org
Just to update, issue is still observed on MAC 10.11.5, Ubuntu 14.04 for chrome version 54.0.2808.0. 

@ cbiesinger: Gentle Ping.!, Request you to please provide an update on it as per your above comment. Please help us to reassign if this is not with respect to your change.

Thanks.!
Cc: cbiesin...@chromium.org skobes@chromium.org e...@chromium.org
Owner: szager@chromium.org
If I disable PaintLayerScrollableArea::DelayScrollPositionClampScope (by commenting it out) this bug disappears, so this sounds a lot more like a scrolling bug.
(and of course, my change triggered this because we happened to overinvalidate things, so that covered it up)

Comment 6 by ajha@chromium.org, Aug 3 2016

Cc: -szager@chromium.org
szager@: Can we get an update on this issue.

Thank you!
Blockedon: 633212
This may be the same underlying issue as  bug 633212  which I'm now investigating as a flexbox bug
Owner: cbiesin...@chromium.org
It looks like my patch for that bug does fix this one, too. Sorry Stefan!
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e929360ccd93a1e98db3b19929a68d1ed4fa4d5d

commit e929360ccd93a1e98db3b19929a68d1ed4fa4d5d
Author: cbiesinger <cbiesinger@chromium.org>
Date: Fri Aug 05 19:17:26 2016

[css-flexbox] Have to use forceChildLayout to force layout

The flexbox code was assuming that calling layoutIfNeeded()
will do a full layout if needsLayout() is true.

However, that is not the case. It is possible for needsLayout()
to return true because posChildNeedsLayout is true, in which
case calling layout() will not do the full layout that the
flexbox code expects. Instead, call forceChildLayout to
ensure that layout happens.

R=eae@chromium.org,dgrogan@chromium.org
CC=szager@chromium.org
BUG= 633212 , 629491 

Review-Url: https://codereview.chromium.org/2219433002
Cr-Commit-Position: refs/heads/master@{#410135}

[add] https://crrev.com/e929360ccd93a1e98db3b19929a68d1ed4fa4d5d/third_party/WebKit/LayoutTests/css3/flexbox/bug633212.html
[modify] https://crrev.com/e929360ccd93a1e98db3b19929a68d1ed4fa4d5d/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

Labels: Merge-Request-53 Merge-Request-52
Status: Fixed (was: Assigned)
Are we planning a 52 point release? Might be nice to take this patch too. It seems this specific version of the bug does not reproduce on 52 but  bug 633212 's testcase does fail on 52, and the patch is very safe.

Comment 11 by dimu@chromium.org, Aug 6 2016

Labels: -Merge-Request-52 Merge-Review-52 Hotlist-Merge-Review
[Automated comment] Request affecting a post-stable build (M52), manual review required.

Comment 12 by dimu@chromium.org, Aug 6 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 8 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92a2a1f5852a882ef9671a8d792313dc670ac899

commit 92a2a1f5852a882ef9671a8d792313dc670ac899
Author: Christian Biesinger <cbiesinger@chromium.org>
Date: Mon Aug 08 02:35:26 2016

[css-flexbox] Have to use forceChildLayout to force layout

The flexbox code was assuming that calling layoutIfNeeded()
will do a full layout if needsLayout() is true.

However, that is not the case. It is possible for needsLayout()
to return true because posChildNeedsLayout is true, in which
case calling layout() will not do the full layout that the
flexbox code expects. Instead, call forceChildLayout to
ensure that layout happens.

R=eae@chromium.org,dgrogan@chromium.org
CC=szager@chromium.org
BUG= 633212 , 629491 

Review-Url: https://codereview.chromium.org/2219433002
Cr-Commit-Position: refs/heads/master@{#410135}
(cherry picked from commit e929360ccd93a1e98db3b19929a68d1ed4fa4d5d)

Review URL: https://codereview.chromium.org/2224833002 .

Cr-Commit-Position: refs/branch-heads/2785@{#519}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[add] https://crrev.com/92a2a1f5852a882ef9671a8d792313dc670ac899/third_party/WebKit/LayoutTests/css3/flexbox/bug633212.html
[modify] https://crrev.com/92a2a1f5852a882ef9671a8d792313dc670ac899/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp

Comment 14 Deleted

Re #10, as of now there is no M52 refresh release plan. But we can surely take this change in if we cut new M52 stable rc. Does that sound good?
Labels: TE-Verified-54.0.2823.0 TE-Verified-M54 TE-Verified-54.0.2824.0
Rechecked this on chrome version 54.0.2824.0 on Windows 7 and MAC 10.11.6, 54.0.2423.0 on Ubuntu 14.04. fix is working as intended.

Adding TE-Verified labels.

Thanks.!
Labels: TE-Verified-M53 TE-Verified-53.0.2785.0
Rechecked this on chrome version 53.0.2785.57.0 on Windows 7, Ubuntu 14.04 and MAC 10.11.6, fix is working as intended.

Adding TE-Verified labels.

Thanks.!
Labels: -TE-Verified-53.0.2785.0 TE-Verified-53.0.2785.57
Cc: abodenha@chromium.org
 Issue 623019  has been merged into this issue.

Sign in to add a comment