New issue
Advanced search Search tips

Issue 629479 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Aug 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocked on:
issue 626103



Sign in to add a comment

CQ attempts to compile CL on a revision before the referenced dependency was committed

Project Member Reported by jochen@chromium.org, Jul 19 2016

Issue description

on https://codereview.chromium.org/2162443002 I tried to land a CL with a dependency, and while the dependency was already committed, the CQ attempted to compile my CL on top of a revision before that dependency. That failed obviously.

Since the CQ is already refusing the even start trying before the dependency landed (issue 629478), why not make sure that the dependency is part of the tree that it tries to build from.
 
Blockedon: 626103
Cc: machenb...@chromium.org
Status: Available (was: Untriaged)
That's a fair report. CQ figures out CL dependency from codereview, and codereview considers dependency satisfied if previous CL has been closed (I think, not 100% sure). Because v8 and chromium use contraption to add footers to commit messages, it's hard to fix this in CQ + Rietveld.

But fear not, issue 626103 would decrease the likelyhood of this problem significantly.
Labels: -Restrict-View-Google
Note, that strictly speaking there is still a race condition because not all git mirrors are consistent, hence it'd still be possible that some bots won't see latest HEAD even without the contraption which issue 626103 is aiming to remove
Labels: Pri-2
Labels: Type-Feature
Components: -Infra>CQ Infra>Platform>CQdaemon

Comment 7 by efoo@chromium.org, Aug 31 2017

Components: Infra>Platform>CQ

Comment 8 by efoo@chromium.org, Aug 31 2017

Components: -Infra>Platform>CQdaemon
Project Member

Comment 9 by sheriffbot@chromium.org, Aug 31

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
No idea if this is an issue any longer in gerrit...
Status: WontFix (was: Untriaged)
Yep, it's not a problem in Gerrit.

Sign in to add a comment