New issue
Advanced search Search tips

Issue 629459 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 355145



Sign in to add a comment

CredentialManagerBrowserTest.SaveViaAPIAndAutofill and CredentialManagerBrowserTest.UpdateViaAPIAndAutofill flaky

Project Member Reported by grt@chromium.org, Jul 19 2016

Issue description

Flakes on Linux Tests (dbg)(1), Mac10.9 Tests (dbg), Win7 (32) Tests, and Win7 Tests (dbg)(1). See https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=CredentialManagerBrowserTest.*
 

Comment 1 by vabr@chromium.org, Jul 19 2016

Blocking: 355145
Labels: Hotlist-TechnicalDebt
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76000f462a4396ff89435f1a68da2525d26462d6

commit 76000f462a4396ff89435f1a68da2525d26462d6
Author: grt <grt@chromium.org>
Date: Tue Jul 19 12:55:02 2016

Disable flaky CredentialManagerBrowserTest.SaveViaAPIAndAutofill and UpdateViaAPIAndAutofill.

BUG= 629459 
TBR=vasilii@chromium.org

Review-Url: https://codereview.chromium.org/2157343002
Cr-Commit-Position: refs/heads/master@{#406258}

[modify] https://crrev.com/76000f462a4396ff89435f1a68da2525d26462d6/chrome/browser/password_manager/credential_manager_browsertest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd8c0b41b62492a20846f4068cab2b5309df1834

commit cd8c0b41b62492a20846f4068cab2b5309df1834
Author: vasilii <vasilii@chromium.org>
Date: Thu Jul 21 14:33:37 2016

Fix CredentialManagerBrowserTest.UpdateViaAPIAndAutofill flakiness.

BUG= 628377 , 629459 

Review-Url: https://codereview.chromium.org/2169883002
Cr-Commit-Position: refs/heads/master@{#406845}

[modify] https://crrev.com/cd8c0b41b62492a20846f4068cab2b5309df1834/chrome/browser/password_manager/credential_manager_browsertest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b853237943857563d2ef66b3dc83bb47c72389d8

commit b853237943857563d2ef66b3dc83bb47c72389d8
Author: vasilii <vasilii@chromium.org>
Date: Fri Jul 22 07:53:02 2016

Place WaitForPasswordStore() before checking the store/prompt in CredentialManagerBrowserTest*

BUG= 629459 

Review-Url: https://codereview.chromium.org/2166823004
Cr-Commit-Position: refs/heads/master@{#407094}

[modify] https://crrev.com/b853237943857563d2ef66b3dc83bb47c72389d8/chrome/browser/password_manager/credential_manager_browsertest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03e0adf02ebc86106a0a94444407c738873f6cb9

commit 03e0adf02ebc86106a0a94444407c738873f6cb9
Author: vasilii <vasilii@chromium.org>
Date: Fri Jul 22 11:52:58 2016

Fix flaky CredentialManagerBrowserTest.SaveViaAPIAndAutofill.

BUG= 629459 

Review-Url: https://codereview.chromium.org/2169233003
Cr-Commit-Position: refs/heads/master@{#407134}

[modify] https://crrev.com/03e0adf02ebc86106a0a94444407c738873f6cb9/chrome/browser/password_manager/credential_manager_browsertest.cc

Comment 6 by vabr@chromium.org, Jul 25 2016

Cc: -vabr@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ae14e9e622edd6d991dd0899c892ef8dac2cd64

commit 2ae14e9e622edd6d991dd0899c892ef8dac2cd64
Author: vasilii <vasilii@chromium.org>
Date: Mon Jul 25 15:36:21 2016

Fix flaky CredentialManagerBrowserTest.AccountChooserWithOldCredentialAndNavigation

The flakiness caused by not waiting for the password store to reply with the results.

BUG= 629459 

Review-Url: https://codereview.chromium.org/2177213002
Cr-Commit-Position: refs/heads/master@{#407482}

[modify] https://crrev.com/2ae14e9e622edd6d991dd0899c892ef8dac2cd64/chrome/browser/password_manager/credential_manager_browsertest.cc

Status: Fixed (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9728e1c00831de324f4b65643b5f837d74785590

commit 9728e1c00831de324f4b65643b5f837d74785590
Author: vasilii <vasilii@chromium.org>
Date: Fri Apr 21 14:14:37 2017

Fix flaky CredentialManagerBrowserTest.AccountChooserWithOldCredentialAndNavigation and StoreSavesPSLMatchedCredential

navigator.credentials.get is dispatched via Mojo from renderer to browser. The test should wait for this call to be processed. Here is an example of the failure.

[ RUN      ] CredentialManagerBrowserTest.AccountChooserWithOldCredentialAndNavigation
[38019:771:0421/041104.591122:WARNING:ipc_message_attachment_set.cc(49)] MessageAttachmentSet destroyed with unconsumed attachments: 0/1
[38019:59655:0421/041105.028129:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /favicon.ico
../../chrome/browser/password_manager/credential_manager_browsertest.cc:80: Failure
Value of: PasswordsModelDelegateFromWebContents(WebContents())->GetState()
  Actual: 3
Expected: password_manager::ui::CREDENTIAL_REQUEST_STATE
Which is: 4

BUG= 629459 

Review-Url: https://codereview.chromium.org/2831343002
Cr-Commit-Position: refs/heads/master@{#466326}

[modify] https://crrev.com/9728e1c00831de324f4b65643b5f837d74785590/chrome/browser/password_manager/credential_manager_browsertest.cc

Sign in to add a comment