New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 629454 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Use-of-uninitialized-value in containsCoincidence

Project Member Reported by ClusterFuzz, Jul 19 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5240805250039808

Fuzzer: libfuzzer_skia_pathop_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  containsCoincidence
  insertCoincidence
  SkOpCoincidence::mark
  
Recommended Security Severity: Medium


Minimized Testcase (0.42 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97t7HzkQt287MI2HZm_TDCjYWIuUg8cHB2xqTihoSro_K6SZArEFa_wUVOOMD0C4FF8auF6VLUkgxVpmfhmmxuzXyqwtOT6XPhlpnOcsyRNFWbqInzADEFbk46em3FWs7gZg7Nsq4xNR_1xTC-s_8F_wH2bGA?testcase_id=5240805250039808

Filer: mmoroz

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 

Comment 1 by mmoroz@chromium.org, Jul 19 2016

Cc: reed@chromium.org
Components: Internals>Skia
Labels: Pri-2
Owner: caryclark@chromium.org
Somewhat similar to  bug 623072 .
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 19 2016

Labels: -Pri-2 Pri-1
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 19 2016

Status: Assigned (was: Available)
Cc: caryclark@chromium.org
Owner: caryclark@google.com
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 19 2016

The following revision refers to this bug:
  https://skia.googlesource.com/skia.git/+/1493b9772d6fad455a222ec6f242903128e049a0

commit 1493b9772d6fad455a222ec6f242903128e049a0
Author: caryclark <caryclark@google.com>
Date: Tue Jul 19 18:29:14 2016

fix fuzzer

Previous spans always have a valid next pointer. The final span does not.
Change the test for a valid link to take into consideration whether
the links are chased forwards or backwards.

TBR=reed@google.com
BUG= 629454 
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2166543002

Review-Url: https://codereview.chromium.org/2166543002

[modify] https://crrev.com/1493b9772d6fad455a222ec6f242903128e049a0/src/pathops/SkOpSpan.cpp
[modify] https://crrev.com/1493b9772d6fad455a222ec6f242903128e049a0/tests/PathOpsOpTest.cpp

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 19 2016

The following revision refers to this bug:
  https://skia.googlesource.com/skia.git/+/1493b9772d6fad455a222ec6f242903128e049a0

commit 1493b9772d6fad455a222ec6f242903128e049a0
Author: caryclark <caryclark@google.com>
Date: Tue Jul 19 18:29:14 2016

fix fuzzer

Previous spans always have a valid next pointer. The final span does not.
Change the test for a valid link to take into consideration whether
the links are chased forwards or backwards.

TBR=reed@google.com
BUG= 629454 
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2166543002

Review-Url: https://codereview.chromium.org/2166543002

[modify] https://crrev.com/1493b9772d6fad455a222ec6f242903128e049a0/src/pathops/SkOpSpan.cpp
[modify] https://crrev.com/1493b9772d6fad455a222ec6f242903128e049a0/tests/PathOpsOpTest.cpp

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 19 2016

The following revision refers to this bug:
  https://skia.googlesource.com/skia.git/+/1493b9772d6fad455a222ec6f242903128e049a0

commit 1493b9772d6fad455a222ec6f242903128e049a0
Author: caryclark <caryclark@google.com>
Date: Tue Jul 19 18:29:14 2016

fix fuzzer

Previous spans always have a valid next pointer. The final span does not.
Change the test for a valid link to take into consideration whether
the links are chased forwards or backwards.

TBR=reed@google.com
BUG= 629454 
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2166543002

Review-Url: https://codereview.chromium.org/2166543002

[modify] https://crrev.com/1493b9772d6fad455a222ec6f242903128e049a0/src/pathops/SkOpSpan.cpp
[modify] https://crrev.com/1493b9772d6fad455a222ec6f242903128e049a0/tests/PathOpsOpTest.cpp

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10dc160d9183452ce57e7d9561d28965cb6116af

commit 10dc160d9183452ce57e7d9561d28965cb6116af
Author: skia-deps-roller <skia-deps-roller@chromium.org>
Date: Tue Jul 19 19:50:19 2016

Roll src/third_party/skia/ c7b4b2849..1493b9772 (4 commits).

https://chromium.googlesource.com/skia.git/+log/c7b4b28496a9..1493b9772d6f

$ git log c7b4b2849..1493b9772 --date=short --no-merges --format='%ad %ae %s'
2016-07-19 caryclark fix fuzzer
2016-07-19 msarett Disable qcms on build for Android framework
2016-07-19 msarett Enable libjpeg-turbo features
2016-07-19 fmenozzi Clarify GrGradientEffect key enum

BUG= 629454 

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review-Url: https://codereview.chromium.org/2163743002
Cr-Commit-Position: refs/heads/master@{#406354}

[modify] https://crrev.com/10dc160d9183452ce57e7d9561d28965cb6116af/DEPS

Project Member

Comment 9 by ClusterFuzz, Jul 20 2016

ClusterFuzz has detected this issue as fixed in range 406333:406477.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5240805250039808

Fuzzer: libfuzzer_skia_pathop_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  containsCoincidence
  insertCoincidence
  SkOpCoincidence::mark
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_msan&range=406010:406169
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_msan&range=406333:406477

Minimized Testcase (0.42 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96drs9mX3ggUfYPV593KT_u0lcBLiVskMta-6fxaePUPrvWI2bJO7qvjuCfMJnhvvxg_OIKNbhFT7pjbppUZtFrP-Gz2PJW8zaajDVyeWJIvSW_uneO2hkXYgSNC8iIf3fzZHjy6mdUWAEx16SSV9dJQ66EBA?testcase_id=5240805250039808

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Jul 20 2016

ClusterFuzz has detected this issue as fixed in range 406333:406477.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5240805250039808

Fuzzer: libfuzzer_skia_pathop_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  containsCoincidence
  insertCoincidence
  SkOpCoincidence::mark
  
Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_msan&range=406010:406169
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_msan&range=406333:406477

Minimized Testcase (0.42 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96drs9mX3ggUfYPV593KT_u0lcBLiVskMta-6fxaePUPrvWI2bJO7qvjuCfMJnhvvxg_OIKNbhFT7pjbppUZtFrP-Gz2PJW8zaajDVyeWJIvSW_uneO2hkXYgSNC8iIf3fzZHjy6mdUWAEx16SSV9dJQ66EBA?testcase_id=5240805250039808

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 11 by ClusterFuzz, Jul 20 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 12 by sheriffbot@chromium.org, Jul 20 2016

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ClusterFuzz Clusterfuzz Security_Impact-Beta M-54
Project Member

Comment 14 by sheriffbot@chromium.org, Oct 26 2016

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment