New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 629451 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

12.2%-7887.7% regression in system_health.memory_mobile at 405985:406014

Project Member Reported by petrcermak@chromium.org, Jul 19 2016

Issue description

See the link to graphs below.
 
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jul 19 2016

Cc: picksi@chromium.org
Owner: picksi@chromium.org

=== Auto-CCing suspected CL author picksi@chromium.org ===

Hi picksi@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Reland of -enable GPU Rasterization for content with any author defined viewport. (patchset #1 id:1 of https://codereview.chromium.org/2155193002/ )
Author  : picksi
Commit description:
  
Reason for revert:
CL falsely blamed for red layout test. Relanding it.

Original issue's description:
> Revert of -enable GPU Rasterization for content with any author defined viewport. (patchset #1 id:1 of https://codereview.chromium.org/2154193002/ )
>
> Reason for revert:
> Relanding this has potentially caused a layout test to fail (https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/8452). The build sheriff has asked me to revert it.
>
> Adding aelias & vmiura so they can do a more refined revert on their return from vacation.
>
> Original issue's description:
> > Reland of -enable GPU Rasterization for content with any author defined viewport. (patchset #1 id:1 of https://codereview.chromium.org/2156553002/ )
> >
> > Reason for revert:
> > Reverting change now that we have collected data from telemetry.
> >
> > Original issue's description:
> > > Revert of Re-enable GPU Rasterization for content with any author defined viewport. (patchset #2 id:20001 of https://codereview.chromium.org/2097413003/ )
> > >
> > > Reason for revert:
> > > This has caused an unexpectedly large regression in overall PSS (about 5MB, graph here: https://chromeperf.appspot.com/report?sid=0b072725c25637efb0d3a44383da1e24e42bbb3740a00505e4040af2173423b0&start_rev=402061&end_rev=402790).
> > > The owners are both OOO and this is blocking Android release. This has already been reverted in the release branch but our infrastructure cannot gather data from the branch to confirm that the revert has had the intended result.
> > >
> > > This revert will allow us to confirm that this CL was the cause of the regression. Once confirmed (or otherwise) via telemetry dashboards this revert will be re-reverted.
> > >
> > > Original issue's description:
> > > > Re-enable GPU Rasterization for content with any author defined viewport.
> > > >
> > > > BUG= 591179 
> > > >
> > > > Committed: https://crrev.com/a017b667a53b3ee5f8bc630be98c37ebf53a2339
> > > > Cr-Commit-Position: refs/heads/master@{#402702}
> > >
> > > TBR=aelias@chromium.org,chrishtr@chromium.org,vmiura@chromium.org
> > > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > > BUG= 591179 
> > >
> > > Committed: https://crrev.com/10a77702aa0490dfaaa6e354151b24b738474fb4
> > > Cr-Commit-Position: refs/heads/master@{#405750}
> >
> > TBR=aelias@chromium.org,chrishtr@chromium.org,vmiura@chromium.org,primiano@chromium.org
> > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > BUG= 591179 
> >
> > Committed: https://crrev.com/5f19720ded2369857bee408ab48e11e7b5d28f7b
> > Cr-Commit-Position: refs/heads/master@{#405974}
>
> TBR=aelias@chromium.org,chrishtr@chromium.org,vmiura@chromium.org,primiano@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 591179 
>
> Committed: https://crrev.com/1ce44d25cbafd74f034c30ddfd4b0f3caed9978d
> Cr-Commit-Position: refs/heads/master@{#405983}

TBR=aelias@chromium.org,chrishtr@chromium.org,vmiura@chromium.org,primiano@chromium.org,alexclarke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 591179 

Review-Url: https://codereview.chromium.org/2161663002
Cr-Commit-Position: refs/heads/master@{#406004}
Commit  : c67c6db688d379d0a5d2eb7cdd6853e7ce8da281
Date    : Mon Jul 18 15:57:52 2016


===== TESTED REVISIONS =====
Revision         Mean      Std Dev  N  Good?
chromium@405984  187940    0.0      5  good
chromium@405999  189116    2629.62  5  good
chromium@406003  187940    0.0      5  good
chromium@406004  14802437  468937   5  bad    <--
chromium@406005  14592722  574329   5  bad
chromium@406007  14802437  468937   5  bad
chromium@406014  15014504  3220.61  5  bad

Bisect job ran on: android_s5_perf_bisect
Bug ID: 629451

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_mobile
Test Metric: load_media-memory:chrome:all_processes:reported_by_chrome:skia:effective_size_avg/load_media_flickr
Relative Change: 7888.99%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_bisect/builds/813
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9006717039560173904


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5907723577720832

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 4 by picksi@chromium.org, Jul 20 2016

Status: WontFix (was: Assigned)
This is expected. I reverted a rendering speed-up to determine its impact on memory use. This alert caught turning the CL back on again.
Labels: SystemHealth-Sheriff
Labels: -Performance-Sheriff

Sign in to add a comment