New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 629438 link

Starred by 5 users
Status: Verified
Owner:
fukino@chromium.org
Closed: Dec 2016
Cc:
█ mitsuji@chromium.org
weifangsun@chromium.org
fukino@chromium.org
dbeam@chromium.org
tbuck...@chromium.org
█ jonnymack@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Port storage manager to MD Settings.

Project Member Reported by fukino@chromium.org, Jul 19 2016 
We implemented storage manager only in old settings.
We need to port the storage manager to MD settings not to block the release of MD settings for Chrome OS.

Comment 1 by dbeam@chromium.org, Jul 19 2016

Cc: tbuck...@chromium.org

Comment 2 by fukino@chromium.org, Aug 31 2016

Labels: -M-54 M-55

Comment 3 by weifangsun@chromium.org, Sep 23 2016

Cc: weifangsun@chromium.org

Comment 4 by fukino@chromium.org, Sep 30 2016

Cc: fukino@chromium.org
 Issue 645881  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/519e0e2c9424ec070416451b0254123bdc125545

commit 519e0e2c9424ec070416451b0254123bdc125545
Author: fukino <fukino@chromium.org>
Date: Thu Oct 06 01:43:06 2016

Port storage manager to MD settings.

This CL adds an "Storage management" item on MD settings/Device, and it shows the size of each storage item.
C++ side implementation is basically copied from old setting's one.
(I don't share the implementation assuming that the old one will be removed.)

Following are not implemented.
- The UI design is temporary.
- metrics/tests will be added separately.

BUG= 629438 
TEST=with the flag "--enable-md-storage-manager=1",  manually tested that chrome://md-settings/storage shows the same items/values with chrome://settings/storage
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2348913002
Cr-Commit-Position: refs/heads/master@{#423386}

[modify] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/app/settings_strings.grdp
[modify] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/browser/about_flags.cc
[modify] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/browser/resources/settings/device_page/compiled_resources2.gyp
[modify] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/browser/resources/settings/device_page/device_page.html
[modify] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/browser/resources/settings/device_page/device_page.js
[add] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/browser/resources/settings/device_page/drive_cache_dialog.html
[add] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/browser/resources/settings/device_page/drive_cache_dialog.js
[add] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/browser/resources/settings/device_page/storage.html
[add] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/browser/resources/settings/device_page/storage.js
[modify] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/browser/resources/settings/icons.html
[modify] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/browser/ui/webui/settings/chromeos/device_storage_handler.cc
[add] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/browser/ui/webui/settings/chromeos/device_storage_handler.h
[modify] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/browser/ui/webui/settings/md_settings_ui.cc
[modify] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chromeos/chromeos_switches.cc
[modify] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chromeos/chromeos_switches.h
[modify] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/tools/metrics/histograms/histograms.xml

Comment 6 by weifangsun@chromium.org, Oct 11 2016 

Mock Links for reference:
https://folio.googleplex.com/chrome-ux/mocks/362-arc++/18_md-storage/03
https://folio.googleplex.com/chrome-ux/mocks/362-arc++/22_md-disk-full/01#%3Fz=fit

@jonnymack, @fukino wanted to double-check on this feature - Was it approved by UI Review?

Comment 8 by weifangsun@chromium.org, Oct 11 2016 

Great, thanks for the update!
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e7019f515db78dc52d33fb3fbd283915e0d3985

commit 4e7019f515db78dc52d33fb3fbd283915e0d3985
Author: fukino <fukino@chromium.org>
Date: Tue Oct 25 06:46:43 2016

MD Settings: Update the design of storage manager.

This CL updates the layout/colors to match the following latest spec:
https://folio.googleplex.com/md-storage-management-spec

BUG= 629438 
TEST=manually confirmed.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2435033003
Cr-Commit-Position: refs/heads/master@{#427291}

[modify] https://crrev.com/4e7019f515db78dc52d33fb3fbd283915e0d3985/chrome/browser/resources/settings/device_page/storage.html
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/519e0e2c9424ec070416451b0254123bdc125545

commit 519e0e2c9424ec070416451b0254123bdc125545
Author: fukino <fukino@chromium.org>
Date: Thu Oct 06 01:43:06 2016

Port storage manager to MD settings.

This CL adds an "Storage management" item on MD settings/Device, and it shows the size of each storage item.
C++ side implementation is basically copied from old setting's one.
(I don't share the implementation assuming that the old one will be removed.)

Following are not implemented.
- The UI design is temporary.
- metrics/tests will be added separately.

BUG= 629438 
TEST=with the flag "--enable-md-storage-manager=1",  manually tested that chrome://md-settings/storage shows the same items/values with chrome://settings/storage
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2348913002
Cr-Commit-Position: refs/heads/master@{#423386}

[modify] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/app/settings_strings.grdp
[modify] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/browser/about_flags.cc
[modify] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/browser/resources/settings/device_page/compiled_resources2.gyp
[modify] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/browser/resources/settings/device_page/device_page.html
[modify] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/browser/resources/settings/device_page/device_page.js
[add] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/browser/resources/settings/device_page/drive_cache_dialog.html
[add] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/browser/resources/settings/device_page/drive_cache_dialog.js
[add] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/browser/resources/settings/device_page/storage.html
[add] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/browser/resources/settings/device_page/storage.js
[modify] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/browser/resources/settings/icons.html
[modify] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/browser/ui/webui/settings/chromeos/device_storage_handler.cc
[add] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/browser/ui/webui/settings/chromeos/device_storage_handler.h
[modify] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chrome/browser/ui/webui/settings/md_settings_ui.cc
[modify] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chromeos/chromeos_switches.cc
[modify] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/chromeos/chromeos_switches.h
[modify] https://crrev.com/519e0e2c9424ec070416451b0254123bdc125545/tools/metrics/histograms/histograms.xml

Comment 11 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Comment 12 by steve...@chromium.org, Nov 16 2016 

What is the status of this?

Comment 13 by maxwe...@gmail.com, Nov 16 2016 

I don't think I have any ownership of issue tracking, but I have seen this
implemented in latest betas.

Thanks,

Max Bloch

Comment 14 by dpa...@chromium.org, Nov 17 2016

Labels: Proj-MaterialDesign-WebUI

Comment 15 by fukino@chromium.org, Nov 17 2016

Labels: -M-55 M-57
Re: #12
The MD storage manager was implemented, but it is behind a flag.
I'm going to flip the flag after the M56 branch cut, but let me know if it should be done before the branch cut.
Project Member

Comment 16 by bugdroid1@chromium.org, Nov 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48f133740b2b18a790e54c843db8fbfc6b57ddfe

commit 48f133740b2b18a790e54c843db8fbfc6b57ddfe
Author: fukino <fukino@chromium.org>
Date: Fri Nov 25 06:17:43 2016

Enable MD storage manager by default.

The storage manager in MD settings was behind a flag.
As M56 has been branched, it should be a good timing to flip the flag and remove the code related to the flag.

BUG= 629438 
TEST=manually tested
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2517083002
Cr-Commit-Position: refs/heads/master@{#434441}

[modify] https://crrev.com/48f133740b2b18a790e54c843db8fbfc6b57ddfe/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/48f133740b2b18a790e54c843db8fbfc6b57ddfe/chrome/browser/about_flags.cc
[modify] https://crrev.com/48f133740b2b18a790e54c843db8fbfc6b57ddfe/chrome/browser/resources/settings/device_page/device_page.html
[modify] https://crrev.com/48f133740b2b18a790e54c843db8fbfc6b57ddfe/chrome/browser/resources/settings/device_page/device_page.js
[modify] https://crrev.com/48f133740b2b18a790e54c843db8fbfc6b57ddfe/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/48f133740b2b18a790e54c843db8fbfc6b57ddfe/chromeos/chromeos_switches.cc
[modify] https://crrev.com/48f133740b2b18a790e54c843db8fbfc6b57ddfe/chromeos/chromeos_switches.h

Comment 17 by fukino@chromium.org, Dec 1 2016

Status: Fixed (was: Started)

Comment 18 by sdantul...@chromium.org, Dec 13 2016

Status: Verified (was: Fixed)
Verified on ChromeOS 9077.0.0, 57.0.2948.0
►

Sign in to add a comment