New issue
Advanced search Search tips

Issue 629433 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Storage manager: Add UMA stats.

Project Member Reported by fukino@chromium.org, Jul 19 2016

Issue description

Record user actions when:
- User clicks the storage management button in chrome://settings
- User clicks following links on storage manager.
  - "Downloads" to open Downloads directory by Files app
  - "Offline files" to clear Google Drive offline files.
  - "Browsing data" to open the dialog to clear browsing data.
  - "Android storage" to open Android internal storage settings.
  - "Other users" to open accounts settings. 
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 19 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e50b2670f3ad15f999eb4881125dfb90d45b62e5

commit e50b2670f3ad15f999eb4881125dfb90d45b62e5
Author: fukino <fukino@chromium.org>
Date: Wed Jul 20 17:16:27 2016

Add UMA stats for storage manager for Chrome OS.

Record user actions when:
- User clicks the storage management button in chrome://settings
- User clicks links to manage storage items on storage manager

BUG= 629433 
TEST=manually confirmed that expected logs were recorded in chrome://user-actions.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2165503002
Cr-Commit-Position: refs/heads/master@{#406595}

[modify] https://crrev.com/e50b2670f3ad15f999eb4881125dfb90d45b62e5/chrome/browser/resources/options/browser_options.js
[modify] https://crrev.com/e50b2670f3ad15f999eb4881125dfb90d45b62e5/chrome/browser/resources/options/chromeos/storage_manager.js
[modify] https://crrev.com/e50b2670f3ad15f999eb4881125dfb90d45b62e5/tools/metrics/actions/actions.xml

Comment 3 by fukino@chromium.org, Jul 20 2016

Labels: -M-54 Merge-Request-53 M-53
The feature itself will be shipped with M53, so I'd like to merge this CL (adding UMA stats) to M53 as well for better understanding of the new feature.

Comment 4 by dimu@google.com, Jul 21 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 22 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a12e7d86f5fe414e0e88744655de89385f729b1c

commit a12e7d86f5fe414e0e88744655de89385f729b1c
Author: Naoki Fukino <fukino@chromium.org>
Date: Fri Jul 22 03:04:53 2016

Add UMA stats for storage manager for Chrome OS.

Record user actions when:
- User clicks the storage management button in chrome://settings
- User clicks links to manage storage items on storage manager

BUG= 629433 
TEST=manually confirmed that expected logs were recorded in chrome://user-actions.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=stevenjb@chromium.org,rkaplow@chromium.org

Review-Url: https://codereview.chromium.org/2165503002
Cr-Commit-Position: refs/heads/master@{#406595}
(cherry picked from commit e50b2670f3ad15f999eb4881125dfb90d45b62e5)

Review URL: https://codereview.chromium.org/2175533002 .

Cr-Commit-Position: refs/branch-heads/2785@{#280}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/a12e7d86f5fe414e0e88744655de89385f729b1c/chrome/browser/resources/options/browser_options.js
[modify] https://crrev.com/a12e7d86f5fe414e0e88744655de89385f729b1c/chrome/browser/resources/options/chromeos/storage_manager.js
[modify] https://crrev.com/a12e7d86f5fe414e0e88744655de89385f729b1c/tools/metrics/actions/actions.xml

Comment 6 by fukino@chromium.org, Jul 22 2016

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Sign in to add a comment