New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 629408 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Thumbnails are not clickable in print preview.

Reported by lpa...@etouch.net, Jul 19 2016

Issue description

Chrome Version: 54.0.2799.0 (Official Build)8acb9d5f2f71c3df8e64b13ee321a9d194e89785-refs/heads/master@{#405947} 32/64-bit. 
OS: Windows (7,8,8.1,10), Mac (10.10.5, 10.11.4), Linux (14.04 LTS)

Steps:
1. Launch chrome and navigate to a new tab page.
2. Give print command (Ctrl+P) on the webpage.
3. Click on the thumbnail in print preview.

Actual: Thumbnails are not clickable.

Expected: On clicking the thumbnail, it should navigate to the hyperlink webpage. 

This is a regression issue broken in M-54, will soon update the other info.
 
Actual_PP.mp4
356 KB View Download
Expected_PP.mp4
414 KB View Download

Comment 1 by lpa...@etouch.net, Jul 19 2016

Cc: jbroman@chromium.org
Labels: hasbisect
Owner: xyzzyz@chromium.org
Status: Assigned (was: Unconfirmed)
Manual Regression range:
Good Build:54.0.2789.0
Bad Build: 54.0.2790.0

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/7b4b8e2a497c943c4e4e3daad85660849e942b30..56c1f9cdc298320967bc3924d963f37ff202457e?pretty=fuller&n=100

Suspecting: r403936 ?

Please re-assign if your change is not the cause of this issue.
Labels: ReleaseBlock-Beta
Adding RB Label as this is a recent Regression. Please remove if not required.
Thank You.

Comment 3 by xyzzyz@chromium.org, Jul 19 2016

Owner: ----
Status: Untriaged (was: Assigned)
This is clearly and obviously unrelated to my CL. I'm not working on Chromium browser itself, and I have no idea who I should reassign it to.

In any case, in my opinion the "expected" behaviour is silly, and the "regression" is how it should behave.
Labels: -hasbisect Needs-Bisect

Comment 5 by lpa...@etouch.net, Jul 20 2016

Cc: -jbroman@chromium.org
Labels: -Needs-Bisect
Owner: jbroman@chromium.org
Status: Assigned (was: Untriaged)
With response to comment #4:
Re-bisected on other machine, getting same bisect range i.e.
https://chromium.googlesource.com/chromium/src/+log/7b4b8e2a497c943c4e4e3daad85660849e942b30..56c1f9cdc298320967bc3924d963f37ff202457e?pretty=fuller&n=100

Suspecting: r403938 ?

@jbroman: Can you please take a look..!!

Components: -UI>Browser>PrintPreview Internals>Skia>PDF
Owner: reed@google.com
This bisects to https://skia.googlesource.com/skia/+/41c27e15ec2740850700f1b82038ce0f7a632481, which was in the Skia roll.

It seems that returning null for those pictures is causing the clickable regions to be lost on their way to the PDF. (While printing the new tab page is perhaps a little silly, this also breaks -- but not all -- other links, like the Google logo on a search results page.)

Comment 7 by reed@google.com, Jul 20 2016

Cc: mtklein@chromium.org halcanary@chromium.org
I suspect that accidental enabling of SkRecordNoopSaveRestores(record) in SkRecordOpts.cpp, just like that other perf bug.  

I'm pretty sure that peephole pass is seeing the drawAnnotation() as a non-drawing op that it can elide when it's the only thing in a save-restore block.  That's from looking at the ", 0" in SkRecords for DrawAnnotation, which says "I don't draw, I don't have text, and I don't hold an image".
mtklein@, does that mean there's a trivial fix?
The 2 minute fix is to turn the peephole back off.

The 20 minute fix is to write a unit test that drawAnnotation() works with this peephole and then make it pass.

Comment 11 by reed@google.com, Jul 20 2016

Posted a CL that re-disables the peephole optimization. The null-return change does not seem to be the issue.

Project Member

Comment 12 by bugdroid1@chromium.org, Jul 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe7bde006ea6d893c115aae0747d25e9f52fd43c

commit fe7bde006ea6d893c115aae0747d25e9f52fd43c
Author: skia-deps-roller <skia-deps-roller@chromium.org>
Date: Wed Jul 20 20:47:15 2016

Roll src/third_party/skia/ f2944815e..e499adf32 (5 commits).

https://chromium.googlesource.com/skia.git/+log/f2944815e5e4..e499adf328bd

$ git log f2944815e..e499adf32 --date=short --no-merges --format='%ad %ae %s'
2016-07-20 jvanverth Use dFdx in Vulkan to address distance field issues.
2016-07-20 mtklein Tune linear->sRGB constants to round-trip all bytes.
2016-07-20 msarett Refactor parsing and storage of SkGammas
2016-07-20 reed re-disable save/restore peephole optimization
2016-07-20 dvonbeck SkLS now accepting nullptr for diffuse shader and normal source, now accurately handling alpha

BUG= 629408 

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review-Url: https://codereview.chromium.org/2159423003
Cr-Commit-Position: refs/heads/master@{#406659}

[modify] https://crrev.com/fe7bde006ea6d893c115aae0747d25e9f52fd43c/DEPS

Cc: ranjitkan@chromium.org
Labels: TE-Verified-M54 TE-Verified-54.0.2806.0 TE-Verified-54.0.2805.0
Rechecked this on Chrome Canary version 54.0.2806.0 (MAC OS), 54.0.2805.0 for Windows 7 and Ubuntu 14.04, fix is working as intended. Able click and navigate to web pages using thumbnails from Print view.

Adding TE-Verified labels.

Comment 14 by ajha@chromium.org, Aug 3 2016

reed@: Could you please close the issue as this is Verified and if there is no further work to be done here.

Comment 15 by reed@google.com, Aug 3 2016

Status: Fixed (was: Assigned)

Sign in to add a comment