ARC Opt in notification not shown. |
||||||
Issue descriptionARC Opt in notification is not shown. It's hidden in the notification center.
,
Jul 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ae0dad4690b7579921cd503e6a863467ef27bfe commit 3ae0dad4690b7579921cd503e6a863467ef27bfe Author: mtomasz <mtomasz@chromium.org> Date: Wed Jul 20 00:29:12 2016 ARC Opt in notification not shown. As the profile id is not set, the notifications are never shown to user. Instead they land in the notification center, and user needs to click on the "1" icon to see it. This CL fixes the issue by setting a correct profile id on the notification. TEST=Tested manually on a fresh profile. BUG= 629399 Review-Url: https://codereview.chromium.org/2160723004 Cr-Commit-Position: refs/heads/master@{#406428} [modify] https://crrev.com/3ae0dad4690b7579921cd503e6a863467ef27bfe/chrome/browser/chromeos/arc/arc_auth_notification.cc [modify] https://crrev.com/3ae0dad4690b7579921cd503e6a863467ef27bfe/chrome/browser/chromeos/arc/arc_auth_notification.h [modify] https://crrev.com/3ae0dad4690b7579921cd503e6a863467ef27bfe/chrome/browser/chromeos/arc/arc_auth_service.cc
,
Jul 20 2016
Requesting merge to 53. The fix is very simple.
,
Jul 20 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03b78159f8ddcaca8fb576d8cb3111a7b18df2cf commit 03b78159f8ddcaca8fb576d8cb3111a7b18df2cf Author: Tomasz Mikolajewski <mtomasz@chromium.org> Date: Fri Jul 22 07:32:57 2016 Merge: ARC Opt in notification not shown. As the profile id is not set, the notifications are never shown to user. Instead they land in the notification center, and user needs to click on the "1" icon to see it. This CL fixes the issue by setting a correct profile id on the notification. TEST=Tested manually on a fresh profile. BUG= 629399 Review-Url: https://codereview.chromium.org/2160723004 Cr-Commit-Position: refs/heads/master@{#406428} (cherry picked from commit 3ae0dad4690b7579921cd503e6a863467ef27bfe) Review URL: https://codereview.chromium.org/2171213002 . Cr-Commit-Position: refs/branch-heads/2785@{#285} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/03b78159f8ddcaca8fb576d8cb3111a7b18df2cf/chrome/browser/chromeos/arc/arc_auth_notification.cc [modify] https://crrev.com/03b78159f8ddcaca8fb576d8cb3111a7b18df2cf/chrome/browser/chromeos/arc/arc_auth_notification.h [modify] https://crrev.com/03b78159f8ddcaca8fb576d8cb3111a7b18df2cf/chrome/browser/chromeos/arc/arc_auth_service.cc
,
Jul 25 2016
,
Oct 4 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by sheriffbot@chromium.org
, Jul 19 2016