New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 629399 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
ARC



Sign in to add a comment

ARC Opt in notification not shown.

Project Member Reported by mtomasz@chromium.org, Jul 19 2016

Issue description

ARC Opt in notification is not shown. It's hidden in the notification center.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 19 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ae0dad4690b7579921cd503e6a863467ef27bfe

commit 3ae0dad4690b7579921cd503e6a863467ef27bfe
Author: mtomasz <mtomasz@chromium.org>
Date: Wed Jul 20 00:29:12 2016

ARC Opt in notification not shown.

As the profile id is not set, the notifications are never shown to user.
Instead they land in the notification center, and user needs to click
on the "1" icon to see it.

This CL fixes the issue by setting a correct profile id on the
notification.

TEST=Tested manually on a fresh profile.
BUG= 629399 

Review-Url: https://codereview.chromium.org/2160723004
Cr-Commit-Position: refs/heads/master@{#406428}

[modify] https://crrev.com/3ae0dad4690b7579921cd503e6a863467ef27bfe/chrome/browser/chromeos/arc/arc_auth_notification.cc
[modify] https://crrev.com/3ae0dad4690b7579921cd503e6a863467ef27bfe/chrome/browser/chromeos/arc/arc_auth_notification.h
[modify] https://crrev.com/3ae0dad4690b7579921cd503e6a863467ef27bfe/chrome/browser/chromeos/arc/arc_auth_service.cc

Labels: -M-54 -MovedFrom-53 Merge-Request-53 M-53
Requesting merge to 53. The fix is very simple.

Comment 4 by dimu@google.com, Jul 20 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 22 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03b78159f8ddcaca8fb576d8cb3111a7b18df2cf

commit 03b78159f8ddcaca8fb576d8cb3111a7b18df2cf
Author: Tomasz Mikolajewski <mtomasz@chromium.org>
Date: Fri Jul 22 07:32:57 2016

Merge: ARC Opt in notification not shown.

As the profile id is not set, the notifications are never shown to user.
Instead they land in the notification center, and user needs to click
on the "1" icon to see it.

This CL fixes the issue by setting a correct profile id on the
notification.

TEST=Tested manually on a fresh profile.
BUG= 629399 

Review-Url: https://codereview.chromium.org/2160723004
Cr-Commit-Position: refs/heads/master@{#406428}
(cherry picked from commit 3ae0dad4690b7579921cd503e6a863467ef27bfe)

Review URL: https://codereview.chromium.org/2171213002 .

Cr-Commit-Position: refs/branch-heads/2785@{#285}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/03b78159f8ddcaca8fb576d8cb3111a7b18df2cf/chrome/browser/chromeos/arc/arc_auth_notification.cc
[modify] https://crrev.com/03b78159f8ddcaca8fb576d8cb3111a7b18df2cf/chrome/browser/chromeos/arc/arc_auth_notification.h
[modify] https://crrev.com/03b78159f8ddcaca8fb576d8cb3111a7b18df2cf/chrome/browser/chromeos/arc/arc_auth_service.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment