MediaRouter interface implementation shouldn't DCHECK |
|||||||||
Issue descriptionIt is implemented in the browser. While the other side of the pipe appears to live in an extension process, extension renderer processes are still less trusted. So things like ConvertToPresentationSessionMessage() and RouteResponseReceived() should not have any DCHECKs.
,
Jul 19 2016
imcheng, I see there are files in there for Windows such as, "media_route_provider_util_win.cc" but not for any other platforms. What OS's does this code run on?
,
Jul 19 2016
Re c#2: The code in chrome/browser/media/router/mojo runs on all desktop OS - ChromeOS, Windows, Mac, Linux. media_route_provider_util_win.{h,cc} contains logic for checking the firewall, which is only done on Windows.
,
Jul 20 2016
,
Jul 20 2016
DoS are not security bugs.
,
Jul 25 2016
,
Jul 27 2016
,
Sep 9 2016
Ping Mark, is there action on this bug we should be taking? And for M54?
,
Sep 21 2016
,
Sep 28 2016
,
Oct 1 2016
,
Oct 1 2016
It looks like someone got to this already. I don't see any DCHECKS other than ones that check the internal consistency and correct threading of the MediaRouterMojoImpl. Let me know if there are other places that need to be cleaned up. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by dcheng@chromium.org
, Jul 19 2016