We have mojo types for these, so we should be using those instead of passing around ints.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7917313d7e4f0d8c83ebc93ef6d6db5e79ad643 commit b7917313d7e4f0d8c83ebc93ef6d6db5e79ad643 Author: btolsch <btolsch@chromium.org> Date: Wed Sep 14 18:09:01 2016 [Media Router] Use TimeDelta in mojo interfaces Use TimeDelta instead of an int representing milliseconds in Media Router mojo interfaces. BUG= 629375 Review-Url: https://codereview.chromium.org/2324133003 Cr-Commit-Position: refs/heads/master@{#418609} [modify] https://crrev.com/b7917313d7e4f0d8c83ebc93ef6d6db5e79ad643/chrome/browser/media/router/BUILD.gn [modify] https://crrev.com/b7917313d7e4f0d8c83ebc93ef6d6db5e79ad643/chrome/browser/media/router/mojo/media_router.mojom [modify] https://crrev.com/b7917313d7e4f0d8c83ebc93ef6d6db5e79ad643/chrome/browser/media/router/mojo/media_router_mojo_impl.cc [modify] https://crrev.com/b7917313d7e4f0d8c83ebc93ef6d6db5e79ad643/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc [modify] https://crrev.com/b7917313d7e4f0d8c83ebc93ef6d6db5e79ad643/chrome/browser/media/router/mojo/media_router_mojo_test.h [modify] https://crrev.com/b7917313d7e4f0d8c83ebc93ef6d6db5e79ad643/chrome/browser/media/router/mojo/media_router_struct_traits.h [modify] https://crrev.com/b7917313d7e4f0d8c83ebc93ef6d6db5e79ad643/extensions/renderer/dispatcher.cc [modify] https://crrev.com/b7917313d7e4f0d8c83ebc93ef6d6db5e79ad643/extensions/renderer/resources/extensions_renderer_resources.grd [modify] https://crrev.com/b7917313d7e4f0d8c83ebc93ef6d6db5e79ad643/extensions/renderer/resources/media_router_bindings.js [modify] https://crrev.com/b7917313d7e4f0d8c83ebc93ef6d6db5e79ad643/mojo/common/common_custom_types.mojom [modify] https://crrev.com/b7917313d7e4f0d8c83ebc93ef6d6db5e79ad643/mojo/common/common_custom_types_struct_traits.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41d79bc2e20416004dd0b8e4f4f4b040cab45a56 commit 41d79bc2e20416004dd0b8e4f4f4b040cab45a56 Author: jbroman <jbroman@chromium.org> Date: Wed Sep 14 21:08:04 2016 Fix missing dependency of //extensions:extensions_renderer_resources. This resolves "ninja explain" failures after: https://chromium.googlesource.com/chromium/src/+/b7917313d7e4f0d8c83ebc93ef6d6db5e79ad643 e.g. https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/297782 ninja explain: restat of output gen/extensions/extensions_renderer_resources_stamp.d.stamp older than most recent input /b/c/b/linux/src/out/Release/gen/mojo/common/common_custom_types.mojom.js (0 vs 1473884135) BUG= 629375 TBR=btolsch@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2338993003 Cr-Commit-Position: refs/heads/master@{#418672} [modify] https://crrev.com/41d79bc2e20416004dd0b8e4f4f4b040cab45a56/extensions/BUILD.gn
Comment 1 by dcheng@chromium.org
, Jul 19 2016