Issue 629374 link

Starred by 3 users

Issue metadata

Status:	Fixed
Owner:	steimel@chromium.org
Closed:	Feb 2017
Cc:	mfo...@chromium.org w...@chromium.org █ imch...@chromium.org btolsch@chromium.org powerb@chromium.org
Components:	Blink>PresentationAPI
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug
Hotlist-CodeHealth Hotlist-Fixit merge-merged-3005

Blocked on:
issue 689303

Blocking:
issue 629372

media router mojom shouldn't pass origins around as untyped strings

Project Member Reported by dcheng@chromium.org, Jul 19 2016

Issue description

Right now, the interface definition contains this:

  CreateRoute(string media_source,
              string sink_id,
              string original_presentation_id,
              string origin,
              int32 tab_id,
              int64 timeout_millis,
              bool off_the_record) =>
                  (MediaRoute? route,
                   string? error_text,
                   RouteRequestResultCode result_code);

Instead of passing this as a string, it should be passed a url.mojom.Origin (if possible) or a url.mojom.GURL (but then this probably isn't really an origin)

Comment 1 by mfo...@chromium.org, Jul 25 2016

Cc: mfo...@chromium.org imch...@chromium.org
Labels: -M-54 Hotlist-CodeHealth

Comment 2 by mfo...@chromium.org, Jul 25 2016

Cc: w...@chromium.org

Comment 3 by mfo...@chromium.org, Jul 25 2016

Labels: -Pri-2 Pri-3

Comment 4 by mfo...@chromium.org, Jul 25 2016

Status: Untriaged (was: Available)

Comment 5 by sko...@chromium.org, Jul 27 2016

Labels: Hotlist-Fixit
Status: Available (was: Untriaged)

Comment 6 by steimel@chromium.org, Dec 6 2016

Owner: steimel@chromium.org
Status: Assigned (was: Available)

Comment 7 by steimel@chromium.org, Jan 9 2017

Does this also apply to other instances of string origin within this file?

- JoinRoute
- ConnectRouteByRouteId
- OnSinksReceived

Comment 8 by mfo...@chromium.org, Jan 9 2017

Yes they should all be converted.  They should be using GURL now, but it would be better to use url::Origin.

Comment 9 by sko...@chromium.org, Jan 26 2017

 Issue 682931  has been merged into this issue.

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/588ccce1960c1ca47d65c75f5edb34e5e17d6deb

commit 588ccce1960c1ca47d65c75f5edb34e5e17d6deb
Author: steimel <steimel@chromium.org>
Date: Sat Jan 28 01:23:17 2017

Convert MediaRouter mojom apis to intake url::Origin objects instead of strings

Currently, MediaRouter passes origins around as strings in the mojom api, and as GURLs at a higher level. This CL changes both the strings and the GURLs to be url::Origins instead.

BUG= 629374 

Review-Url: https://codereview.chromium.org/2627463003
Cr-Commit-Position: refs/heads/master@{#446868}

[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/media/android/router/media_router_android.cc
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/media/android/router/media_router_android.h
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/media/android/router/media_router_dialog_controller_android.cc
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/media/router/BUILD.gn
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/media/router/create_presentation_connection_request.cc
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/media/router/create_presentation_connection_request.h
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/media/router/create_presentation_connection_request_unittest.cc
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/media/router/media_router.h
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/media/router/media_router_dialog_controller_unittest.cc
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/media/router/media_sinks_observer.cc
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/media/router/media_sinks_observer.h
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/media/router/media_sinks_observer_unittest.cc
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/media/router/mock_media_router.h
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/media/router/mojo/media_router.mojom
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/media/router/mojo/media_router_mojo_impl.h
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/media/router/mojo/media_router_mojo_test.h
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/media/router/presentation_media_sinks_observer.cc
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/media/router/presentation_media_sinks_observer.h
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/media/router/presentation_media_sinks_observer_unittest.cc
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/media/router/presentation_request.cc
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/media/router/presentation_request.h
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/media/router/presentation_request_unittest.cc
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/media/router/presentation_service_delegate_impl.cc
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/media/router/test_helper.cc
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/media/router/test_helper.h
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/ui/ash/cast_config_client_media_router.cc
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_unittest.cc
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/ui/webui/media_router/media_router_ui.h
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/ui/webui/media_router/query_result_manager.cc
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/ui/webui/media_router/query_result_manager.h
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/browser/ui/webui/media_router/query_result_manager_unittest.cc
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/test/media_router/media_router_e2e_browsertest.cc
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/test/media_router/media_router_e2e_browsertest.h
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/test/media_router/test_media_sinks_observer.cc
[modify] https://crrev.com/588ccce1960c1ca47d65c75f5edb34e5e17d6deb/chrome/test/media_router/test_media_sinks_observer.h

Comment 11 by steimel@chromium.org, Jan 30 2017

Status: Fixed (was: Assigned)

Project Member

Comment 12 by bugdroid1@chromium.org, Jan 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fcb4ac004446e6babe35d1d50adaa385280c770

commit 7fcb4ac004446e6babe35d1d50adaa385280c770
Author: imcheng <imcheng@chromium.org>
Date: Mon Jan 30 22:56:54 2017

Manual Revert of Convert MediaRouter mojom apis to intake url::Origin objects instead of strings (patchset #10 id:180001 of https://codereview.chromium.org/2627463003/ )

Reason for revert:
This broke Media Router:

1) Missing dependency on url/mojo/origin.mojom in extension's context (see https://codereview.chromium.org/2665853002/ for fix)

2) media_router_bindings.js and the extension code were not converted to use Origin objects.

Original issue's description:
> Convert MediaRouter mojom apis to intake url::Origin objects instead of strings
>
> Currently, MediaRouter passes origins around as strings in the mojom api, and as GURLs at a higher level. This CL changes both the strings and the GURLs to be url::Origins instead.
>
> BUG= 629374 
>
> Review-Url: https://codereview.chromium.org/2627463003
> Cr-Commit-Position: refs/heads/master@{#446868}
> Committed: https://chromium.googlesource.com/chromium/src/+/588ccce1960c1ca47d65c75f5edb34e5e17d6deb

TBR=mfoltz@chromium.org,dcheng@chromium.org,jdufault@chromium.org,wez@chromium.org,sky@chromium.org,steimel@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 629374 ,  686832 , 686836

Review-Url: https://codereview.chromium.org/2666743002
Cr-Commit-Position: refs/heads/master@{#447099}

[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/android/router/media_router_android.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/android/router/media_router_android.h
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/android/router/media_router_dialog_controller_android.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/BUILD.gn
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/create_presentation_connection_request.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/create_presentation_connection_request.h
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/create_presentation_connection_request_unittest.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/media_router.h
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/media_router_dialog_controller_unittest.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/media_sinks_observer.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/media_sinks_observer.h
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/media_sinks_observer_unittest.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/mock_media_router.h
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/mojo/media_router.mojom
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/mojo/media_router_mojo_impl.h
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/mojo/media_router_mojo_test.h
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/presentation_media_sinks_observer.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/presentation_media_sinks_observer.h
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/presentation_media_sinks_observer_unittest.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/presentation_request.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/presentation_request.h
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/presentation_request_unittest.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/presentation_service_delegate_impl.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/test_helper.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/media/router/test_helper.h
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/ui/ash/cast_config_client_media_router.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_unittest.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/ui/webui/media_router/media_router_ui.h
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/ui/webui/media_router/query_result_manager.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/ui/webui/media_router/query_result_manager.h
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/browser/ui/webui/media_router/query_result_manager_unittest.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/test/media_router/media_router_e2e_browsertest.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/test/media_router/media_router_e2e_browsertest.h
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/test/media_router/test_media_sinks_observer.cc
[modify] https://crrev.com/7fcb4ac004446e6babe35d1d50adaa385280c770/chrome/test/media_router/test_media_sinks_observer.h

Comment 13 by imch...@chromium.org, Jan 30 2017

Status: Assigned (was: Fixed)

Re-opened because of the revert. In addition to adding the dependency on origin.mojom, we'll need to ensure backwards compatibility between media_router_bindings.js and the extension code.

Comment 14 by mfo...@chromium.org, Jan 31 2017

Yeah.  I think a multi sided change will be required.

1. Reland this and convert Origin to string in bindings
2. Update component to take Origin or string
3. Undo conversion in #1 and remove string case from #2.

Project Member

Comment 15 by bugdroid1@chromium.org, Feb 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/441f2c5583174d5411ced1d308007b34a055a4fb

commit 441f2c5583174d5411ced1d308007b34a055a4fb
Author: steimel <steimel@chromium.org>
Date: Tue Feb 07 01:22:54 2017

Convert MediaRouter mojom apis to intake url::Origin objects instead of strings

Currently, MediaRouter passes origins around as strings in the mojom api, and as GURLs at a higher level. This CL changes both the strings and the GURLs to be url::Origins instead.

BUG= 629374 

Review-Url: https://codereview.chromium.org/2627463003
Cr-Original-Commit-Position: refs/heads/master@{#446868}
Committed: https://chromium.googlesource.com/chromium/src/+/588ccce1960c1ca47d65c75f5edb34e5e17d6deb
Review-Url: https://codereview.chromium.org/2627463003
Cr-Commit-Position: refs/heads/master@{#448492}

[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/media/android/router/media_router_android.cc
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/media/android/router/media_router_android.h
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/media/android/router/media_router_dialog_controller_android.cc
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/media/router/BUILD.gn
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/media/router/create_presentation_connection_request.cc
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/media/router/create_presentation_connection_request.h
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/media/router/create_presentation_connection_request_unittest.cc
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/media/router/media_router.h
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/media/router/media_router_dialog_controller_unittest.cc
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/media/router/media_sinks_observer.cc
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/media/router/media_sinks_observer.h
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/media/router/media_sinks_observer_unittest.cc
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/media/router/mock_media_router.h
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/media/router/mojo/media_router.mojom
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/media/router/mojo/media_router_mojo_impl.h
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/media/router/mojo/media_router_mojo_test.h
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/media/router/presentation_media_sinks_observer.cc
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/media/router/presentation_media_sinks_observer.h
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/media/router/presentation_media_sinks_observer_unittest.cc
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/media/router/presentation_request.cc
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/media/router/presentation_request.h
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/media/router/presentation_request_unittest.cc
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/media/router/presentation_service_delegate_impl.cc
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/media/router/test_helper.cc
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/media/router/test_helper.h
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/ui/ash/cast_config_client_media_router.cc
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_unittest.cc
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/ui/webui/media_router/media_router_ui.h
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/ui/webui/media_router/query_result_manager.cc
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/ui/webui/media_router/query_result_manager.h
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/browser/ui/webui/media_router/query_result_manager_unittest.cc
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/test/media_router/media_router_e2e_browsertest.cc
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/test/media_router/media_router_e2e_browsertest.h
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/test/media_router/test_media_sinks_observer.cc
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/chrome/test/media_router/test_media_sinks_observer.h
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/extensions/renderer/dispatcher.cc
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/extensions/renderer/resources/extensions_renderer_resources.grd
[modify] https://crrev.com/441f2c5583174d5411ced1d308007b34a055a4fb/extensions/renderer/resources/media_router_bindings.js

Project Member

Comment 16 by bugdroid1@chromium.org, Feb 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35b4a8553a6b68f24297006c39168f5ff4aa0468

commit 35b4a8553a6b68f24297006c39168f5ff4aa0468
Author: shimazu <shimazu@chromium.org>
Date: Tue Feb 07 02:01:09 2017

Revert of Convert MediaRouter mojom apis to intake url::Origin objects instead of strings (patchset #16 id:300001 of https://codereview.chromium.org/2627463003/ )

Reason for revert:
Compilation failure on Google Chrome Mac.
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/builds/18243

Original issue's description:
> Convert MediaRouter mojom apis to intake url::Origin objects instead of strings
>
> Currently, MediaRouter passes origins around as strings in the mojom api, and as GURLs at a higher level. This CL changes both the strings and the GURLs to be url::Origins instead.
>
> BUG= 629374 
>
> Review-Url: https://codereview.chromium.org/2627463003
> Cr-Original-Commit-Position: refs/heads/master@{#446868}
> Committed: https://chromium.googlesource.com/chromium/src/+/588ccce1960c1ca47d65c75f5edb34e5e17d6deb
> Review-Url: https://codereview.chromium.org/2627463003
> Cr-Commit-Position: refs/heads/master@{#448492}
> Committed: https://chromium.googlesource.com/chromium/src/+/441f2c5583174d5411ced1d308007b34a055a4fb

TBR=mfoltz@chromium.org,benwells@chromium.org,dcheng@chromium.org,imcheng@chromium.org,jdufault@chromium.org,sky@chromium.org,wez@chromium.org,steimel@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 629374 

Review-Url: https://codereview.chromium.org/2678123003
Cr-Commit-Position: refs/heads/master@{#448508}

[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/media/android/router/media_router_android.cc
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/media/android/router/media_router_android.h
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/media/android/router/media_router_dialog_controller_android.cc
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/media/router/BUILD.gn
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/media/router/create_presentation_connection_request.cc
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/media/router/create_presentation_connection_request.h
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/media/router/create_presentation_connection_request_unittest.cc
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/media/router/media_router.h
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/media/router/media_router_dialog_controller_unittest.cc
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/media/router/media_sinks_observer.cc
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/media/router/media_sinks_observer.h
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/media/router/media_sinks_observer_unittest.cc
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/media/router/mock_media_router.h
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/media/router/mojo/media_router.mojom
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/media/router/mojo/media_router_mojo_impl.h
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/media/router/mojo/media_router_mojo_test.h
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/media/router/presentation_media_sinks_observer.cc
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/media/router/presentation_media_sinks_observer.h
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/media/router/presentation_media_sinks_observer_unittest.cc
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/media/router/presentation_request.cc
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/media/router/presentation_request.h
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/media/router/presentation_request_unittest.cc
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/media/router/presentation_service_delegate_impl.cc
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/media/router/test_helper.cc
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/media/router/test_helper.h
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/ui/ash/cast_config_client_media_router.cc
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_unittest.cc
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/ui/webui/media_router/media_router_ui.h
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/ui/webui/media_router/query_result_manager.cc
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/ui/webui/media_router/query_result_manager.h
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/browser/ui/webui/media_router/query_result_manager_unittest.cc
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/test/media_router/media_router_e2e_browsertest.cc
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/test/media_router/media_router_e2e_browsertest.h
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/test/media_router/test_media_sinks_observer.cc
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/chrome/test/media_router/test_media_sinks_observer.h
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/extensions/renderer/dispatcher.cc
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/extensions/renderer/resources/extensions_renderer_resources.grd
[modify] https://crrev.com/35b4a8553a6b68f24297006c39168f5ff4aa0468/extensions/renderer/resources/media_router_bindings.js

Comment 17 by tapted@chromium.org, Feb 7 2017

Blockedon: 689303

Project Member

Comment 18 by bugdroid1@chromium.org, Feb 7 2017

Labels: merge-merged-3005

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03114996f3e50115f2ac72ef27a79836f715ae40

commit 03114996f3e50115f2ac72ef27a79836f715ae40
Author: Trent Apted <tapted@chromium.org>
Date: Tue Feb 07 05:27:13 2017

[merge 3005-dev] Revert of Convert MediaRouter mojom apis to intake url::Origin objects instead of strings (patchset #16 id:300001 of https://codereview.chromium.org/2627463003/ )

Reason for revert:
Compilation failure on Google Chrome Mac.
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/builds/18243

Original issue's description:
> Convert MediaRouter mojom apis to intake url::Origin objects instead of strings
>
> Currently, MediaRouter passes origins around as strings in the mojom api, and as GURLs at a higher level. This CL changes both the strings and the GURLs to be url::Origins instead.
>
> BUG= 629374 
>
> Review-Url: https://codereview.chromium.org/2627463003
> Cr-Original-Commit-Position: refs/heads/master@{#446868}
> Committed: https://chromium.googlesource.com/chromium/src/+/588ccce1960c1ca47d65c75f5edb34e5e17d6deb
> Review-Url: https://codereview.chromium.org/2627463003
> Cr-Commit-Position: refs/heads/master@{#448492}
> Committed: https://chromium.googlesource.com/chromium/src/+/441f2c5583174d5411ced1d308007b34a055a4fb

TBR=mfoltz@chromium.org,benwells@chromium.org,dcheng@chromium.org,imcheng@chromium.org,jdufault@chromium.org,sky@chromium.org,wez@chromium.org,steimel@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 629374 , 689303

Review-Url: https://codereview.chromium.org/2678123003
Cr-Commit-Position: refs/heads/master@{#448508}
(cherry picked from commit 35b4a8553a6b68f24297006c39168f5ff4aa0468)

Review-Url: https://codereview.chromium.org/2678273002 .
Cr-Commit-Position: refs/branch-heads/3005@{#2}
Cr-Branched-From: 75481c5507579245a81f8b75298a17a269fce1fa-refs/heads/master@{#448507}

[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/media/android/router/media_router_android.cc
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/media/android/router/media_router_android.h
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/media/android/router/media_router_dialog_controller_android.cc
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/media/router/BUILD.gn
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/media/router/create_presentation_connection_request.cc
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/media/router/create_presentation_connection_request.h
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/media/router/create_presentation_connection_request_unittest.cc
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/media/router/media_router.h
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/media/router/media_router_dialog_controller_unittest.cc
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/media/router/media_sinks_observer.cc
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/media/router/media_sinks_observer.h
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/media/router/media_sinks_observer_unittest.cc
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/media/router/mock_media_router.h
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/media/router/mojo/media_router.mojom
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/media/router/mojo/media_router_mojo_impl.h
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/media/router/mojo/media_router_mojo_test.h
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/media/router/presentation_media_sinks_observer.cc
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/media/router/presentation_media_sinks_observer.h
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/media/router/presentation_media_sinks_observer_unittest.cc
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/media/router/presentation_request.cc
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/media/router/presentation_request.h
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/media/router/presentation_request_unittest.cc
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/media/router/presentation_service_delegate_impl.cc
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/media/router/test_helper.cc
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/media/router/test_helper.h
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/ui/ash/cast_config_client_media_router.cc
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_unittest.cc
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/ui/webui/media_router/media_router_ui.h
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/ui/webui/media_router/query_result_manager.cc
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/ui/webui/media_router/query_result_manager.h
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/browser/ui/webui/media_router/query_result_manager_unittest.cc
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/test/media_router/media_router_e2e_browsertest.cc
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/test/media_router/media_router_e2e_browsertest.h
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/test/media_router/test_media_sinks_observer.cc
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/chrome/test/media_router/test_media_sinks_observer.h
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/extensions/renderer/dispatcher.cc
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/extensions/renderer/resources/extensions_renderer_resources.grd
[modify] https://crrev.com/03114996f3e50115f2ac72ef27a79836f715ae40/extensions/renderer/resources/media_router_bindings.js

Project Member

Comment 19 by bugdroid1@chromium.org, Feb 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2537528e220f768c47177abbb4c6b13d4d047117

commit 2537528e220f768c47177abbb4c6b13d4d047117
Author: steimel <steimel@chromium.org>
Date: Tue Feb 07 23:09:23 2017

Convert MediaRouter mojom apis to intake url::Origin objects instead of strings

Currently, MediaRouter passes origins around as strings in the mojom api, and as GURLs at a higher level. This CL changes both the strings and the GURLs to be url::Origins instead.

BUG= 629374 

Review-Url: https://codereview.chromium.org/2627463003
Cr-Original-Original-Commit-Position: refs/heads/master@{#446868}
Committed: https://chromium.googlesource.com/chromium/src/+/588ccce1960c1ca47d65c75f5edb34e5e17d6deb
Review-Url: https://codereview.chromium.org/2627463003
Cr-Original-Commit-Position: refs/heads/master@{#448492}
Committed: https://chromium.googlesource.com/chromium/src/+/441f2c5583174d5411ced1d308007b34a055a4fb
Review-Url: https://codereview.chromium.org/2627463003
Cr-Commit-Position: refs/heads/master@{#448771}

[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/media/android/router/media_router_android.cc
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/media/android/router/media_router_android.h
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/media/android/router/media_router_dialog_controller_android.cc
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/media/router/BUILD.gn
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/media/router/create_presentation_connection_request.cc
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/media/router/create_presentation_connection_request.h
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/media/router/create_presentation_connection_request_unittest.cc
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/media/router/media_router.h
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/media/router/media_router_dialog_controller_unittest.cc
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/media/router/media_sinks_observer.cc
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/media/router/media_sinks_observer.h
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/media/router/media_sinks_observer_unittest.cc
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/media/router/mock_media_router.h
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/media/router/mojo/media_router.mojom
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/media/router/mojo/media_router_mojo_impl.h
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/media/router/mojo/media_router_mojo_test.h
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/media/router/presentation_media_sinks_observer.cc
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/media/router/presentation_media_sinks_observer.h
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/media/router/presentation_media_sinks_observer_unittest.cc
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/media/router/presentation_request.cc
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/media/router/presentation_request.h
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/media/router/presentation_request_unittest.cc
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/media/router/presentation_service_delegate_impl.cc
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/media/router/test_helper.cc
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/media/router/test_helper.h
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/ui/ash/cast_config_client_media_router.cc
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_unittest.cc
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/ui/webui/media_router/media_router_ui.h
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/ui/webui/media_router/query_result_manager.cc
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/ui/webui/media_router/query_result_manager.h
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/browser/ui/webui/media_router/query_result_manager_unittest.cc
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/test/media_router/media_router_e2e_browsertest.cc
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/test/media_router/media_router_e2e_browsertest.h
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/test/media_router/test_media_sinks_observer.cc
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/chrome/test/media_router/test_media_sinks_observer.h
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/extensions/BUILD.gn
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/extensions/renderer/dispatcher.cc
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/extensions/renderer/resources/extensions_renderer_resources.grd
[modify] https://crrev.com/2537528e220f768c47177abbb4c6b13d4d047117/extensions/renderer/resources/media_router_bindings.js

Comment 20 by steimel@chromium.org, Feb 8 2017

Status: Fixed (was: Assigned)

►

Issue 629374 link

Issue metadata

media router mojom shouldn't pass origins around as untyped strings

Issue description

Comment 1 by mfo...@chromium.org, Jul 25 2016

Comment 1 Deleted

Comment 2 by mfo...@chromium.org, Jul 25 2016

Comment 2 Deleted

Comment 3 by mfo...@chromium.org, Jul 25 2016

Comment 3 Deleted

Comment 4 by mfo...@chromium.org, Jul 25 2016

Comment 4 Deleted

Comment 5 by sko...@chromium.org, Jul 27 2016

Comment 5 Deleted

Comment 6 by steimel@chromium.org, Dec 6 2016

Comment 6 Deleted

Comment 7 by steimel@chromium.org, Jan 9 2017

Comment 7 Deleted

Comment 8 by mfo...@chromium.org, Jan 9 2017

Comment 8 Deleted

Comment 9 by sko...@chromium.org, Jan 26 2017

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Jan 28 2017

Comment 10 Deleted

Comment 11 by steimel@chromium.org, Jan 30 2017

Comment 11 Deleted

Comment 12 by bugdroid1@chromium.org, Jan 30 2017

Comment 12 Deleted

Comment 13 by imch...@chromium.org, Jan 30 2017

Comment 13 Deleted

Comment 14 by mfo...@chromium.org, Jan 31 2017

Comment 14 Deleted

Comment 15 by bugdroid1@chromium.org, Feb 7 2017

Comment 15 Deleted

Comment 16 by bugdroid1@chromium.org, Feb 7 2017

Comment 16 Deleted

Comment 17 by tapted@chromium.org, Feb 7 2017

Comment 17 Deleted

Comment 18 by bugdroid1@chromium.org, Feb 7 2017

Comment 18 Deleted

Comment 19 by bugdroid1@chromium.org, Feb 7 2017

Comment 19 Deleted

Comment 20 by steimel@chromium.org, Feb 8 2017

Comment 20 Deleted

Sign in to add a comment