New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 629373 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 629372



Sign in to add a comment

Get rid of type converters in //chrome/browser/media/router/mojo

Project Member Reported by dcheng@chromium.org, Jul 19 2016

Issue description

Type converters are deprecated. For enums, please use EnumTraits. For Mojo structs, please use StructTraits. More information on using type mapping can be found at https://www.chromium.org/developers/design-documents/mojo/type-mapping
 

Comment 1 by m...@chromium.org, Jul 25 2016

Owner: imch...@chromium.org
Status: Assigned (was: Available)

Comment 2 by mfo...@chromium.org, Jul 25 2016

Cc: mfo...@chromium.org
Labels: -M-54 Hotlist-CodeHealth
Status: Available (was: Assigned)

Comment 3 by mfo...@chromium.org, Jul 25 2016

Cc: w...@chromium.org

Comment 4 by mfo...@chromium.org, Jul 25 2016

Labels: -Pri-2 Pri-3

Comment 5 by mfo...@chromium.org, Jan 10 2017

This has been done for:

media_router::IssueInfo (and related enums)
media_router::RouteMessage

TBD:

media_router::MediaSink
media_router::MediaRoute
media_router::SinkSearchCriteria
media_router::RouteRequestResultCode




Status: Assigned (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab1bf635d077f765c43a498d0b95034e2d564b4b

commit ab1bf635d077f765c43a498d0b95034e2d564b4b
Author: imcheng <imcheng@chromium.org>
Date: Thu Feb 16 03:30:07 2017

[Media Router] Convert to use typemaps for media_router.mojom.

Replaces the type converters in media_router_type_converters.* with
typemaps.

- MediaSink
- MediaRoute
- PresentationConnectionState
- PresentationConnectionCloseReason
- RouteRequestResultCode

BUG= 629373 

Review-Url: https://codereview.chromium.org/2666873006
Cr-Commit-Position: refs/heads/master@{#450860}

[modify] https://crrev.com/ab1bf635d077f765c43a498d0b95034e2d564b4b/chrome/browser/media/android/router/media_router_android.cc
[modify] https://crrev.com/ab1bf635d077f765c43a498d0b95034e2d564b4b/chrome/browser/media/router/BUILD.gn
[modify] https://crrev.com/ab1bf635d077f765c43a498d0b95034e2d564b4b/chrome/browser/media/router/media_route.cc
[modify] https://crrev.com/ab1bf635d077f765c43a498d0b95034e2d564b4b/chrome/browser/media/router/media_route.h
[modify] https://crrev.com/ab1bf635d077f765c43a498d0b95034e2d564b4b/chrome/browser/media/router/media_sink.cc
[modify] https://crrev.com/ab1bf635d077f765c43a498d0b95034e2d564b4b/chrome/browser/media/router/media_sink.h
[modify] https://crrev.com/ab1bf635d077f765c43a498d0b95034e2d564b4b/chrome/browser/media/router/media_source.cc
[modify] https://crrev.com/ab1bf635d077f765c43a498d0b95034e2d564b4b/chrome/browser/media/router/media_source.h
[modify] https://crrev.com/ab1bf635d077f765c43a498d0b95034e2d564b4b/chrome/browser/media/router/mojo/OWNERS
[modify] https://crrev.com/ab1bf635d077f765c43a498d0b95034e2d564b4b/chrome/browser/media/router/mojo/media_router.typemap
[modify] https://crrev.com/ab1bf635d077f765c43a498d0b95034e2d564b4b/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
[modify] https://crrev.com/ab1bf635d077f765c43a498d0b95034e2d564b4b/chrome/browser/media/router/mojo/media_router_mojo_impl.h
[modify] https://crrev.com/ab1bf635d077f765c43a498d0b95034e2d564b4b/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc
[modify] https://crrev.com/ab1bf635d077f765c43a498d0b95034e2d564b4b/chrome/browser/media/router/mojo/media_router_struct_traits.cc
[modify] https://crrev.com/ab1bf635d077f765c43a498d0b95034e2d564b4b/chrome/browser/media/router/mojo/media_router_struct_traits.h
[delete] https://crrev.com/c80d2d2b0fcceac67a16bf6ffb516ba5c0023230/chrome/browser/media/router/mojo/media_router_type_converters.cc
[delete] https://crrev.com/c80d2d2b0fcceac67a16bf6ffb516ba5c0023230/chrome/browser/media/router/mojo/media_router_type_converters.h
[delete] https://crrev.com/c80d2d2b0fcceac67a16bf6ffb516ba5c0023230/chrome/browser/media/router/mojo/media_router_type_converters_unittest.cc
[modify] https://crrev.com/ab1bf635d077f765c43a498d0b95034e2d564b4b/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/ab1bf635d077f765c43a498d0b95034e2d564b4b/chrome/browser/media/router/route_request_result.cc
[modify] https://crrev.com/ab1bf635d077f765c43a498d0b95034e2d564b4b/chrome/browser/media/router/route_request_result.h
[modify] https://crrev.com/ab1bf635d077f765c43a498d0b95034e2d564b4b/chrome/browser/ui/ash/cast_config_client_media_router.cc
[modify] https://crrev.com/ab1bf635d077f765c43a498d0b95034e2d564b4b/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
[modify] https://crrev.com/ab1bf635d077f765c43a498d0b95034e2d564b4b/chrome/test/BUILD.gn

Status: Fixed (was: Assigned)

Sign in to add a comment