New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 629368 link

Starred by 2 users

Issue metadata

Status: Verified
Owner: ----
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Enterprise Autotest Refactor: Remove mode variable

Project Member Reported by kathrelk...@chromium.org, Jul 19 2016

Issue description

With  issue 629355  completed, we'll have no need for mode 'all' and 'list'.  'by_case' and 'by_value' should collapse into the same case.

Thus, we can remove self.mode entirely.  This change will obviate the run_once_implementation() function and return us to run_once() like other autotests.
 
Owner: scunning...@chromium.org
Status: Assigned (was: Available)
Oops, #0 should say  issue 629357 

Comment 3 Deleted

Enterprise Autotest Plan Q3 2016: http://go/cros-ent-atp-16q3

Comment 5 Deleted

Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f00a5b79efbf3674d39ed2a76cb95ca0436c99b2

commit f00a5b79efbf3674d39ed2a76cb95ca0436c99b2
Author: Scott Cunningham <scunningham@chromium.org>
Date: Wed Jul 27 01:36:35 2016

Remove self.mode var, and mode parameter from --args

We have no need for mode 'all' and 'list'. When 629357 is done, all
cases will run individually (like they do in 'single' mode today),
so we have no need of 'single' mode. Also, 'by_case' and 'by_value'
should collapse into the same case.

Thus, we can safely remove the self.mode variable and command line
argument entirely.  This change will obviate the run_once_impl()
function and return us to using run_once() like other autotests.

BUG= chromium:629368 
TEST=Run test_that <IP> on any policy_* test with the following
arguments: none | value=a_valid_value | case=a_valid_case
Also run with env=dm-fake, dm-test, cr-alpha, and prod

Change-Id: I79fa1e8e985c246b3d02b03cadd27314de4a736b
Reviewed-on: https://chromium-review.googlesource.com/363584
Commit-Ready: Katherine Threlkeld <kathrelkeld@chromium.org>
Tested-by: Scott Cunningham <scunningham@chromium.org>
Reviewed-by: Scott Cunningham <scunningham@chromium.org>
Reviewed-by: Katherine Threlkeld <kathrelkeld@chromium.org>

[modify] https://crrev.com/f00a5b79efbf3674d39ed2a76cb95ca0436c99b2/client/cros/enterprise_policy_base.py

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
No regression of tests running in HW lab. Flakiness is the same. https://wmatrix.googleplex.com/unfiltered?hide_experimental=true&days_back=14&tests=policy_.*
Owner: ----

Sign in to add a comment