New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 629365 link

Starred by 2 users
Status: WontFix
Owner:
jamescook@chromium.org
Closed: Dec 2016
Cc:
derat@chromium.org
xiy...@chromium.org
█ ben@chromium.org
sadrul@chromium.org
jamescook@chromium.org
sky@chromium.org
osh...@chromium.org
steve...@chromium.org
achuith@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Do not build ChromeOS specific code on Windows

Project Member Reported by sadrul@chromium.org, Jul 19 2016 
There's a bunch of code in ash that is only useful for ChromeOS, but doesn't do anything on Windows/Linux desktop builds. We should exclude these files from non-chromeos builds. Some examples:
  LockStateController
  PowerButtonController
  SessionStateDelegate
  DisplayManager
  DisplayConfigurationController

Filing under mus (doesn't look like there's any monorail component for ash)

Comment 1 by jamescook@chromium.org, Jul 19 2016

Cc: steve...@chromium.org
At one point weren't we trying to move login state stuff into //chromeos? I see https://cs.chromium.org/chromium/src/chromeos/login/login_state.h down there.

Comment 2 by steve...@chromium.org, Jul 19 2016

Cc: achuith@chromium.org
//chromeos contains some login glue code with no other dependencies but that is all. This was a stopgap measure to avoid yet-another-delegate for ash until login code was moved from chrome -> components.

Unfortunately I think that the componentization of login (components/login, components/user_manager, etc) has stalled out some. +achuith@ who should know more about where that is at.

Comment 3 by rjkroege@chromium.org, Aug 8 2016

Owner: achuith@chromium.org
Who should own this? achuith@ can you reassign appropriately?

Comment 4 by rjkroege@chromium.org, Oct 4 2016

Labels: Proj-Mustash

Comment 5 by rjkroege@chromium.org, Oct 4 2016

Components: Internals>MUS

Comment 6 by jamescook@chromium.org, Oct 5 2016

Cc: xiy...@chromium.org
+xiyuan re: login stuff

Comment 7 by rjkroege@chromium.org, Dec 13 2016

Owner: jamescook@chromium.org
Status: Assigned (was: Available)
jamescook@ this would seem to be obsolete/foldable into 666773?

Comment 8 by jamescook@chromium.org, Dec 13 2016

Status: WontFix (was: Assigned)
Yeah, obsolete. We no longer compile this stuff on Windows/Linux.

Comment 9 by lafo...@chromium.org, Feb 26 2018

Components: -Internals>MUS Internals>Services>WindowService

Comment 10 by lafo...@chromium.org, Feb 26 2018

Components: -MUS
►

Sign in to add a comment