New issue
Advanced search Search tips

Issue 629354 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Memory.Browser.Large reports incorrect numbers

Project Member Reported by bashi@chromium.org, Jul 19 2016

Issue description

The unit is MB but it reports in KB.

Also we should have the same metric for renderer process.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5ab9c63598a171e32513ae23df9c034cbd9849b

commit a5ab9c63598a171e32513ae23df9c034cbd9849b
Author: bashi <bashi@chromium.org>
Date: Tue Jul 19 11:16:18 2016

Add Memory.{Browser,Renderer}.Large2 metrics

Memory.Browser.Large reports incorrect numbers (it should report in
MB but in KB now). Deprecate it and add a new metric to report
correct numbers. Also deprecate Memory.{Browser,Renderer} because
they are capped at .5GB which isn't enough. Memory.Renderer is
replaced with Memory.Renderer.Large2 ("Large2" is for consistency).

BUG= 629354 

Review-Url: https://codereview.chromium.org/2162783002
Cr-Commit-Position: refs/heads/master@{#406245}

[modify] https://crrev.com/a5ab9c63598a171e32513ae23df9c034cbd9849b/chrome/browser/metrics/metrics_memory_details.cc
[modify] https://crrev.com/a5ab9c63598a171e32513ae23df9c034cbd9849b/chrome/browser/metrics/metrics_memory_details_browsertest.cc
[modify] https://crrev.com/a5ab9c63598a171e32513ae23df9c034cbd9849b/tools/metrics/histograms/histograms.xml

Comment 2 by bashi@chromium.org, Jul 19 2016

Status: Fixed (was: Started)

Sign in to add a comment